September 2021 - flashrom-gerrit

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by Nico Huber (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Deomid "rojer" Ryabkov, Tim Chu. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I stepped in here *on your behalf* to *agree* >with you< to get David to align > with you < and you are already pointing fingers at me LOL it is comical. Just absurd on a human level and I hope you can reflect on this. Yes, I pointed fingers at you. But from my point of view, you started it. Wasn't this you pointing at me? > Just no need to threaten forkage whenever someone makes a mistake Feelings go both ways. If I read something like this, I react to it. > This isn't Nico's project it is a community project. You are a very smart person no question but consider caring for how people feel and you may realise how much they are wiling to listen more. I have often reflected about this. Whenever things escalated it seems people stomped on my feelings first. The difference might be that I don't complain about it as much and try to keep things technical. I'm generally a very patient person. However, there are situations where I completely drop all politeness. When I see somebody using their Gerrit privileges to force other people into working for them, it's definitely among such situations. When the first -2 was set, I deliberately stopped helping David to understand things because I don't allow myself to help when I'm feeling forced. I don't think it's fair to use any words written after such a -2 to argue about the general behavior in a project. -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 13:37:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: David Hendricks Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by Edward O'Callaghan (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Deomid "rojer" Ryabkov, Tim Chu. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > > You asked about freq_read and ICCRIBA […] Nico, without entertaining this too much further you can also come off as highly offensive at times by how tone deaf you can be. Having talked to you I know you do not intend to but in writing you can be read as that. >> That's why I asked him to slow down. He just ignored that. I could >> try to explain myself over and over again, but where should I get >> the time to do so? I can answer why this is fundamentally happening, it depends if you are willing enough to be scientific in your thinking and be prepared to reject your existing bias for another prospective. If you want people to come along with you wouldn't it be better not to make them enemies by pointing fingers? If nothing else but for pure pragmatism at the very least. I stepped in here *on your behalf* to *agree* >with you< to get David to align > with you < and you are already pointing fingers at me LOL it is comical. Just absurd on a human level and I hope you can reflect on this. This isn't Nico's project it is a community project. You are a very smart person no question but consider caring for how people feel and you may realise how much they are wiling to listen more. You are not perfect either, you broke layout with a intermediate patch, no one is infallible. Not 'Maybe' I don't doubt David or any other community members sincerity in their desire to contribute meaningful changes. It's not all a conspiracy to not listen to Nico and annoy him and make him fix everything for us. Unfortunately there is a world pandemic (which btw is extremely stressful for many people without this frankly less important stress in the scheme of things) otherwise one suggestion would be we could run some kind of Flashrom meet up. I think if we could do one as a online meeting that could help perhaps reduce some of these tensions and keep people on the same page. I've been trying to get enough time to sort this out and also a bug tracker for the project. These stories each of us perhaps build up in our heads online without talking and being social degrades trust in one another and stops us from listening as a community. You are too focused on one dimension to the problem, and it is correct we have technical issues to address but it seems to me we also have social issues to address in the community. -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 12:52:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: David Hendricks Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by Nico Huber (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Deomid "rojer" Ryabkov, Tim Chu. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > You asked about freq_read and ICCRIBA I did not. I asked a very simple question: > Have you looked into the SPI guides what changed exactly in the descriptor? Then I stated a hypothesis around the freq_read and ICCRIBA changes. David, this is another instance where you twisted my words. Please read more carefully what I write. I try to keep it to grammatically correct sentences. Please read and quote those fully, and ask if anything is unclear. -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 10:44:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: David Hendricks Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Explicitly check for Ibex Peak ISL value
by Angel Pons (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57633 ) Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value ...................................................................... Patch Set 2: -Code-Review (2 comments) Patchset: PS2: > This looks like it suffers from the same problem as another patch that > I gave a -2 for a reason. You indirectly change paths (look at what > cases hit GEMINILAKE for instance) without noticing. I'm pretty sure the APL/GLK descriptors never have ISL <= 16, so it shouldn't be an issue. But I could be wrong, so let's try to preserve the current behavior. > The current patch also changes when the warning is printed (not anymore > for ISL < 16) while the commit message states otherwise. Indeed, this is an issue. File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/57633/comment/5a7a029e_d8c6e5af PS2, Line 936: if (content->ISL <= 16) : return CHIPSET_5_SERIES_IBEX_PEAK; > How about: […] Based on Nico's comment, looks like this should be placed after the `if (content->FLMAP2 == 0) { ... }` block. -- To view, visit https://review.coreboot.org/c/flashrom/+/57633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52 Gerrit-Change-Number: 57633 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 10:33:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Explicitly check for Ibex Peak ISL value
by Nico Huber (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57633 ) Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: This looks like it suffers from the same problem as another patch that I gave a -2 for a reason. You indirectly change paths (look at what cases hit GEMINILAKE for instance) without noticing. The current patch also changes when the warning is printed (not anymore for ISL < 16) while the commit message states otherwise. If I had the time to further attend this, it would get another -2. Please slow down. You are really forcing me to look into things I don't want to but evidently have to to prevent further breakage. -- To view, visit https://review.coreboot.org/c/flashrom/+/57633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52 Gerrit-Change-Number: 57633 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 10:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by Nico Huber (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Deomid "rojer" Ryabkov, Tim Chu. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Nico => It is sufficient to say revert-first upon breakage, you are absolutely right there. Just no need to threaten forkage whenever someone makes a mistake, What's the mistake here? I don't mind if something slips review. But taking the branch hostage with a -2 seems pretty offensive. Also, I didn't mean it as a threat. It's a simple causality. There are too many people with submit rights. Some are trigger happy and others don't want breakage. It's easy for the former to force the latter to work for them. CB:54965 has a very low priority for me. Still I took the time to comment on it in the hope that people wouldn't ignore it; still I had to work on it for the past two days. My time is limited and this will set another release back by a month or so (unless we just punch another one through without reviewing all the prematurely merged code since the last one). I don't see how we can continue under these circumstances. If you see a better solution than to fork, please advice me. Edward, I know you have slowed down piling up new work by now, but I also see nothing done to reduce the already piled (prematurely merged) work. For instance, CB:44073 you know for some time now that it's flawed. Will you ever look into it or is that left to me? I have a plan for some time now to branch at v1.2 and cherry-pick from master to it, instead of cleaning up after others. If that would be a fully-fledged flashrom fork, idk. More likely to be something my employer requires plus everything easy to keep running (e.g. all SPI flash stuff). Or maybe just a libflashrom2 with a separate UI project. > I would imagine David does care about your concern already. Maybe. > Your technical arguments are sufficient on their own merit they just need to be understood by the reader. I think what happened here is that you can see something obvious to you but not obvious to David. Let's be patient and care about one another as humans first. That's why I asked him to slow down. He just ignored that. I could try to explain myself over and over again, but where should I get the time to do so? David, you have two times in a row in this thread quoted me only partially. It does no good. You just reply to half of a sentence which makes no sense without the other half. My code example came with the words "Makes no sense, no matter the context,". It doesn't help to add and discuss context in such a case (where the context doesn't matter). I hope you see the problem here. I extracted this code example in the hope that you'll see that it's wrong when not distracted by the context. Then you added distracting context again... It's good to see the -2 removed here. Would you also agree to merge the revert even if I don't have the time to review your follow ups before the next release? -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 10:11:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: David Hendricks Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for Intel Emmitsburg PCH
by Angel Pons (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57635 ) Change subject: Add support for Intel Emmitsburg PCH ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57635/comment/4f4ae384_2615e4b4 PS1, Line 16: TESTED=tried on a server with Intel Emmitsburg PCH, flash update : was successful. This server, however, does not have flash chip : installed, it instead has em100 emulator connected. Was the current patch tested like this too? -- To view, visit https://review.coreboot.org/c/flashrom/+/57635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Gerrit-Change-Number: 57635 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 08:32:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for Intel Emmitsburg PCH
by Angel Pons (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57635 ) Change subject: Add support for Intel Emmitsburg PCH ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/57635/comment/e94bb73d_0274eaa8 PS1, Line 945: if (content->ISL <= 139) Can there be Emmitsburg IFDs with less than 80 straps? I'd check for `content->ISL < 80` somewhere, either here or in a `warn_peculiar_desc()` call (which could also check `content->ISL != 80 && content->ISL != 139`) -- To view, visit https://review.coreboot.org/c/flashrom/+/57635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Gerrit-Change-Number: 57635 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 08:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Explicitly check for Ibex Peak ISL value
by Angel Pons (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57633 ) Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/57633/comment/ff3d5478_30c0a5c2 PS2, Line 936: if (content->ISL <= 16) : return CHIPSET_5_SERIES_IBEX_PEAK; How about: if (content->ISL <= 16) { warn_peculiar_desc(content->ISL != 16, "Ibex Peak"); return CHIPSET_5_SERIES_IBEX_PEAK; } -- To view, visit https://review.coreboot.org/c/flashrom/+/57633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52 Gerrit-Change-Number: 57633 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 08:28:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by David Hendricks (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, Christian Walter, Stefan Reinauer, David Hendricks, Deomid "rojer" Ryabkov, Tim Chu. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Patch Set 2: -Code-Review (1 comment) Patchset: PS2: Fixes are teed up, let's get these 3 patches in and move on. -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 06:05:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021