September 2021 - flashrom-gerrit

Change in flashrom[master]: tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE
by Anastasia Klimchuk (Code Review) 15 Sep '21

15 Sep '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57269 to look at the new patch set (#2). Change subject: tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE ...................................................................... tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE This patch adds NON_ZERO macro and not_null function into io_mock.h, so that they can be used anywhere in tests. Common usage for not_null is to indicate a valid pointer, where it doesn't matter what the pointer is, only matters it is not null. Common usage of NON_ZERO is to indicate a valid file descriptor, where it only matters the descriptor is non-zero integer. New features replace all usages of previous MOCK_HANDLE. This patch corrects return value from __wrap_ioctl to be successful by default. It used to be MOCK_HANDLE, but should be 0. Included in this patch because this is also a replacement of MOCK_HANDLE. BUG=b:181803212 TEST=builds and ninja test Change-Id: I5ad6ee4aa9091447c6c9108c92bf7f6e755fca48 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/init_shutdown.c A tests/io_mock.c M tests/io_mock.h M tests/meson.build M tests/tests.c 5 files changed, 40 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/57269/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/57269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ad6ee4aa9091447c6c9108c92bf7f6e755fca48 Gerrit-Change-Number: 57269 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by Stefan Reinauer (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Deomid "rojer" Ryabkov, Tim Chu. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > I'm more interested in fixing bugs than arguing. […] From an outside perspective without having skin in the game of this specific issue: Forking is not always bad. If there are two opposing trains of thought that can not be unified properly, or if there is a lack in will to make that happen, allowing everybody to move on and make their own version better for themselves and their customer base can even help to overcome differences in the long run (see egcs vs gcc a long time ago). Nico, you are unhappy with about everybody trying to work with you here, and you are offering to fork the project fairly frequently. It is unhealthy for you and everybody else involved in this project to keep the threat of breakup over everybody's head. I would encourage you to think about whether that is what you want and if so, I will gladly help you with resources (hosting, etc) to get your fork started and off the ground. I will also gladly pay for a domain for you for the first couple of years. We have all started out as friends in this project, and it is good to remember that in the end we share 95% of the same goals, even if we like to fight to the last breath over the remaining 5%. Let's not use those 5% disagreement as a reason to create an environment in which none of us wants to be. It's not worth anybody's life time. I am open to suggestions but this way of treating each other needs to stop. -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 20:49:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: David Hendricks Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by David Hendricks (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Deomid "rojer" Ryabkov, Tim Chu. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > > I stepped in here *on your behalf* to *agree* >with you< to get David to align > with you < and yo […] I'm more interested in fixing bugs than arguing. We should all strive to provide and accept meaningful and actionable feedback. The thing that saddens me about this thread is that it reminds me of why forking flashrom for ChromeOS was necessary ~12 years ago. It's taken us days just to get a few lines of code written. Back then the paralysis was a matter of the community lacking bandwidth. Now the community lacks bandwidth, and people who are trying to help are met with condescending and hostile remarks such as "Please just take a deep breath and read the code, sleep over it and read it again". Next time, try just pointing out the problem so it can be fixed and we can move on. I do hope we can avoid more forks. Thanks again to Edward for stepping in to lead here. -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 19:07:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: David Hendricks Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for Intel Emmitsburg PCH
by David Hendricks (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Edward O'Callaghan, Angel Pons. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57635 ) Change subject: Add support for Intel Emmitsburg PCH ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/57635/comment/64f1e986_0ffaa13d PS1, Line 16: TESTED=tried on a server with Intel Emmitsburg PCH, flash update : was successful. This server, however, does not have flash chip : installed, it instead has em100 emulator connected. > Recently the patch(es) were tested on 2 different servers with Intel Emmitsburg PCH, with flash chip […] Thanks, Jonathan. I'll also do a final test on the CRB before submitting in case any of the intermediate changes we've made caused problems. Commit Message: https://review.coreboot.org/c/flashrom/+/57635/comment/c9367ec0_c27ed768 PS2, Line 11: - Based on ICH descriptor content, choose This line break was bothering me, so I updated the comment to fit in the margins more cleanly. File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/57635/comment/b820830e_aceec00c PS1, Line 945: if (content->ISL <= 139) > Can there be Emmitsburg IFDs with less than 80 straps? I'd check for `content->ISL < 80` somewhere, […] AFAIK Eagle Stream is the only existing platform with the Emmitsburg PCH, and the BKC images I have for it show 80 straps. That's why I thought it was weird that we're using `<=` everywhere instead of `==`, although perhaps the person who originally wrote this code noticed some earlier chipsets did have overlapping ISL values, or they just didn't have access to enough docs/resources to know for sure. In any case, it's a pretty big range we're allowing to fall into this case so I think your suggestion is good and have added the peculiar descriptor warning. Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/57635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Gerrit-Change-Number: 57635 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 18:44:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Explicitly check for Ibex Peak ISL value
by David Hendricks (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Edward O'Callaghan, Angel Pons. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57633 ) Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > > The current patch also changes when the warning is printed (not anymore > > for ISL < 16) while the commit message states otherwise. > > Indeed, this is an issue. Yep, nice catch. Done. File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/57633/comment/132920cb_b5b8e7a1 PS2, Line 936: if (content->ISL <= 16) : return CHIPSET_5_SERIES_IBEX_PEAK; > Based on Nico's comment, looks like this should be placed after the `if (content->FLMAP2 == 0) { ... […] Thanks for deciphering that comment. Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/57633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52 Gerrit-Change-Number: 57633 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 18:42:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for Intel Emmitsburg PCH
by David Hendricks (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, David Hendricks, Edward O'Callaghan, Angel Pons. Hello Arthur Heymans, build bot (Jenkins), Nico Huber, Jonathan Zhang, Edward O'Callaghan, Angel Pons, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57635 to look at the new patch set (#3). Change subject: Add support for Intel Emmitsburg PCH ...................................................................... Add support for Intel Emmitsburg PCH This patch does the following: - Add PCIe ID for Intel Emmitsburg PCH - Add ICH descriptor check for CHIPSET_C620_SERIES_LEWISBURG. Although EBG only uses 80 for its PSL value, LBG on Purley and Whitley use 139. So to cover both cases the latter is used. TESTED=tried on different servers with Intel Emmitsburg PCH, flash update was successful. Some servers have flash chip installed, another one has em100 emulator connected. Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Signed-off-by: Jonathan Zhang <jonzhang(a)fb.com> Signed-off-by: David Hendricks <ddaveh(a)amazon.com> --- M chipset_enable.c M ich_descriptors.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/57635/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/57635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Gerrit-Change-Number: 57635 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ich_descriptors: Explicitly check for Ibex Peak ISL value
by David Hendricks (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons. Hello Arthur Heymans, build bot (Jenkins), Nico Huber, Jonathan Zhang, Edward O'Callaghan, Angel Pons, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/57633 to look at the new patch set (#3). Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value ...................................................................... ich_descriptors: Explicitly check for Ibex Peak ISL value This patch does the following: - Checks for Ibex Peak more explicitly, as ifdtool currently does. - Adds a comment about Ibex Peak being the default in case other chipsets are not identified, as we will soon add support for more chipsets with larger ISL/PSL values. Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52 Signed-off-by: David Hendricks <ddaveh(a)amazon.com> --- M ich_descriptors.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/57633/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/57633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52 Gerrit-Change-Number: 57633 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"
by David Hendricks (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Deomid "rojer" Ryabkov, Tim Chu. David Hendricks has uploaded a new patch set (#3) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/57589 ) Change subject: Revert "Add support for Intel Emmitsburg PCH" ...................................................................... Revert "Add support for Intel Emmitsburg PCH" This reverts commit 51e1d0e4b7670e5822560acc724a6a8dd00b6af4. Breaks Ibex Peak descriptor detection. Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M chipset_enable.c M ich_descriptors.c 2 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/57589/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/57589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a Gerrit-Change-Number: 57589 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Add support for Intel Emmitsburg PCH
by Jonathan Zhang (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, David Hendricks, Edward O'Callaghan, Angel Pons. Jonathan Zhang has uploaded a new patch set (#2) to the change originally created by David Hendricks. ( https://review.coreboot.org/c/flashrom/+/57635 ) Change subject: Add support for Intel Emmitsburg PCH ...................................................................... Add support for Intel Emmitsburg PCH This patch does the following: - Add PCIe ID for Intel Emmitsburg PCH - Based on ICH descriptor content, choose CHIPSET_C620_SERIES_LEWISBURG. Although EBG only uses 80 for its PSL value, LBG on Purley and Whitley use 139. So to cover both cases the latter is used. TESTED=tried on different servers with Intel Emmitsburg PCH, flash update was successful. Some servers have flash chip installed, another one has em100 emulator connected. Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Signed-off-by: Jonathan Zhang <jonzhang(a)fb.com> Signed-off-by: David Hendricks <ddaveh(a)amazon.com> --- M chipset_enable.c M ich_descriptors.c 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/57635/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/57635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Gerrit-Change-Number: 57635 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Add support for Intel Emmitsburg PCH
by Jonathan Zhang (Code Review) 14 Sep '21

14 Sep '21

Attention is currently required from: Arthur Heymans, Nico Huber, David Hendricks, Edward O'Callaghan, Angel Pons. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57635 ) Change subject: Add support for Intel Emmitsburg PCH ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/57635/comment/bc9daa56_d8b3ffe8 PS1, Line 16: TESTED=tried on a server with Intel Emmitsburg PCH, flash update : was successful. This server, however, does not have flash chip : installed, it instead has em100 emulator connected. > Was the current patch tested like this too? Recently the patch(es) were tested on 2 different servers with Intel Emmitsburg PCH, with flash chip. Let me update the commit message. -- To view, visit https://review.coreboot.org/c/flashrom/+/57635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451 Gerrit-Change-Number: 57635 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Sep 2021 15:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021