June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: enum programmer: replace by size_t
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55120 ) Change subject: enum programmer: replace by size_t ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: I would prefer `unsigned int` instead, but have no strong feelings about it. I've myself used `size_t` as index type in the past just because it's more convenient to type :) but technically, it's reserved for byte indices. (The whole story is inconsistent because our definition of ARRAY_SIZE() implies size_t. Maybe that's something that should change?) -- To view, visit https://review.coreboot.org/c/flashrom/+/55120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ad9630fbc41e98d182768b553788e069fa5095 Gerrit-Change-Number: 55120 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 12:25:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: replace enum programmer by struct programmer_entry*
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55119 ) Change subject: flashrom.c: replace enum programmer by struct programmer_entry* ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I478c56354d5f482010bfe1560489700bc889717a Gerrit-Change-Number: 55119 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 12:20:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: print.c use fixed fixed name instead of reference
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55118 ) Change subject: programmer_table: print.c use fixed fixed name instead of reference ...................................................................... Patch Set 3: (1 comment) File print.c: https://review.coreboot.org/c/flashrom/+/55118/comment/a8ec47f0_f7c28115 PS3, Line 478: programmer_table[PROGRAMMER_INTERNAL]->name How about `programmer_internal->name`? -- To view, visit https://review.coreboot.org/c/flashrom/+/55118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If2cf95c71425efdd864457e213dd34b929fe8805 Gerrit-Change-Number: 55118 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 12:01:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: replace PROGRAMMER_INVALID to programmer_table_size...
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55117 ) Change subject: programmer_table: replace PROGRAMMER_INVALID to programmer_table_size in itterations ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55117/comment/f84b3c55_554577c1 PS3, Line 7: programmer_table: replace PROGRAMMER_INVALID to programmer_table_size in itterations It's just too long, how about programmer_table: Use `programmer_table_size` everywhere -- To view, visit https://review.coreboot.org/c/flashrom/+/55117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icaaeefe001de604df9d7fdd06f05a5ed39fdbd84 Gerrit-Change-Number: 55117 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 12:00:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: move each entry to the associated programmer source
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52946 ) Change subject: programmer_table: move each entry to the associated programmer source ...................................................................... Patch Set 4: Code-Review+1 (26 comments) File atahpt.c: https://review.coreboot.org/c/flashrom/+/52946/comment/d6f7ea79_32831634 PS4, Line 34: const struct dev_entry ata_hpt[] = { Can be `static` now? File atapromise.c: https://review.coreboot.org/c/flashrom/+/52946/comment/bb1d2749_58cc47d7 PS4, Line 49: const struct dev_entry ata_promise[] = { Can be `static` now? File atavia.c: https://review.coreboot.org/c/flashrom/+/52946/comment/5f0558a6_9d2849df PS4, Line 51: const struct dev_entry ata_via[] = { Can be `static` now? File ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/37ca1623_225334f6 PS4, Line 87: const struct dev_entry devs_ch341a_spi[] = { Can be `static` now? File dediprog.c: https://review.coreboot.org/c/flashrom/+/52946/comment/00a2fdb4_edaa8c12 PS4, Line 155: const struct dev_entry devs_dediprog[] = { Can be `static` now? File developerbox_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/c59f802b_ad5e85e9 PS4, Line 58: const struct dev_entry devs_developerbox_spi[] = { Can be `static` now? File digilent_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/2babdd33_32295324 PS4, Line 56: const struct dev_entry devs_digilent_spi[] = { Can be `static` now? File drkaiser.c: https://review.coreboot.org/c/flashrom/+/52946/comment/d56d5a19_a2852063 PS4, Line 32: const struct dev_entry drkaiser_pcidev[] = { Can be `static` now? File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/156855a3_36b65c7a PS4, Line 62: const struct dev_entry devs_ft2232spi[] = { Can be `static` now? File gfxnvidia.c: https://review.coreboot.org/c/flashrom/+/52946/comment/9c8f720e_7a4d2a0b PS4, Line 33: const struct dev_entry gfx_nvidia[] = { Can be `static` now? File it8212.c: https://review.coreboot.org/c/flashrom/+/52946/comment/05c371a9_9f55677a PS4, Line 26: const struct dev_entry devs_it8212[] = { Can be `static` now? File nic3com.c: https://review.coreboot.org/c/flashrom/+/52946/comment/9068e9e1_ad8fdf32 PS4, Line 36: const struct dev_entry nics_3com[] = { Can be `static` now? File nicintel.c: https://review.coreboot.org/c/flashrom/+/52946/comment/465b7b51_fd24431a PS4, Line 26: const struct dev_entry nics_intel[] = { Can be `static` now? File nicintel_eeprom.c: https://review.coreboot.org/c/flashrom/+/52946/comment/1b7903a6_9588c4e0 PS4, Line 84: const struct dev_entry nics_intel_ee[] = { Can be `static` now? File nicintel_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/fa51cd7a_fff83e4c PS4, Line 80: const struct dev_entry nics_intel_spi[] = { Can be `static` now? File nicnatsemi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/592e1ec1_a9879ee7 PS4, Line 30: const struct dev_entry nics_natsemi[] = { Can be `static` now? File nicrealtek.c: https://review.coreboot.org/c/flashrom/+/52946/comment/7bd6b984_8d116277 PS4, Line 30: const struct dev_entry nics_realtek[] = { Can be `static` now? https://review.coreboot.org/c/flashrom/+/52946/comment/03f5c6bd_091a3791 PS4, Line 131: /* This programmer works for Realtek RTL8139 and SMC 1211. */ This comment seems very lost here. Maybe just drop it? File ogp_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/ca3e09ab_a6f5a14d PS4, Line 46: const struct dev_entry ogp_spi[] = { Can be `static` now? File pickit2_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/13991d1b_6ecb65ff PS4, Line 49: const struct dev_entry devs_pickit2_spi[] = { Can be `static` now? File programmer.h: https://review.coreboot.org/c/flashrom/+/52946/comment/64db74ed_e03d25f1 PS4, Line 402: #if CONFIG_DUMMY == 1 Please just drop all these `#if`. The only difference it makes is whether we get a compile-time or link-time error if something goes wrong. I don't think it matters or even justifies the clutter. Mentioning the file name is also a bit redundant. Maybe just a single comment /* programmer drivers */ ? Doesn't have to be in this patch, though. File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/103fcce1_5d18901a PS4, Line 352: const struct dev_entry devs_raiden[] = { Can be `static` now? File satamv.c: https://review.coreboot.org/c/flashrom/+/52946/comment/558da6af_b134c41a PS4, Line 28: const struct dev_entry satas_mv[] = { Can be `static` now? File satasii.c: https://review.coreboot.org/c/flashrom/+/52946/comment/0acd332d_9c74467e PS4, Line 29: const struct dev_entry satas_sii[] = { Can be `static` now? File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/6f6bc7d5_44921ad0 PS4, Line 117: const struct dev_entry devs_stlinkv3_spi[] = { Can be `static` now? File usbblaster_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/15b024ad_26cfc46e PS4, Line 48: const struct dev_entry devs_usbblasterspi[] = { Can be `static` now? -- To view, visit https://review.coreboot.org/c/flashrom/+/52946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921 Gerrit-Change-Number: 52946 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 11:34:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: convert entries to pointers
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52945 ) Change subject: programmer_table: convert entries to pointers ...................................................................... Patch Set 3: Code-Review+1 (9 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/52945/comment/cd179915_e7594cab PS3, Line 8: Please mention: Allows us to move the individual entries into their respective driver files. File flashrom.c: https://review.coreboot.org/c/flashrom/+/52945/comment/bd93d257_4500c665 PS3, Line 1721: const struct programmer_entry *p = programmer_table[i]; Please add a check `if (p == NULL)` right here. https://review.coreboot.org/c/flashrom/+/52945/comment/c5bf717f_10cd2e44 PS3, Line 1721: *p Nit, could be `*const p`. File print.c: https://review.coreboot.org/c/flashrom/+/52945/comment/bb9443b3_4f575908 PS3, Line 428: *prog Nit, this could be `*const prog`. https://review.coreboot.org/c/flashrom/+/52945/comment/f30ebdd5_0d9bb2c7 PS3, Line 486: *prog *const prog File print_wiki.c: https://review.coreboot.org/c/flashrom/+/52945/comment/66cbbfd8_9da968d1 PS3, Line 358: *prog *const prog https://review.coreboot.org/c/flashrom/+/52945/comment/cb58b6a8_fae71833 PS3, Line 384: *prog ditto... and below File programmer.h: https://review.coreboot.org/c/flashrom/+/52945/comment/43ac4818_64252cdf PS3, Line 178: *programmer_table The pointers should be const, nobody should be allowed to change them at runtime, right? *const programmer_table File programmer_table.c: https://review.coreboot.org/c/flashrom/+/52945/comment/252a9ae9_bb45d4ef PS3, Line 477: *programmer_table *const programmer_table -- To view, visit https://review.coreboot.org/c/flashrom/+/52945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifbb0ee4db5a85b1cd2afeafe4dca838579f79878 Gerrit-Change-Number: 52945 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 10:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: move array content to an own file
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52944 ) Change subject: programmer_table: move array content to an own file ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File programmer_table.c: PS3: New files need a license header. Just copy the one from `flashrom.c`, but don't transfer the copyright lines, they are unlikely to apply. -- To view, visit https://review.coreboot.org/c/flashrom/+/52944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8e6d704e845ee4152c8676dd19dff0934fff007b Gerrit-Change-Number: 52944 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 09:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: add table size variable
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55116 ) Change subject: programmer_table: add table size variable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idacb4b7b0dd98af8bc7cbecf567d33daafb4b24d Gerrit-Change-Number: 55116 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 09:33:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: add table size variable
by Nico Huber (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55116 ) Change subject: programmer_table: add table size variable ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/55116/comment/3483f9fa_0e3e3c59 PS2, Line 7: variable Nit, `variable` might raise some eyebrows, `constant` would be better and more accurate. https://review.coreboot.org/c/flashrom/+/55116/comment/57085ee8_c28c43a2 PS2, Line 8: Maybe just one sentence about the intention: Makes the array size known to other compilation units. -- To view, visit https://review.coreboot.org/c/flashrom/+/55116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idacb4b7b0dd98af8bc7cbecf567d33daafb4b24d Gerrit-Change-Number: 55116 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 09:33:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: remove null termination
by Thomas Heijligen (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Xiang W, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55115 ) Change subject: programmer_table: remove null termination ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/55115/comment/8018015d_e824d05c PS1, Line 7: NULL > lower case `null`, it's not a NULL pointer. Done https://review.coreboot.org/c/flashrom/+/55115/comment/20f8ed3a_e5145fe8 PS1, Line 9: Object > lower case `object` Done https://review.coreboot.org/c/flashrom/+/55115/comment/92efd3f0_a2bb4c50 PS1, Line 9: correspond > missing singular s: corresponds Done https://review.coreboot.org/c/flashrom/+/55115/comment/c0769707_0b1dfa24 PS1, Line 10: to PROGRAMMER_INVALID has no use in currend code > last but not least, missing full stop Done https://review.coreboot.org/c/flashrom/+/55115/comment/d2b734ec_5d2223b7 PS1, Line 10: currend > current with t Done -- To view, visit https://review.coreboot.org/c/flashrom/+/55115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib63c2d2941f23a0788e26e5a5feb25d8669acb42 Gerrit-Change-Number: 55115 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Jun 2021 22:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021