June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: programmer_table: move each entry to the associated programmer source
by Thomas Heijligen (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52946 to look at the new patch set (#4). Change subject: programmer_table: move each entry to the associated programmer source ...................................................................... programmer_table: move each entry to the associated programmer source Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M ch341a_spi.c M dediprog.c M developerbox_spi.c M digilent_spi.c M drkaiser.c M dummyflasher.c M ene_lpc.c M ft2232_spi.c M gfxnvidia.c M internal.c M it8212.c M jlink_spi.c M linux_mtd.c M linux_spi.c M lspcon_i2c_spi.c M mec1308.c M mstarddc_spi.c M ni845x_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M pickit2_spi.c M pony_spi.c M programmer.h M programmer_table.c M raiden_debug_spi.c M rayer_spi.c M realtek_mst_i2c_spi.c M satamv.c M satasii.c M serprog.c M stlinkv3_spi.c M usbblaster_spi.c 41 files changed, 483 insertions(+), 593 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/52946/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/52946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921 Gerrit-Change-Number: 52946 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer_table: move array content to an own file
by Thomas Heijligen (Code Review) 05 Jun '21

05 Jun '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52944 to look at the new patch set (#3). Change subject: programmer_table: move array content to an own file ...................................................................... programmer_table: move array content to an own file Change-Id: I8e6d704e845ee4152c8676dd19dff0934fff007b Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M flashrom.c M meson.build A programmer_table.c 4 files changed, 482 insertions(+), 479 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/52944/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/52944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8e6d704e845ee4152c8676dd19dff0934fff007b Gerrit-Change-Number: 52944 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer_table: remove null termination
by Thomas Heijligen (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Xiang W, Thomas Heijligen, Angel Pons. Hello build bot (Jenkins), Nico Huber, Xiang W, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55115 to look at the new patch set (#2). Change subject: programmer_table: remove null termination ...................................................................... programmer_table: remove null termination The {0} object at the end of programmer_table which corresponds to PROGRAMMER_INVALID has no use in current code. Change-Id: Ib63c2d2941f23a0788e26e5a5feb25d8669acb42 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M flashrom.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/55115/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib63c2d2941f23a0788e26e5a5feb25d8669acb42 Gerrit-Change-Number: 55115 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer_table: remove NULL termination
by Nico Huber (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Xiang W, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55115 ) Change subject: programmer_table: remove NULL termination ...................................................................... Patch Set 1: Code-Review+2 (6 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/55115/comment/3f2975e8_27e58026 PS1, Line 7: NULL lower case `null`, it's not a NULL pointer. https://review.coreboot.org/c/flashrom/+/55115/comment/e2f0d45a_0a0b3fa0 PS1, Line 9: Object lower case `object` https://review.coreboot.org/c/flashrom/+/55115/comment/ec19f1dd_ad1c41c6 PS1, Line 9: correspond missing singular s: corresponds https://review.coreboot.org/c/flashrom/+/55115/comment/ff5cffeb_f7224aab PS1, Line 10: to PROGRAMMER_INVALID has no use in currend code last but not least, missing full stop https://review.coreboot.org/c/flashrom/+/55115/comment/1c491a59_f89f475d PS1, Line 10: currend current with t Patchset: PS1: Not easy to prove, but I've looked through `git grep -24 programmer_table`: For most references the index is explicitly guarded. In some cases the global `programmer` index is used. However, these would dereference actual NULL pointers inside the programmer struct if `programmer == PROGRAMMER_INVALID`. So no trouble there. -- To view, visit https://review.coreboot.org/c/flashrom/+/55115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib63c2d2941f23a0788e26e5a5feb25d8669acb42 Gerrit-Change-Number: 55115 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Jun 2021 20:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: remove NULL termination
by Thomas Heijligen (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Nico Huber, Xiang W, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55115 ) Change subject: programmer_table: remove NULL termination ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > in libflashrom.c used {0} object. It is need remove in this patch. > > > int flashrom_programmer_init(struct flashrom_programmer **const flashprog, > > const char *const prog_name, const char *const prog_param) > > { > > unsigned prog; > > > > for (prog = 0; prog < PROGRAMMER_INVALID; prog++) { > > if (strcmp(prog_name, programmer_table[prog].name) == 0) > > break; > > } > > if (prog >= PROGRAMMER_INVALID) { > > msg_ginfo("Error: Unknown programmer \"%s\". Valid choices are:\n", prog_name); > > list_programmers_linebreak(0, 80, 0); > > return 1; > > } > > return programmer_init(prog, prog_param); > > } The patch removes programmer_table[PROGRAMMER_INVALID] = {0}. So programmer_table[PROGRAMMER_INVALID] is now UNDEFINED. The flashrom_programmer_init() function will never access programmer_table[PROGRAMMER_INVALID]. -- To view, visit https://review.coreboot.org/c/flashrom/+/55115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib63c2d2941f23a0788e26e5a5feb25d8669acb42 Gerrit-Change-Number: 55115 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Jun 2021 18:42:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Xiang W <wxjstz(a)126.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nicrealtek.c: Refactor singleton states into reentrant pattern
by Nico Huber (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55108 ) Change subject: nicrealtek.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/55108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If0cb0fefb53b2c6bb65a85f4c8dc6f323954dd0c Gerrit-Change-Number: 55108 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 16:59:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern
by Nico Huber (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55107 ) Change subject: nic3com.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: Looks like a duplicate of CB:55106? -- To view, visit https://review.coreboot.org/c/flashrom/+/55107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9834b82650cd070556cf82207796bc6bd6b31b28 Gerrit-Change-Number: 55107 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 16:50:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern
by Nico Huber (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55106 ) Change subject: nic3com.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 1: (2 comments) File nic3com.c: https://review.coreboot.org/c/flashrom/+/55106/comment/d74a640c_32cfbd83 PS1, Line 144: msg_perr("Unable to allocate space for PAR master data\n"); Shouldn't we do what nic3com_shutdown() does, here? (or call it with a locally declared struct nic3com_data instead of the three individual variables) https://review.coreboot.org/c/flashrom/+/55106/comment/c65ac3f6_44464d8e PS1, Line 152: free(data); Same here? (although this path was already wrong before) -- To view, visit https://review.coreboot.org/c/flashrom/+/55106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1c3e4836760cc9f4f9a0bd4294e8d2407b150566 Gerrit-Change-Number: 55106 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 16:49:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add AmigaOS suppport to flashrom
by Nico Huber (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Stefan Reinauer, Paul Menzel, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54943 ) Change subject: Add AmigaOS suppport to flashrom ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/54943/comment/94e8d71f_fb3d73c1 PS1, Line 8: > How would I do this? Create a Dockerfile.amiga that contains a crosscompile environment? If there is no way to compile it natively, exactly that. I was lazy with the DJGPP Dockerfile and just used a published image. Maybe there is one for AmigaOS too? If you want to write one, I suggest to base it on a particular Debian release, so we can get the same results for a few years (the idea of Manibuilder includes local builds of all Docker images so developers can investigate on their own without server access). Beside the tool- chain a user `mani` and a checkout of flashrom in `/home/mani/flashrom` is expected. And it needs the `mani-wrapper.sh`. I guess you could copy all that from the DJGPP setup. Cross-compilation is a bit ugly in the manibuilder/Makefile, but there DJGPP should serve as example too :) -- To view, visit https://review.coreboot.org/c/flashrom/+/54943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3e4a3885f88313aad019454fdbdf4be176b35330 Gerrit-Change-Number: 54943 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Jun 2021 12:50:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: platform: Fix endianness detection for Apple Silicon Macs
by Ivan V (Code Review) 05 Jun '21

05 Jun '21

Ivan V has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54964 ) Change subject: platform: Fix endianness detection for Apple Silicon Macs ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/54964/comment/7de13465_b1643227 PS1, Line 18: 3. __LITTLE_ENDIAN__ and __BIG_ENDIAN__ macros are used only : for PowerPC architecture. > This has confused me a little because it describes the flashrom […] Yes, you're right. I could've worded it better. -- To view, visit https://review.coreboot.org/c/flashrom/+/54964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifdb1523ee2c7023e657cfd7b823b091d5deef513 Gerrit-Change-Number: 54964 Gerrit-PatchSet: 2 Gerrit-Owner: Ivan V <root(a)pcm720.me> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 12:46:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021