June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: dummyflasher.c: Fix data leak in params processing error paths
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 ) Change subject: dummyflasher.c: Fix data leak in params processing error paths ...................................................................... Patch Set 5: (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54748/comment/4cb463a8_d258182b PS1, Line 26: /* Remove the #define below if you don't want SPI flash chip emulation. */ : #define EMULATE_SPI_CHIP 1 > Just to confirm, you mean, let's assume (EMULATE_CHIP && EMULATE_SPI_CHIP) always true and drop the […] I made CB:55265 to address this. -- To view, visit https://review.coreboot.org/c/flashrom/+/54748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87 Gerrit-Change-Number: 54748 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 10:48:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Fix data leak in params processing error paths
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 ) Change subject: dummyflasher.c: Fix data leak in params processing error paths ...................................................................... Patch Set 5: (2 comments) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54748/comment/efa7b547_a250d37c PS5, Line 653: #if EMULATE_SPI_CHIP > Hold on, let me kill these macros first... CB:55265 https://review.coreboot.org/c/flashrom/+/54748/comment/52a7b8f8_61128926 PS5, Line 982: sizeof(struct emu_data) > sizeof(*data) CB:55266 -- To view, visit https://review.coreboot.org/c/flashrom/+/54748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87 Gerrit-Change-Number: 54748 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 10:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: treewide: Drop most cases of `sizeof(struct ...)`
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55266 ) Change subject: treewide: Drop most cases of `sizeof(struct ...)` ...................................................................... treewide: Drop most cases of `sizeof(struct ...)` Spelling out the struct type name hurts readability and introduces opportunities for bugs to happen when the pointer variable type is changed but the corresponding sizeof is (are) not. TEST=`make CONFIG_EVERYTHING=yes CONFIG_JLINK_SPI=no VERSION=none -j` with and without this patch; the flashrom executable does not change. Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M bitbang_spi.c M dummyflasher.c M flashrom.c M fmap.c M hwaccess.c M ichspi.c M it85spi.c M it87spi.c M layout.c M libflashrom.c M lspcon_i2c_spi.c M pcidev.c M physmap.c M raiden_debug_spi.c M realtek_mst_i2c_spi.c M sb600spi.c M sfdp.c M usb_device.c M wbsio_spi.c 19 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/55266/1 diff --git a/bitbang_spi.c b/bitbang_spi.c index e941910..3d973c5 100644 --- a/bitbang_spi.c +++ b/bitbang_spi.c @@ -162,7 +162,7 @@ return ERROR_FLASHROM_BUG; } - struct bitbang_spi_master_data *data = calloc(1, sizeof(struct bitbang_spi_master_data)); + struct bitbang_spi_master_data *data = calloc(1, sizeof(*data)); data->master = master; if (spi_data) data->spi_data = spi_data; diff --git a/dummyflasher.c b/dummyflasher.c index 123abaa..0c86ba3 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -633,7 +633,7 @@ struct stat image_stat; char *endptr; - struct emu_data *data = calloc(1, sizeof(struct emu_data)); + struct emu_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Out of memory!\n"); return 1; diff --git a/flashrom.c b/flashrom.c index 0af5057..fcaa3ef 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1234,12 +1234,12 @@ } /* Start filling in the dynamic data. */ - flash->chip = calloc(1, sizeof(struct flashchip)); + flash->chip = calloc(1, sizeof(*flash->chip)); if (!flash->chip) { msg_gerr("Out of memory!\n"); exit(1); } - memcpy(flash->chip, chip, sizeof(struct flashchip)); + memcpy(flash->chip, chip, sizeof(*flash->chip)); flash->mst = mst; if (map_flash(flash) != 0) diff --git a/fmap.c b/fmap.c index 2f34a5c..b18cbf7 100644 --- a/fmap.c +++ b/fmap.c @@ -195,7 +195,7 @@ if (prepare_flash_access(flashctx, true, false, false, false)) return 1; - fmap = malloc(sizeof(struct fmap)); + fmap = malloc(sizeof(*fmap)); if (!fmap) { msg_gerr("Out of memory.\n"); goto _free_ret; diff --git a/hwaccess.c b/hwaccess.c index 48ccb34..3a9ca57 100644 --- a/hwaccess.c +++ b/hwaccess.c @@ -247,7 +247,7 @@ #define register_undo_mmio_write(a, c) \ { \ struct undo_mmio_write_data *undo_mmio_write_data; \ - undo_mmio_write_data = malloc(sizeof(struct undo_mmio_write_data)); \ + undo_mmio_write_data = malloc(sizeof(*undo_mmio_write_data)); \ if (!undo_mmio_write_data) { \ msg_gerr("Out of memory!\n"); \ exit(1); \ diff --git a/ichspi.c b/ichspi.c index 80fcff5..20dac1b 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1731,7 +1731,7 @@ ich_generation = ich_gen; ich_spibar = spibar; - memset(&desc, 0x00, sizeof(struct ich_descriptors)); + memset(&desc, 0x00, sizeof(desc)); /* Moving registers / bits */ switch (ich_gen) { diff --git a/it85spi.c b/it85spi.c index 810f062..9812fc7 100644 --- a/it85spi.c +++ b/it85spi.c @@ -341,7 +341,7 @@ (unsigned int)base); #endif - data = calloc(1, sizeof(struct it85spi_data)); + data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for extra SPI master data.\n"); return SPI_GENERIC_ERROR; diff --git a/it87spi.c b/it87spi.c index 92c95fa..cbf830b 100644 --- a/it87spi.c +++ b/it87spi.c @@ -411,7 +411,7 @@ free(param); exit_conf_mode_ite(port); - struct it8716f_spi_data *data = calloc(1, sizeof(struct it8716f_spi_data)); + struct it8716f_spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for extra SPI master data.\n"); return SPI_GENERIC_ERROR; diff --git a/layout.c b/layout.c index 4d1dd56..cd6b458 100644 --- a/layout.c +++ b/layout.c @@ -135,7 +135,7 @@ } } - tmp = malloc(sizeof(struct layout_include_args)); + tmp = malloc(sizeof(*tmp)); if (tmp == NULL) { msg_gerr("Could not allocate memory"); goto error; diff --git a/libflashrom.c b/libflashrom.c index 23358c9..ef0b417 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -182,7 +182,7 @@ ++boards_known_size; struct flashrom_board_info *supported_boards = - malloc(boards_known_size * sizeof(struct flashrom_board_info)); + malloc(boards_known_size * sizeof(*supported_boards)); if (supported_boards != NULL) { for (; i < boards_known_size; ++i) { diff --git a/lspcon_i2c_spi.c b/lspcon_i2c_spi.c index 7f5e3ef..9a66b31 100644 --- a/lspcon_i2c_spi.c +++ b/lspcon_i2c_spi.c @@ -446,7 +446,7 @@ return ret; } - struct lspcon_i2c_spi_data *data = calloc(1, sizeof(struct lspcon_i2c_spi_data)); + struct lspcon_i2c_spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for extra SPI master data.\n"); i2c_close(fd); diff --git a/pcidev.c b/pcidev.c index 892f7b1..9ffe05c 100644 --- a/pcidev.c +++ b/pcidev.c @@ -296,7 +296,7 @@ #define register_undo_pci_write(a, b, c) \ { \ struct undo_pci_write_data *undo_pci_write_data; \ - undo_pci_write_data = malloc(sizeof(struct undo_pci_write_data)); \ + undo_pci_write_data = malloc(sizeof(*undo_pci_write_data)); \ if (!undo_pci_write_data) { \ msg_gerr("Out of memory!\n"); \ exit(1); \ diff --git a/physmap.c b/physmap.c index 72d5899..6c36814 100644 --- a/physmap.c +++ b/physmap.c @@ -292,7 +292,7 @@ } if (autocleanup) { - struct undo_physmap_data *d = malloc(sizeof(struct undo_physmap_data)); + struct undo_physmap_data *d = malloc(sizeof(*d)); if (d == NULL) { msg_perr("%s: Out of memory!\n", __func__); physunmap_unaligned(virt_addr, len); diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index f67bbe5..950b8af 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -1579,19 +1579,19 @@ (request_enable == RAIDEN_DEBUG_SPI_REQ_ENABLE_EC)) usleep(50 * 1000); - struct spi_master *spi_config = calloc(1, sizeof(struct spi_master)); + struct spi_master *spi_config = calloc(1, sizeof(*spi_config)); if (!spi_config) { msg_perr("Unable to allocate space for SPI master.\n"); return SPI_GENERIC_ERROR; } - struct raiden_debug_spi_data *data = calloc(1, sizeof(struct raiden_debug_spi_data)); + struct raiden_debug_spi_data *data = calloc(1, sizeof(*data)); if (!data) { free(spi_config); msg_perr("Unable to allocate space for extra SPI master data.\n"); return SPI_GENERIC_ERROR; } - memcpy(spi_config, &spi_master_raiden_debug, sizeof(struct spi_master)); + memcpy(spi_config, &spi_master_raiden_debug, sizeof(*spi_config)); data->dev = device; data->in_ep = in_endpoint; diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index 95c017f..91c8aa5 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -504,7 +504,7 @@ return ret; } - struct realtek_mst_i2c_spi_data *data = calloc(1, sizeof(struct realtek_mst_i2c_spi_data)); + struct realtek_mst_i2c_spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for extra SPI master data.\n"); return SPI_GENERIC_ERROR; diff --git a/sb600spi.c b/sb600spi.c index c057947..c4b25e5 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -777,7 +777,7 @@ if (handle_imc(dev, amd_gen) != 0) return ERROR_FATAL; - struct sb600spi_data *data = calloc(1, sizeof(struct sb600spi_data)); + struct sb600spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for extra SPI master data.\n"); return SPI_GENERIC_ERROR; diff --git a/sfdp.c b/sfdp.c index 97f5620..530588f 100644 --- a/sfdp.c +++ b/sfdp.c @@ -300,7 +300,7 @@ /* Fetch all parameter headers, even if we don't use them all (yet). */ hbuf = malloc((nph + 1) * 8); - hdrs = malloc((nph + 1) * sizeof(struct sfdp_tbl_hdr)); + hdrs = malloc((nph + 1) * sizeof(*hdrs)); if (hbuf == NULL || hdrs == NULL ) { msg_gerr("Out of memory!\n"); goto cleanup_hdrs; diff --git a/usb_device.c b/usb_device.c index 5a468dd..a4f6d12 100644 --- a/usb_device.c +++ b/usb_device.c @@ -99,7 +99,7 @@ static void add_device(struct usb_device *device, struct usb_device **devices) { - struct usb_device *copy = malloc(sizeof(struct usb_device)); + struct usb_device *copy = malloc(sizeof(*copy)); assert(copy != NULL); diff --git a/wbsio_spi.c b/wbsio_spi.c index d17d49d..c3814aa 100644 --- a/wbsio_spi.c +++ b/wbsio_spi.c @@ -207,7 +207,7 @@ "1024 kB!\n", __func__); max_rom_decode.spi = 1024 * 1024; - struct wbsio_spi_data * data = calloc(1, sizeof(struct wbsio_spi_data)); + struct wbsio_spi_data *data = calloc(1, sizeof(*data)); if (!data) { msg_perr("Unable to allocate space for extra SPI master data.\n"); return SPI_GENERIC_ERROR; -- To view, visit https://review.coreboot.org/c/flashrom/+/55266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6 Gerrit-Change-Number: 55266 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: dummyflasher.c: Drop useless macros
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55265 ) Change subject: dummyflasher.c: Drop useless macros ...................................................................... dummyflasher.c: Drop useless macros The `EMULATE_CHIP` and `EMULATE_SPI_CHIP` macros are unconditionally defined as `1`, with no way to change their values. Since this means that the code never gets build-tested using other values, drop these noisy macros. TEST=Build with `make distclean && make VERSION=none -j` with and without this patch, the flashrom executable does not change. Change-Id: If46e1c37c3b04b28b4ba1f82c9b3def1e549368f Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M dummyflasher.c 1 file changed, 0 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/55265/1 diff --git a/dummyflasher.c b/dummyflasher.c index dcf97b5..123abaa 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -22,21 +22,11 @@ #include "chipdrivers.h" #include "programmer.h" #include "flashchips.h" - -/* Remove the #define below if you don't want SPI flash chip emulation. */ -#define EMULATE_SPI_CHIP 1 - -#if EMULATE_SPI_CHIP -#define EMULATE_CHIP 1 #include "spi.h" -#endif -#if EMULATE_CHIP #include <sys/types.h> #include <sys/stat.h> -#endif -#if EMULATE_CHIP enum emu_chip { EMULATE_NONE, EMULATE_ST_M25P10_RES, @@ -73,7 +63,6 @@ uint8_t *flashchip_contents; }; -#if EMULATE_SPI_CHIP /* A legit complete SFDP table based on the MX25L6436E (rev. 1.8) datasheet. */ static const uint8_t sfdp_table[] = { 0x53, 0x46, 0x44, 0x50, // @0x00: SFDP signature @@ -100,9 +89,6 @@ 0xFF, 0xFF, 0xFF, 0xFF, // @0x54: Macronix parameter table end }; -#endif -#endif - void *dummy_map(const char *descr, uintptr_t phys_addr, size_t len) { msg_pspew("%s: Mapping %s, 0x%zx bytes at 0x%0*" PRIxPTR "\n", @@ -173,7 +159,6 @@ return; } -#if EMULATE_SPI_CHIP static int emulate_spi_chip_response(unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, @@ -550,7 +535,6 @@ data->emu_status &= ~SPI_SR_WEL; return 0; } -#endif static int dummy_spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, @@ -572,7 +556,6 @@ /* Response for unknown commands and missing chip is 0xff. */ memset(readarr, 0xff, readcnt); -#if EMULATE_SPI_CHIP switch (emu_data->emu_chip) { case EMULATE_ST_M25P10_RES: case EMULATE_SST_SST25VF040_REMS: @@ -589,7 +572,6 @@ default: break; } -#endif msg_pspew(" reading %u bytes:", readcnt); for (i = 0; i < readcnt; i++) msg_pspew(" 0x%02x", readarr[i]); @@ -626,7 +608,6 @@ static int dummy_shutdown(void *data) { msg_pspew("%s\n", __func__); -#if EMULATE_CHIP struct emu_data *emu_data = (struct emu_data *)data; if (emu_data->emu_chip != EMULATE_NONE) { if (emu_data->emu_persistent_image && emu_data->emu_modified) { @@ -638,7 +619,6 @@ free(emu_data->emu_persistent_image); free(emu_data->flashchip_contents); } -#endif free(data); return 0; } @@ -648,13 +628,9 @@ char *bustext = NULL; char *tmp = NULL; unsigned int i; -#if EMULATE_SPI_CHIP char *status = NULL; int size = -1; /* size for VARIABLE_SIZE chip device */ -#endif -#if EMULATE_CHIP struct stat image_stat; -#endif char *endptr; struct emu_data *data = calloc(1, sizeof(struct emu_data)); @@ -825,8 +801,6 @@ } free(tmp); -#if EMULATE_CHIP -#if EMULATE_SPI_CHIP tmp = extract_programmer_param("size"); if (tmp) { size = strtol(tmp, NULL, 10); @@ -838,7 +812,6 @@ } free(tmp); } -#endif tmp = extract_programmer_param("emulate"); if (!tmp) { @@ -846,7 +819,6 @@ /* Nothing else to do. */ goto dummy_init_out; } -#if EMULATE_SPI_CHIP if (!strcmp(tmp, "M25P10.RES")) { data->emu_chip = EMULATE_ST_M25P10_RES; data->emu_chip_size = 128 * 1024; @@ -933,7 +905,6 @@ msg_pdbg("Emulating generic SPI flash chip (size=%d bytes)\n", data->emu_chip_size); } -#endif if (data->emu_chip == EMULATE_NONE) { msg_perr("Invalid chip specified for emulation: %s\n", tmp); free(tmp); @@ -957,7 +928,6 @@ } free(tmp); -#ifdef EMULATE_SPI_CHIP status = extract_programmer_param("spi_status"); if (status) { errno = 0; @@ -972,7 +942,6 @@ msg_pdbg("Initial status register is set to 0x%02x.\n", data->emu_status); } -#endif data->flashchip_contents = malloc(data->emu_chip_size); if (!data->flashchip_contents) { @@ -1009,7 +978,6 @@ msg_pdbg("doesn't match.\n"); } } -#endif dummy_init_out: if (register_shutdown(dummy_shutdown, data)) { @@ -1028,7 +996,6 @@ return 0; } -#if EMULATE_CHIP && EMULATE_SPI_CHIP int probe_variable_size(struct flashctx *flash) { unsigned int i; @@ -1071,4 +1038,3 @@ return 1; } -#endif -- To view, visit https://review.coreboot.org/c/flashrom/+/55265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If46e1c37c3b04b28b4ba1f82c9b3def1e549368f Gerrit-Change-Number: 55265 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: dummyflasher.c: Fix data leak in params processing error paths
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 ) Change subject: dummyflasher.c: Fix data leak in params processing error paths ...................................................................... Patch Set 5: (2 comments) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54748/comment/ee8c64f0_e9094d11 PS5, Line 653: #if EMULATE_SPI_CHIP Hold on, let me kill these macros first... https://review.coreboot.org/c/flashrom/+/54748/comment/b769cdc7_5fe5a79f PS5, Line 982: sizeof(struct emu_data) sizeof(*data) -- To view, visit https://review.coreboot.org/c/flashrom/+/54748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87 Gerrit-Change-Number: 54748 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 10:07:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern
by Edward O'Callaghan (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55107 ) Change subject: nic3com.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55107/comment/09fd03b4_ccb98776 PS2, Line 16: BUG=b:185191942 : TEST=builds : : Change-Id: I1c3e4836760cc9f4f9a0bd4294e8d2407b150566 : Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> > this hunk shouldn't be here as it is from the previous patch. Just as an aside we normally squash down the series not up. i.e., HEAD,X,Y would have Y squash into X to become the series HEAD,X*. Hopefully that makes sense. Gerrit tracks the Change-Id not the hash. -- To view, visit https://review.coreboot.org/c/flashrom/+/55107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9834b82650cd070556cf82207796bc6bd6b31b28 Gerrit-Change-Number: 55107 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 06:25:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern
by Edward O'Callaghan (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55107 ) Change subject: nic3com.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55107/comment/adc86dbc_1d368829 PS2, Line 16: BUG=b:185191942 : TEST=builds : : Change-Id: I1c3e4836760cc9f4f9a0bd4294e8d2407b150566 : Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> this hunk shouldn't be here as it is from the previous patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/55107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9834b82650cd070556cf82207796bc6bd6b31b28 Gerrit-Change-Number: 55107 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 06:06:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern
by Anastasia Klimchuk (Code Review) 07 Jun '21

07 Jun '21

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55106 ) Change subject: nic3com.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I will resolve open comments from here in CB:55107 -- To view, visit https://review.coreboot.org/c/flashrom/+/55106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1c3e4836760cc9f4f9a0bd4294e8d2407b150566 Gerrit-Change-Number: 55106 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 05:27:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern
by Anastasia Klimchuk (Code Review) 07 Jun '21

07 Jun '21

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/55106 ) Change subject: nic3com.c: Refactor singleton states into reentrant pattern ...................................................................... Abandoned Squashed two commits into CB:55107 -- To view, visit https://review.coreboot.org/c/flashrom/+/55106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1c3e4836760cc9f4f9a0bd4294e8d2407b150566 Gerrit-Change-Number: 55106 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern
by Anastasia Klimchuk (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55107 ) Change subject: nic3com.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Looks like a duplicate of CB:55106? Oh no, looks like I created a mess :( This patch is the right one, another one is duplicate. Sorry for mess. I squashed two commits, and uploaded as one, this one. I will resolved your comments from CB:55106 here, let's keep this comment unresolved until I do this. -- To view, visit https://review.coreboot.org/c/flashrom/+/55107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9834b82650cd070556cf82207796bc6bd6b31b28 Gerrit-Change-Number: 55107 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 07 Jun 2021 05:26:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021