June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: platform: Fix endianness detection for Apple Silicon Macs
by Nico Huber (Code Review) 07 Jun '21

07 Jun '21

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54964 ) Change subject: platform: Fix endianness detection for Apple Silicon Macs ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I was able to successfully (and repeatedly) read and write W25X40 SPI flash with CH341A-based progra […] That tells us that libusb is working and probably a lot of USB programmers with it :) -- To view, visit https://review.coreboot.org/c/flashrom/+/54964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifdb1523ee2c7023e657cfd7b823b091d5deef513 Gerrit-Change-Number: 54964 Gerrit-PatchSet: 3 Gerrit-Owner: Ivan V <root(a)pcm720.me> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 13:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ivan V <root(a)pcm720.me> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: treewide: Use calloc() where applicable
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55269 ) Change subject: treewide: Use calloc() where applicable ...................................................................... treewide: Use calloc() where applicable Replace uses of malloc() with calloc() where the newly-allocated buffer is then zero-initialised or its size argument is the product of element size by the number of elements. Change-Id: Id6ef0d6d02c7b63baabc9a0087275cab22a48736 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M jlink_spi.c M libflashrom.c M mstarddc_spi.c M sfdp.c M spi95.c 5 files changed, 10 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/55269/1 diff --git a/jlink_spi.c b/jlink_spi.c index 0b862cf..b2e5151 100644 --- a/jlink_spi.c +++ b/jlink_spi.c @@ -115,7 +115,7 @@ if (length > JTAG_MAX_TRANSFER_SIZE) return SPI_INVALID_LENGTH; - buffer = malloc(length); + buffer = calloc(1, length); if (!buffer) { msg_perr("Memory allocation failed.\n"); @@ -125,8 +125,6 @@ /* Reverse all bytes because the device transfers data LSB first. */ reverse_bytes(buffer, writearr, writecnt); - memset(buffer + writecnt, 0x00, readcnt); - if (!assert_cs(jlink_data)) { free(buffer); return SPI_PROGRAMMER_ERROR; diff --git a/libflashrom.c b/libflashrom.c index ef0b417..62b0856 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -120,7 +120,7 @@ const char **flashrom_supported_programmers(void) { enum programmer p = 0; - const char **supported_programmers = malloc((PROGRAMMER_INVALID + 1) * sizeof(char*)); + const char **supported_programmers = calloc(PROGRAMMER_INVALID + 1, sizeof(char *)); if (supported_programmers != NULL) { for (; p < PROGRAMMER_INVALID; ++p) { @@ -141,7 +141,7 @@ { unsigned int i = 0; struct flashrom_flashchip_info *supported_flashchips = - malloc(flashchips_size * sizeof(*supported_flashchips)); + calloc(flashchips_size, sizeof(*supported_flashchips)); if (supported_flashchips != NULL) { for (; i < flashchips_size; ++i) { @@ -182,7 +182,7 @@ ++boards_known_size; struct flashrom_board_info *supported_boards = - malloc(boards_known_size * sizeof(*supported_boards)); + calloc(boards_known_size, sizeof(*supported_boards)); if (supported_boards != NULL) { for (; i < boards_known_size; ++i) { @@ -219,7 +219,7 @@ ++chipset_enables_size; struct flashrom_chipset_info *supported_chipsets = - malloc(chipset_enables_size * sizeof(*supported_chipsets)); + calloc(chipset_enables_size, sizeof(*supported_chipsets)); if (supported_chipsets != NULL) { for (; i < chipset_enables_size; ++i) { @@ -339,10 +339,9 @@ chip_to_probe = chip_name; /* chip_to_probe is global in flashrom.c */ - *flashctx = malloc(sizeof(**flashctx)); + *flashctx = calloc(1, sizeof(**flashctx)); if (!*flashctx) return 1; - memset(*flashctx, 0, sizeof(**flashctx)); for (i = 0; i < registered_master_count; ++i) { int flash_idx = -1; diff --git a/mstarddc_spi.c b/mstarddc_spi.c index 0f638df..3eb5743 100644 --- a/mstarddc_spi.c +++ b/mstarddc_spi.c @@ -80,7 +80,7 @@ { struct mstarddc_spi_data *mstarddc_data = flash->mst->spi.data; int ret = 0; - uint8_t *cmd = malloc((writecnt + 1) * sizeof(uint8_t)); + uint8_t *cmd = calloc(writecnt + 1, sizeof(uint8_t)); if (cmd == NULL) { msg_perr("Error allocating memory: errno %d.\n", errno); ret = -1; diff --git a/sfdp.c b/sfdp.c index 530588f..a998b55 100644 --- a/sfdp.c +++ b/sfdp.c @@ -299,8 +299,8 @@ nph + 1, nph); /* Fetch all parameter headers, even if we don't use them all (yet). */ - hbuf = malloc((nph + 1) * 8); - hdrs = malloc((nph + 1) * sizeof(*hdrs)); + hbuf = calloc(nph + 1, 8); + hdrs = calloc(nph + 1, sizeof(*hdrs)); if (hbuf == NULL || hdrs == NULL ) { msg_gerr("Out of memory!\n"); goto cleanup_hdrs; diff --git a/spi95.c b/spi95.c index 976f99a..3a70a9f 100644 --- a/spi95.c +++ b/spi95.c @@ -60,7 +60,7 @@ uint8_t *erased_contents = NULL; int result = 0; - erased_contents = (uint8_t *)malloc(blocklen * sizeof(uint8_t)); + erased_contents = calloc(blocklen, sizeof(uint8_t)); if (!erased_contents) { msg_cerr("Out of memory!\n"); return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/55269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6ef0d6d02c7b63baabc9a0087275cab22a48736 Gerrit-Change-Number: 55269 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: treewide: Drop unnecessary uses of memset/memcpy
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Angel Pons. Hello Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55267 to look at the new patch set (#2). Change subject: treewide: Drop unnecessary uses of memset/memcpy ...................................................................... treewide: Drop unnecessary uses of memset/memcpy Simply provide an initialiser or use a direct assignment instead. Change-Id: I07385375cd8eec8a95874001b402b2c17ec09e09 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashrom.c M ichspi.c M jlink_spi.c M linux_mtd.c M physmap.c M raiden_debug_spi.c M stlinkv3_spi.c M usbblaster_spi.c 8 files changed, 21 insertions(+), 49 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/55267/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I07385375cd8eec8a95874001b402b2c17ec09e09 Gerrit-Change-Number: 55267 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: treewide: Drop unnecessary uses of memset/memcpy
by Nico Huber (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55267 ) Change subject: treewide: Drop unnecessary uses of memset/memcpy ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I07385375cd8eec8a95874001b402b2c17ec09e09 Gerrit-Change-Number: 55267 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 07 Jun 2021 11:42:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: treewide: Drop most cases of `sizeof(struct ...)`
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Edward O'Callaghan, Arthur Heymans, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55266 ) Change subject: treewide: Drop most cases of `sizeof(struct ...)` ...................................................................... Patch Set 1: (3 comments) File flashrom.c: https://review.coreboot.org/c/flashrom/+/55266/comment/60670ade_44a1f532 PS1, Line 1242: memcpy(flash->chip, chip, sizeof(*flash->chip)); > NB. […] CB:55267 File ichspi.c: https://review.coreboot.org/c/flashrom/+/55266/comment/56504c98_23c9ab38 PS1, Line 1734: memset(&desc, 0x00, sizeof(desc)); > Or initialize with `= { 0 }`. CB:55267 File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/55266/comment/a670a689_328860a3 PS1, Line 1594: memcpy(spi_config, &spi_master_raiden_debug, sizeof(*spi_config)); > NB. […] CB:55267 -- To view, visit https://review.coreboot.org/c/flashrom/+/55266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6 Gerrit-Change-Number: 55266 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 11:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Fix data leak in params processing error paths
by Nico Huber (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 ) Change subject: dummyflasher.c: Fix data leak in params processing error paths ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/54748/comment/513bc826_f1f8aa0c PS5, Line 13: were where -- To view, visit https://review.coreboot.org/c/flashrom/+/54748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87 Gerrit-Change-Number: 54748 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 11:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: treewide: Drop unnecessary uses of memset/memcpy
by Angel Pons (Code Review) 07 Jun '21

07 Jun '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55267 ) Change subject: treewide: Drop unnecessary uses of memset/memcpy ...................................................................... treewide: Drop unnecessary uses of memset/memcpy Simply provide an initialiser or use a direct assignment instead. Change-Id: I07385375cd8eec8a95874001b402b2c17ec09e09 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashrom.c M ichspi.c M raiden_debug_spi.c 3 files changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/55267/1 diff --git a/flashrom.c b/flashrom.c index fcaa3ef..60d8321 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1239,7 +1239,7 @@ msg_gerr("Out of memory!\n"); exit(1); } - memcpy(flash->chip, chip, sizeof(*flash->chip)); + *flash->chip = *chip; flash->mst = mst; if (map_flash(flash) != 0) diff --git a/ichspi.c b/ichspi.c index 20dac1b..091e4e2 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1720,7 +1720,7 @@ char *arg; int ich_spi_rw_restricted = 0; int desc_valid = 0; - struct ich_descriptors desc; + struct ich_descriptors desc = { 0 }; enum ich_spi_mode { ich_auto, ich_hwseq, @@ -1731,8 +1731,6 @@ ich_generation = ich_gen; ich_spibar = spibar; - memset(&desc, 0x00, sizeof(desc)); - /* Moving registers / bits */ switch (ich_gen) { case CHIPSET_100_SERIES_SUNRISE_POINT: diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index 950b8af..ef4757b 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -1591,7 +1591,7 @@ return SPI_GENERIC_ERROR; } - memcpy(spi_config, &spi_master_raiden_debug, sizeof(*spi_config)); + *spi_config = spi_master_raiden_debug; data->dev = device; data->in_ep = in_endpoint; -- To view, visit https://review.coreboot.org/c/flashrom/+/55267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I07385375cd8eec8a95874001b402b2c17ec09e09 Gerrit-Change-Number: 55267 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: treewide: Drop most cases of `sizeof(struct ...)`
by Nico Huber (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55266 ) Change subject: treewide: Drop most cases of `sizeof(struct ...)` ...................................................................... Patch Set 1: Code-Review+2 (3 comments) File flashrom.c: https://review.coreboot.org/c/flashrom/+/55266/comment/108391d1_20fb8811 PS1, Line 1242: memcpy(flash->chip, chip, sizeof(*flash->chip)); NB. could even use an assignment w/o bypassing typechecks? File ichspi.c: https://review.coreboot.org/c/flashrom/+/55266/comment/e7bc05da_7a53f336 PS1, Line 1734: memset(&desc, 0x00, sizeof(desc)); Or initialize with `= { 0 }`. File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/55266/comment/dfa42b66_01def160 PS1, Line 1594: memcpy(spi_config, &spi_master_raiden_debug, sizeof(*spi_config)); NB. could even use an assignment w/o bypassing typechecks? -- To view, visit https://review.coreboot.org/c/flashrom/+/55266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6 Gerrit-Change-Number: 55266 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 11:26:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Drop useless macros
by Nico Huber (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55265 ) Change subject: dummyflasher.c: Drop useless macros ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If46e1c37c3b04b28b4ba1f82c9b3def1e549368f Gerrit-Change-Number: 55265 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 11:08:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher.c: Fix data leak in params processing error paths
by Nico Huber (Code Review) 07 Jun '21

07 Jun '21

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 ) Change subject: dummyflasher.c: Fix data leak in params processing error paths ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/54748/comment/7eb8ca94_0de7188e PS4, Line 20: > I haven't seen this tag before, is it used often? I saw people mention in commit message "follow-up […] Heh, I actually prefer text over the Fixes: tag ;) The tag is just what other people use... probably more common in coreboot. Regarding CB:, it's a layer of indirection. Before a commit is submitted to master, we can only reference the change, because the commit hash is not final. Pro: Gerrit links it conveniently. Con: Native Git tools know nothing about it and one would have to search for the number manually. For already merged commits, I prefer to use the commit hash and summary. IIRC, if it's prefixed with `commit`, Gerrit also links it. Eventually, this Gerrit instance may not run anymore, but the Git history prevails. NB. I'm not a fan of forward references, jumping back and forth can make the review harder. There are exceptions ofc. File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54748/comment/150dc8e6_022d2882 PS1, Line 26: /* Remove the #define below if you don't want SPI flash chip emulation. */ : #define EMULATE_SPI_CHIP 1 > Just to confirm, you mean, let's assume (EMULATE_CHIP && EMULATE_SPI_CHIP) always true and drop the code outside the #if? So that dummy will always be dummy_spi? But then maybe have another one dummy_par? Maybe someone needs those different values. `dummy` is already both `dummy_spi` and `dummy_par` at once. Both masters are registered if the commandline says they should be supported. EMULATE*_ CHIP is only about emulating a flash chip connected to the bus. I don't see why we couldn't have one chip on each bus at once. Not sure what you mean with "drop the code outside the #if". All the code is compiled in currently. There is no #else that would be dropped. > > I don't know what was the initial meaning of !EMULATE_CHIP use case. What dummy is doing if it is not emulating any chip? I see it can emulate spi or par, I can understand, but not emulating anything? It's emulating buses, that's already enough to test flash probing for instance. But the behavior should be the same as with `EMULATE_CHIP == 1` and no chip given on the commandline, I guess. So I really don't see a reason for the #if mess. File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/54748/comment/c18345a1_f5a4b487 PS4, Line 994: dummy_buses_supported > I was thinking about it, and my guess was, because it is only needed for init time, and not needed l […] It is not only used for init. But there lies the answer: it's used get the data pointer in get_data_from_context(); so it can't be part of it. However, it seems unnecessary, `flash->mst` also has a `buses_supported` field? Very odd. -- To view, visit https://review.coreboot.org/c/flashrom/+/54748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87 Gerrit-Change-Number: 54748 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Jun 2021 11:06:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021