June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: pcidev: Move pci device functions out of internal programmer
by Michał Żygowski (Code Review) 25 Jun '21

25 Jun '21

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55848 ) Change subject: pcidev: Move pci device functions out of internal programmer ...................................................................... pcidev: Move pci device functions out of internal programmer PCI device helper functions implemented in internal programmer are generic, not specific to this particular programmer. Move them to the common pcidev.c file which is included in all programmers requiring PCI and may be used not only for internal programmer. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ice40783a05c01cc78b34eb2c4a575554e9d55f8e --- M internal.c M pcidev.c 2 files changed, 58 insertions(+), 58 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/55848/1 diff --git a/internal.c b/internal.c index abd4637..005bd8d 100644 --- a/internal.c +++ b/internal.c @@ -30,64 +30,6 @@ enum chipbustype internal_buses_supported = BUS_NONE; -struct pci_dev *pci_dev_find_vendorclass(uint16_t vendor, uint16_t devclass) -{ - struct pci_dev *temp; - struct pci_filter filter; - uint16_t tmp2; - - pci_filter_init(NULL, &filter); - filter.vendor = vendor; - - for (temp = pacc->devices; temp; temp = temp->next) - if (pci_filter_match(&filter, temp)) { - /* Read PCI class */ - tmp2 = pci_read_word(temp, 0x0a); - if (tmp2 == devclass) - return temp; - } - - return NULL; -} - -struct pci_dev *pci_dev_find(uint16_t vendor, uint16_t device) -{ - struct pci_dev *temp; - struct pci_filter filter; - - pci_filter_init(NULL, &filter); - filter.vendor = vendor; - filter.device = device; - - for (temp = pacc->devices; temp; temp = temp->next) - if (pci_filter_match(&filter, temp)) - return temp; - - return NULL; -} - -struct pci_dev *pci_card_find(uint16_t vendor, uint16_t device, - uint16_t card_vendor, uint16_t card_device) -{ - struct pci_dev *temp; - struct pci_filter filter; - - pci_filter_init(NULL, &filter); - filter.vendor = vendor; - filter.device = device; - - for (temp = pacc->devices; temp; temp = temp->next) - if (pci_filter_match(&filter, temp)) { - if ((card_vendor == - pci_read_word(temp, PCI_SUBSYSTEM_VENDOR_ID)) - && (card_device == - pci_read_word(temp, PCI_SUBSYSTEM_ID))) - return temp; - } - - return NULL; -} - #if IS_X86 void probe_superio(void) { diff --git a/pcidev.c b/pcidev.c index 9ffe05c..30bf981 100644 --- a/pcidev.c +++ b/pcidev.c @@ -333,3 +333,61 @@ register_undo_pci_write_long(dev, reg); return pci_write_long(dev, reg, data); } + +struct pci_dev *pci_dev_find_vendorclass(uint16_t vendor, uint16_t devclass) +{ + struct pci_dev *temp; + struct pci_filter filter; + uint16_t tmp2; + + pci_filter_init(NULL, &filter); + filter.vendor = vendor; + + for (temp = pacc->devices; temp; temp = temp->next) + if (pci_filter_match(&filter, temp)) { + /* Read PCI class */ + tmp2 = pci_read_word(temp, 0x0a); + if (tmp2 == devclass) + return temp; + } + + return NULL; +} + +struct pci_dev *pci_dev_find(uint16_t vendor, uint16_t device) +{ + struct pci_dev *temp; + struct pci_filter filter; + + pci_filter_init(NULL, &filter); + filter.vendor = vendor; + filter.device = device; + + for (temp = pacc->devices; temp; temp = temp->next) + if (pci_filter_match(&filter, temp)) + return temp; + + return NULL; +} + +struct pci_dev *pci_card_find(uint16_t vendor, uint16_t device, + uint16_t card_vendor, uint16_t card_device) +{ + struct pci_dev *temp; + struct pci_filter filter; + + pci_filter_init(NULL, &filter); + filter.vendor = vendor; + filter.device = device; + + for (temp = pacc->devices; temp; temp = temp->next) + if (pci_filter_match(&filter, temp)) { + if ((card_vendor == + pci_read_word(temp, PCI_SUBSYSTEM_VENDOR_ID)) + && (card_device == + pci_read_word(temp, PCI_SUBSYSTEM_ID))) + return temp; + } + + return NULL; +} -- To view, visit https://review.coreboot.org/c/flashrom/+/55848 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ice40783a05c01cc78b34eb2c4a575554e9d55f8e Gerrit-Change-Number: 55848 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: sio.c: Put generic Super I/O access scattered throughout files together
by Michał Żygowski (Code Review) 25 Jun '21

25 Jun '21

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55849 ) Change subject: sio.c: Put generic Super I/O access scattered throughout files together ...................................................................... sio.c: Put generic Super I/O access scattered throughout files together Put generic Super I/O helpers in one file and depend compiling it on raw access and x86 architecture. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ie36370c22edb05ee59b036859b44a968bcc37980 --- M Makefile M board_enable.c M internal.c M programmer.h A sio.c 5 files changed, 95 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/55849/1 diff --git a/Makefile b/Makefile index be6e551..6d80617 100644 --- a/Makefile +++ b/Makefile @@ -1184,6 +1184,8 @@ # Raw memory, MSR or PCI port I/O access. FEATURE_CFLAGS += -D'NEED_RAW_ACCESS=1' PROGRAMMER_OBJS += physmap.o hwaccess.o +# Generic Super I/O helpers for raw access +PROGRAMMER_OBJS += sio.o ifeq ($(TARGET_OS), NetBSD) # For (i386|x86_64)_iopl(2). diff --git a/board_enable.c b/board_enable.c index 9cf0103..e04cdf7 100644 --- a/board_enable.c +++ b/board_enable.c @@ -44,28 +44,6 @@ OUTB(0xAA, port); } -/* Generic Super I/O helper functions */ -uint8_t sio_read(uint16_t port, uint8_t reg) -{ - OUTB(reg, port); - return INB(port + 1); -} - -void sio_write(uint16_t port, uint8_t reg, uint8_t data) -{ - OUTB(reg, port); - OUTB(data, port + 1); -} - -void sio_mask(uint16_t port, uint8_t reg, uint8_t data, uint8_t mask) -{ - uint8_t tmp; - - OUTB(reg, port); - tmp = INB(port + 1) & ~mask; - OUTB(tmp | (data & mask), port + 1); -} - /* Winbond W83697 documentation indicates that the index register has to be written for each access. */ static void sio_mask_alzheimer(uint16_t port, uint8_t reg, uint8_t data, uint8_t mask) { diff --git a/internal.c b/internal.c index 005bd8d..71f1953 100644 --- a/internal.c +++ b/internal.c @@ -30,34 +30,6 @@ enum chipbustype internal_buses_supported = BUS_NONE; -#if IS_X86 -void probe_superio(void) -{ - probe_superio_winbond(); - /* ITE probe causes SMSC LPC47N217 to power off the serial UART. - * Always probe for SMSC first, and if a SMSC Super I/O is detected - * at a given I/O port, do _not_ probe that port with the ITE probe. - * This means SMSC probing must be done before ITE probing. - */ - //probe_superio_smsc(); - probe_superio_ite(); -} - -int superio_count = 0; -#define SUPERIO_MAX_COUNT 3 - -struct superio superios[SUPERIO_MAX_COUNT]; - -int register_superio(struct superio s) -{ - if (superio_count == SUPERIO_MAX_COUNT) - return 1; - superios[superio_count++] = s; - return 0; -} - -#endif /* IS_X86 */ - static void internal_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr) { diff --git a/programmer.h b/programmer.h index 9d1a9ad..a5df45f 100644 --- a/programmer.h +++ b/programmer.h @@ -221,6 +221,10 @@ int it8705f_write_enable(uint8_t port); uint8_t sio_read(uint16_t port, uint8_t reg); void sio_write(uint16_t port, uint8_t reg, uint8_t data); +void sio_switch_ldn(uint16_t port, uint8_t ldn); +uint16_t sio_get_iobase(uint16_t port, uint8_t io_bar_number); +uint16_t sio_read_id(uint16_t port, uint8_t io_bar_number); +bool sio_is_ldn_enabled(uint16_t port); void sio_mask(uint16_t port, uint8_t reg, uint8_t data, uint8_t mask); void board_handle_before_superio(void); void board_handle_before_laptop(void); diff --git a/sio.c b/sio.c new file mode 100644 index 0000000..35b504e --- /dev/null +++ b/sio.c @@ -0,0 +1,89 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2021, TUXEDO Computers GmbH + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#if defined(__i386__) || defined(__x86_64__) + +#include "programmer.h" +#include "hwaccess.h" + +void probe_superio(void) +{ + probe_superio_winbond(); + /* ITE probe causes SMSC LPC47N217 to power off the serial UART. + * Always probe for SMSC first, and if a SMSC Super I/O is detected + * at a given I/O port, do _not_ probe that port with the ITE probe. + * This means SMSC probing must be done before ITE probing. + */ + //probe_superio_smsc(); + probe_superio_ite(); +} + +int superio_count = 0; +#define SUPERIO_MAX_COUNT 3 + +struct superio superios[SUPERIO_MAX_COUNT]; + +int register_superio(struct superio s) +{ + if (superio_count == SUPERIO_MAX_COUNT) + return 1; + superios[superio_count++] = s; + return 0; +} + +/* Generic Super I/O helper functions */ +uint8_t sio_read(uint16_t port, uint8_t reg) +{ + OUTB(reg, port); + return INB(port + 1); +} + +void sio_write(uint16_t port, uint8_t reg, uint8_t data) +{ + OUTB(reg, port); + OUTB(data, port + 1); +} + +void sio_mask(uint16_t port, uint8_t reg, uint8_t data, uint8_t mask) +{ + uint8_t tmp; + + OUTB(reg, port); + tmp = INB(port + 1) & ~mask; + OUTB(tmp | (data & mask), port + 1); +} + +void sio_switch_ldn(uint16_t port, uint8_t ldn) +{ + sio_write(port, 0x07, ldn); +} + +uint16_t sio_get_iobase(uint16_t port, uint8_t io_bar_number) +{ + return (sio_read(port, 0x60 + io_bar_number * 2) << 8) | + sio_read(port, 0x61 + io_bar_number * 2); +} + +uint16_t sio_read_id(uint16_t port, uint8_t io_bar_number) +{ + return (sio_read(port, 0x20) << 8) | sio_read(port, 0x21); +} + +bool sio_is_ldn_enabled(uint16_t port) +{ + return (sio_read(port, 0x30) & 1) ? true : false; +} + +#endif \ No newline at end of file -- To view, visit https://review.coreboot.org/c/flashrom/+/55849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie36370c22edb05ee59b036859b44a968bcc37980 Gerrit-Change-Number: 55849 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michał Żygowski (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55715 to look at the new patch set (#10). Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops Add a new programmer supporting ITE Embedded Controllers found on TUXEDO laptops. Tested on TUXEDO InfinityBook S 14 Gen6 and 15 Gen6 with EC firmware updates from IBV, EC versions 1.07.02TR1 and 1.07.04TR4. Example standard command to update EC firmware on a TUXEDO laptop: "flashrom -p ite_ec:romsize=128K,autoload=disable -w eL14MU02.TR1" Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 --- M Makefile M flashrom.8.tmpl M it87spi.c A ite_ec.c A ite_ec.h M programmer.h M programmer_table.c 7 files changed, 1,111 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/55715/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 10 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: acpi_ec: Implement basic ACPI embedded controller API
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Michał Żygowski, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 ) Change subject: acpi_ec: Implement basic ACPI embedded controller API ...................................................................... Patch Set 4: (1 comment) File acpi_ec.h: https://review.coreboot.org/c/flashrom/+/55714/comment/a19b8505_83456c91 PS4, Line 44: bool ec_write_cmd(uint8_t control_port, uint8_t cmd, unsigned int max_checks); : bool ec_read_byte(uint8_t control_port, uint8_t data_port, uint8_t *data, : unsigned int max_checks); : bool ec_write_byte(uint8_t control_port, uint8_t data_port, uint8_t data, : unsigned int max_checks); : > The EFI firmware update application talks through multiple port pairs. […] Hmmm, let me ask this then: Was the `portpair` option of your driver tested for non-default values? If not, I'd rather not add code for it until somebody needs it. Another option to settle this would be to add all this as generic `ec` code (without the `acpi` prefix) and only rename the two functions below to something like acpi_ec_read()/acpi_ec_write(). The concept of the status/command + data ports is older than ACPI anyway. Technically, also not EC specific, but I think for now we can assume that we'll only need it for ECs. -- To view, visit https://review.coreboot.org/c/flashrom/+/55714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d Gerrit-Change-Number: 55714 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 25 Jun 2021 15:03:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: acpi_ec: Implement basic ACPI embedded controller API
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Michał Żygowski, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 ) Change subject: acpi_ec: Implement basic ACPI embedded controller API ...................................................................... Patch Set 4: (1 comment) File acpi_ec.c: https://review.coreboot.org/c/flashrom/+/55714/comment/d63ecd70_b85291e6 PS4, Line 23: ontrol_port > See EC ACPI spec You mean the EC chapter in the ACPI spec? Did you read it? It calls it EC_SC (status & command, I suppose). -- To view, visit https://review.coreboot.org/c/flashrom/+/55714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d Gerrit-Change-Number: 55714 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 25 Jun 2021 14:55:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michael Niewöhner (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... Patch Set 9: (2 comments) Patchset: PS4: > All other EC drivers were added lately without proper review. That they skip […] Oh wow, I wasn't aware of board_enable :O Thanks for that hint. Well, then that's the way to go I guess. File ite_ec.c: https://review.coreboot.org/c/flashrom/+/55715/comment/191c2602_a0336300 PS9, Line 176: ctx_data->control_port = EC_CONTROL; CMD,not CONTROL -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 25 Jun 2021 14:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: acpi_ec: Implement basic ACPI embedded controller API
by Michael Niewöhner (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Nico Huber, Michał Żygowski, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 ) Change subject: acpi_ec: Implement basic ACPI embedded controller API ...................................................................... Patch Set 4: (1 comment) File acpi_ec.c: https://review.coreboot.org/c/flashrom/+/55714/comment/276c5568_985e0337 PS4, Line 23: ontrol_port > Rather status port you read the status from that port, but it's still the "cmd port". See EC ACPI spec -- To view, visit https://review.coreboot.org/c/flashrom/+/55714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d Gerrit-Change-Number: 55714 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 25 Jun 2021 14:01:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: acpi_ec: Implement basic ACPI embedded controller API
by Michał Żygowski (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Nico Huber, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 ) Change subject: acpi_ec: Implement basic ACPI embedded controller API ...................................................................... Patch Set 4: (3 comments) File acpi_ec.h: https://review.coreboot.org/c/flashrom/+/55714/comment/5691775f_2466deb9 PS4, Line 41: bool ec_wait_for_ibuf(uint8_t control_port, unsigned int max_checks); : bool ec_wait_for_obuf(uint8_t control_port, unsigned int max_checks); > Do these need to be exported? Actually they don't https://review.coreboot.org/c/flashrom/+/55714/comment/5ee6f636_1587b041 PS4, Line 44: bool ec_write_cmd(uint8_t control_port, uint8_t cmd, unsigned int max_checks); : bool ec_read_byte(uint8_t control_port, uint8_t data_port, uint8_t *data, : unsigned int max_checks); : bool ec_write_byte(uint8_t control_port, uint8_t data_port, uint8_t data, : unsigned int max_checks); : > If these are part of an `acpi_ec` API and ACPI standardized the ports, […] The EFI firmware update application talks through multiple port pairs. I have no idea why it is implemented that way. Given the quality of this EFI application which the patches are based on, it may even simply be a bug. File acpi_ec.c: https://review.coreboot.org/c/flashrom/+/55714/comment/7d5e9f95_bcb1acbd PS4, Line 23: ontrol_port > cmd_port Rather status port -- To view, visit https://review.coreboot.org/c/flashrom/+/55714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d Gerrit-Change-Number: 55714 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 25 Jun 2021 13:47:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: acpi_ec: Implement basic ACPI embedded controller API
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Michał Żygowski, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 ) Change subject: acpi_ec: Implement basic ACPI embedded controller API ...................................................................... Patch Set 4: (4 comments) File acpi_ec.h: https://review.coreboot.org/c/flashrom/+/55714/comment/3bdd0749_0977fb56 PS4, Line 8: * the Free Software Foundation; version 2 of the License. It would be nice if you could convince TUXEDO to put it under GPLv2+. We try to suppress GPLv2-only to make libflashrom more useful. https://review.coreboot.org/c/flashrom/+/55714/comment/e19e6def_1052951e PS4, Line 26: /* Standard ports */ : #define EC_DATA 0x62 : #define EC_CONTROL 0x66 /* Read status, write commands */ : : /* Standard commands */ : #define EC_CMD_READ_REG 0x80 /* Read register's value */ : #define EC_CMD_WRITE_REG 0x81 /* Write register's value */ : : /* Some of the status bits */ : #define EC_STS_IBF (1 << 1) /* EC's input buffer full (host can't write) */ : #define EC_STS_OBF (1 << 0) /* EC's output buffer full (host can read) */ : Do these need to be exported? https://review.coreboot.org/c/flashrom/+/55714/comment/40ca7034_40eeb849 PS4, Line 41: bool ec_wait_for_ibuf(uint8_t control_port, unsigned int max_checks); : bool ec_wait_for_obuf(uint8_t control_port, unsigned int max_checks); Do these need to be exported? https://review.coreboot.org/c/flashrom/+/55714/comment/75e0c4f0_9bf972f1 PS4, Line 44: bool ec_write_cmd(uint8_t control_port, uint8_t cmd, unsigned int max_checks); : bool ec_read_byte(uint8_t control_port, uint8_t data_port, uint8_t *data, : unsigned int max_checks); : bool ec_write_byte(uint8_t control_port, uint8_t data_port, uint8_t data, : unsigned int max_checks); : If these are part of an `acpi_ec` API and ACPI standardized the ports, why allow to specify the port? Does the ITE driver talk on multiple interfaces at once? -- To view, visit https://review.coreboot.org/c/flashrom/+/55714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d Gerrit-Change-Number: 55714 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 25 Jun 2021 13:39:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Add 64KiB write granularity
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Michał Żygowski, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55713 ) Change subject: flashrom.c: Add 64KiB write granularity ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/55713/comment/40e22f8f_77b3f46d PS1, Line 506: 1024 * 64 > Done We have a `KiB` macro by now, so this could be `64*KiB`. -- To view, visit https://review.coreboot.org/c/flashrom/+/55713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I69801f581d0cb9b85f6596de7e1267ef9317673f Gerrit-Change-Number: 55713 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 25 Jun 2021 13:20:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021