June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: layout: Use linked list for `struct romentry`
by Nico Huber (Code Review) 26 Jun '21

26 Jun '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33521 ) Change subject: layout: Use linked list for `struct romentry` ...................................................................... Patch Set 8: (2 comments) File layout.c: https://review.coreboot.org/c/flashrom/+/33521/comment/0111516e_643ae007 PS8, Line 388: *layout = malloc(sizeof(**layout)); > Given that you memset() the allocated space afterwards, use calloc() instead? I like to see it explicitly if something is cleared explicitly. I can try something else, though. Maybe you'll like it better. https://review.coreboot.org/c/flashrom/+/33521/comment/00d12983_54967aad PS8, Line 458: if (layout == global_layout) : return; : : while (layout && layout->head) { : struct romentry *const entry = layout->head; : layout->head = entry->next; : free(entry->file); : free(entry->name); : free(entry); : } : free(layout); > Given that `layout` is not modified in the while loop, how about evaluating it once? […] Ack. Might make it less odd to read. -- To view, visit https://review.coreboot.org/c/flashrom/+/33521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I60a0aa1007ebcd5eb401db116f835d129b3e9732 Gerrit-Change-Number: 33521 Gerrit-PatchSet: 8 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 26 Jun 2021 00:10:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ich_descriptors: Revise detection for chipsets w/ ICCRIBA
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Michał Żygowski. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55647 ) Change subject: ich_descriptors: Revise detection for chipsets w/ ICCRIBA ...................................................................... Patch Set 4: (1 comment) File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/55647/comment/ea3e311a_6d5aeb11 PS3, Line 946: } else if (upper->MDTBA == 0x00) { > It seems much more invasive, do you want to do it? Anything to do here? Ping -- To view, visit https://review.coreboot.org/c/flashrom/+/55647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I587ad1abe390843d4a9e74431b6fc4b63f8ba512 Gerrit-Change-Number: 55647 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Fri, 25 Jun 2021 23:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [NOTFORMERGE] Add thoughts about bitbang CPOL/CPHA patches
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Xiang W, Angel Pons. Hello Xiang W, Angel Pons, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/55862 to review the following change. Change subject: [NOTFORMERGE] Add thoughts about bitbang CPOL/CPHA patches ...................................................................... [NOTFORMERGE] Add thoughts about bitbang CPOL/CPHA patches Change-Id: I6a4b64c686497a7df99ea50273ed90105d669858 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Documentation/bitbang_spi_analysis.md 1 file changed, 95 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/55862/1 diff --git a/Documentation/bitbang_spi_analysis.md b/Documentation/bitbang_spi_analysis.md index 293abe5..02196af 100644 --- a/Documentation/bitbang_spi_analysis.md +++ b/Documentation/bitbang_spi_analysis.md @@ -148,3 +148,98 @@ This would have to be tested. It even seems possible that raising `.half_period` above 0 together with this optimization might increase the speed and reliability. + +What happens with CB:49255 (bitbang-spi.c: support clock polarity and phase) +---------------------------------------------------------------------------- + +Let's assume the default `cpol = 0`, `cpha = 0`. + + __ h h h h h h h h + CS# |_____________________________________ + ____ ____ ____ ____ + SCK ______| |___| |___| |___| |_ + + MOSI XXXXXXX111111111222222222222222222222222 + + MISO XXXXXXXXXXXXXXXXXXXXXX333333333444444444 + ^ ^ + +MOSI is off by `.half_period`. It should be sampled right after the +rising edge of `SCK` where it's unstable. Still, how does it look +like with `.half_period = 0`? + + __ + CS# |_____________ + _ _ _ _ + SCK ___| || || || |_ + + MOSI XXXX111222222222 + + MISO XXXXXXXXXX333444 + ^ ^ + +Roughly the same, although MISO looks a little tighter. Note that +the `SCK` pattern is the same now for writing and reading. This is +because programming `MOSI` happens at the wrong time. + +Fixup to CB:49255 (bitbang_spi.c: fix spi sequence in time and rename) +---------------------------------------------------------------------- + + __ h h h h h h h h + CS# |_____________________________________ + ___ ___ ____ ____ + SCK _______| |____| |___| |___| |_ + + MOSI XXXXXX1111111112222222222222222222222222 + + MISO XXXXXXXXXXXXXXXXXXXXXX333333333444444444 + ^ ^ + +This gives a little more margin to the botched `MOSI` setting. But, +if looked at with a high `.half_period`, it would still look the +same. However, with `.half_period = 0` + + __ + CS# |_____________ + _ _ + SCK ____||_||| || |_ + + MOSI XXX1112222222222 + + MISO XXXXXXXXXX333444 + ^ ^ + +things look better. The rising edge of `SCK` aligns again with +`MOSI`. So the fixup fixes the regression for programmers with +`.half_period = 0`. Not necessarily for other values. + +Let's have a final look at this version for programmers that +pack the `SCK` setting with programming `MOSI` and sampling +`MISO`. + + __ h h h h h h h h + CS# |_________________________________ + ___ ___ ___ ___ + SCK ______| |___| |___| |___| |_ + + MOSI XXXXXX111111112222222222222222222222 + + MISO XXXXXXXXXXXXXXXXXXXX3333333344444444 + ^ ^ + +As things are packed, it's the same as without the fixup. And +without `.half_period`: + + __ + CS# |_________ + + SCK ___||||||||_ + + MOSI XXX112222222 + + MISO XXXXXXXX3344 + ^ ^ + +`MOSI` is still less likely to be stable at the rising edge of +`SCK`. For sampling `MISO` it's the same as for current `master` +(after commit 455a6fc8). -- To view, visit https://review.coreboot.org/c/flashrom/+/55862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6a4b64c686497a7df99ea50273ed90105d669858 Gerrit-Change-Number: 55862 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: [DRAFT] Document bitbang SPI thoughts
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Xiang W, Angel Pons. Hello build bot (Jenkins), Xiang W, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55860 to look at the new patch set (#3). Change subject: [DRAFT] Document bitbang SPI thoughts ...................................................................... [DRAFT] Document bitbang SPI thoughts Change-Id: I2437ad736b6677ad6eefa17a7b2d65d6f489f890 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- A Documentation/bitbang_spi_analysis.md 1 file changed, 150 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/55860/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/55860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2437ad736b6677ad6eefa17a7b2d65d6f489f890 Gerrit-Change-Number: 55860 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [DRAFT] Document bitbang SPI thoughts
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55860 to look at the new patch set (#2). Change subject: [DRAFT] Document bitbang SPI thoughts ...................................................................... [DRAFT] Document bitbang SPI thoughts Change-Id: I2437ad736b6677ad6eefa17a7b2d65d6f489f890 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- A Documentation/bitbang_spi_analysis.md 1 file changed, 150 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/55860/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2437ad736b6677ad6eefa17a7b2d65d6f489f890 Gerrit-Change-Number: 55860 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [DRAFT] Document bitbang SPI thoughts
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Angel Pons. Hello Angel Pons, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/55860 to review the following change. Change subject: [DRAFT] Document bitbang SPI thoughts ...................................................................... [DRAFT] Document bitbang SPI thoughts Change-Id: I2437ad736b6677ad6eefa17a7b2d65d6f489f890 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- A Documentation/bitbang_spi_analysis.md 1 file changed, 150 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/55860/1 diff --git a/Documentation/bitbang_spi_analysis.md b/Documentation/bitbang_spi_analysis.md new file mode 100644 index 0000000..765aeb7 --- /dev/null +++ b/Documentation/bitbang_spi_analysis.md @@ -0,0 +1,150 @@ +Analysis of changes to flashrom's `bitbang_spi` driver +====================================================== + +* `.half_period` is considered 3 chars long, marked by an `h`. + +* Delays incurred by programming or reading a hardware value + are 1 char long. So are transmission delays including the + time the other endpoint needs to react. + +* Assumed is `mode 0`, i.e. `CPOL = 0` and `CPHA = 0`. Changes + should happen after a falling edge of `SCK` or `CS#` and + sampling after a rising edge of `SCK`. + +* `^` denotes a sampling at our end. + +Before commit b623f403 (bitbang_spi: Add functions to optimize xfers) +--------------------------------------------------------------------- + + __ h h h h h h h h + CS# |_________________________________________ + ____ ____ ____ ____ + SCK _______| |____| |____| |____| |_ + + MOSI ___11111111112222222222333333333344444444445 + + MISO XXXX1111111111222222222233333333334444444444 + ^ ^ ^ ^ + +This looks quite balanced actually. Now, what happens if we set +`.half_period = 0`? + + __ + CS# |_________________ + _ _ _ _ + SCK ____| |_| |_| |_| |_ + + MOSI ___11112222333344445 + + MISO XXXX1111222233334444 + ^ ^ ^ ^ + +Looks ok'ish. Only notice that we sample a little early. It might +be better to sample after the falling edge of `SCK`, however that +would make the code incompatible to `.half_period != 0` :-/ + +With commit b623f403 (bitbang_spi: Add functions to optimize xfers) +------------------------------------------------------------------- + +We explicitly set `SCK = 0` before setting `MOSI` now, which adds +a tiny delay at the start: + + __ h h h h h h h h + CS# |__________________________________________ + ____ ____ ____ ____ + SCK ________| |____| |____| |____| |_ + + MOSI ____11111111112222222222333333333344444444445 + + MISO XXXX11111111111222222222233333333334444444444 + ^ ^ ^ ^ + +Nothing to spectacular with `.half_period = 0` either: + + __ + CS# |__________________ + _ _ _ _ + SCK _____| |_| |_| |_| |_ + + MOSI ____11112222333344445 + + MISO XXXX11111222233334444 + ^ ^ ^ ^ + +With commit 455a6fc8 (bitbang_spi: Add half-duplex optimizations) +----------------------------------------------------------------- + +We assume half-duplex from now on. This removes a sampling delay +per bit on our end during the first, writing phase, and a program- +ming delay per bit during the second, read phase. + +We still program `MOSI = 0` at the start of every byte *read*, +though. Don't know why. It incurs a programming delay per byte. +We'll mark this with `o` for odd. We'll also assume bytes are +only 2 bits long, to not make the diagrams explode. + + __ h h h h h h h h + CS# |_______________________________________ + ___ ___ ____ ____ + SCK ________| |____| |____| |___| |_ + + MOSI ____111111111222222222____________________ + + MISO XXXXXXXXXXXXXXXXXXXXXXX3333333333444444444 + ^ ^ + +Note that during the write phase, the clock-high periods are +shorter now, and during the read phase, the clock-lock periods +are shorter. Now, once again, let's remove the `.half_period` +delays (vim makes this awesomely easy btw. ^^). + + __ + CS# |_______________ + _ _ + SCK _____||_||_| || || + + MOSI ____111222________ + + MISO XXXXXXXXXXX3333444 + ^ ^ + +This looks pretty tense. But remember: everyone is supposed +to sample after a rising edge of `SCK`. Which is right in the +center of our `MOSI` output. With `MISO`, however, things +look bad. This is assuming programming, sampling and a trans- +mission round-trip all take the same time. *If* the round-trip +is not longer, we should still be safe. + +Making use of 455a6fc8's optimizations +-------------------------------------- + +Now what happens if we pack setting `SCK = 0` with setting +`MOSI` and setting `SCK = 1` with sampling `MISO`? + + __ h h h h h h h h + CS# |___________________________________ + ___ ___ ___ ___ + SCK ________| |___| |___| |___| |_ + + MOSI ____1111111122222222__________________ + + MISO XXXXXXXXXXXXXXXXXXXXXX3333333344444444 + ^ ^ + +A nice picture once more, but what happens if we ditch +`.half_period`? + + __ + CS# |___________ + + SCK _____||||||||_ + + MOSI ____1122______ + + MISO XXXXXXXXXX3344 + ^ ^ + +We'd definitely sample very early. Could it work? I don't know. +This would have to be tested. It even seems possible that raising +`.half_period` above 0 together with this optimization might +increase the speed and reliability. -- To view, visit https://review.coreboot.org/c/flashrom/+/55860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2437ad736b6677ad6eefa17a7b2d65d6f489f890 Gerrit-Change-Number: 55860 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: rayer_spi.c: Implement `set_sck_set_mosi`
by Angel Pons (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49265 ) Change subject: rayer_spi.c: Implement `set_sck_set_mosi` ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Need to think some more about this as I just realized that this driver […] Hmmm, good point. CB:49267 and CB:55720 are for nicintel_spi, which sets `.half_delay = 1`. And both were tested by Idwer and me. -- To view, visit https://review.coreboot.org/c/flashrom/+/49265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb05a35967685c2444d064cb61cec98e2a00f590 Gerrit-Change-Number: 49265 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 25 Jun 2021 15:44:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: rayer_spi.c: Implement `set_sck_set_mosi`
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49265 ) Change subject: rayer_spi.c: Implement `set_sck_set_mosi` ...................................................................... Patch Set 3: -Code-Review (1 comment) Patchset: PS3: Need to think some more about this as I just realized that this driver (among others) sets `.half_delay = 0`. This will make things more susceptible wrt. timing changes. -- To view, visit https://review.coreboot.org/c/flashrom/+/49265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb05a35967685c2444d064cb61cec98e2a00f590 Gerrit-Change-Number: 49265 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 25 Jun 2021 15:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: rayer_spi.c: Implement `set_sck_set_mosi`
by Nico Huber (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49265 ) Change subject: rayer_spi.c: Implement `set_sck_set_mosi` ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb05a35967685c2444d064cb61cec98e2a00f590 Gerrit-Change-Number: 49265 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 25 Jun 2021 15:25:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michał Żygowski (Code Review) 25 Jun '21

25 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... Patch Set 10: (1 comment) Patchset: PS4: > Oh wow, I wasn't aware of board_enable :O Thanks for that hint. […] Yeah, I started some work on the Super I/O is preceding patch: 55849 However it is still much to do. The code for Super I/Os is too scattered. -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 10 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 25 Jun 2021 15:20:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021