April 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: layout: Add -i <region>[:<file>] support
by Jack Rosenthal (Code Review) 17 Apr '21

17 Apr '21

Attention is currently required from: Sam McNally, Nico Huber, Nicola Corna, Paul Menzel, Stefan Reinauer, David Hendricks, Daniel Campello, Arthur Heymans, Carl-Daniel Hailfinger. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23021 ) Change subject: layout: Add -i <region>[:<file>] support ...................................................................... Patch Set 31: (1 comment) File layout.c: https://review.coreboot.org/c/flashrom/+/23021/comment/c7cb9f1e_e3c1df55 PS31, Line 126: strtok name = include; has_colon[0] = '\0'; file = has_colon + 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 31 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nicola Corna <nicola(a)corna.info> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Comment-Date: Sat, 17 Apr 2021 00:11:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic.c: add -x option for do_extract()
by Daniel Campello (Code Review) 16 Apr '21

16 Apr '21

Daniel Campello has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52450 ) Change subject: cli_classic.c: add -x option for do_extract() ...................................................................... cli_classic.c: add -x option for do_extract() This change introduces a new option to extract all layout regions to files with the name of each region (or with the provided filename via -i region:file). It is implemented by mutating the flash layout to include all regions and backfilling the entry->file with entry->name (replacing spaces with underscores) Signed-off-by: Daniel Campello <campello(a)chromium.org> Change-Id: I8c69223fa92cf5b50abe070f1ab9f19d3b42f6ff --- M cli_classic.c M flash.h M flashrom.c M layout.c M layout.h 5 files changed, 38 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/52450/1 diff --git a/cli_classic.c b/cli_classic.c index 64e358f..398b4c8 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -58,6 +58,7 @@ " -f | --force force specific operations (see man page)\n" " -n | --noverify don't auto-verify\n" " -N | --noverify-all verify included regions only (cf. -i)\n" + " -x | --extract extract regions to files\n" " -l | --layout <layoutfile> read ROM layout from <layoutfile>\n" " --wp-disable disable write protection\n" " --wp-enable enable write protection\n" @@ -172,7 +173,7 @@ int flash_name = 0, flash_size = 0; int set_wp_enable = 0, set_wp_disable = 0, wp_status = 0; int set_wp_range = 0, set_wp_region = 0, wp_list = 0; - int read_it = 0, write_it = 0, erase_it = 0, verify_it = 0; + int read_it = 0, extract_it = 0, write_it = 0, erase_it = 0, verify_it = 0; int dont_verify_it = 0, dont_verify_all = 0, list_supported = 0, operation_specified = 0; struct flashrom_layout *layout = NULL; enum programmer prog = PROGRAMMER_INVALID; @@ -193,7 +194,7 @@ int ret = 0; unsigned int wp_start = 0, wp_len = 0; - static const char optstring[] = "r::Rw::v::nNVEfc:l:i:p:Lzho:"; + static const char optstring[] = "r::Rw::v::nNVEfc:l:i:p:Lzho:x"; static const struct option long_options[] = { {"read", 2, NULL, 'r'}, {"write", 2, NULL, 'w'}, @@ -201,6 +202,7 @@ {"verify", 2, NULL, 'v'}, {"noverify", 0, NULL, 'n'}, {"noverify-all", 0, NULL, 'N'}, + {"extract", 0, NULL, 'x'}, {"chip", 1, NULL, 'c'}, {"verbose", 0, NULL, 'V'}, {"force", 0, NULL, 'f'}, @@ -283,6 +285,10 @@ case 'N': dont_verify_all = 1; break; + case 'x': + cli_classic_validate_singleop(&operation_specified); + extract_it = 1; + break; case 'c': chip_to_probe = strdup(optarg); break; @@ -656,7 +662,7 @@ if (!(read_it | write_it | verify_it | erase_it | flash_name | flash_size | set_wp_range | set_wp_region | set_wp_enable | - set_wp_disable | wp_status | wp_list)) { + set_wp_disable | wp_status | wp_list | extract_it)) { msg_ginfo("No operations were specified.\n"); goto out_shutdown; } @@ -857,6 +863,8 @@ programmer_delay(100000); if (read_it) ret = do_read(fill_flash, filename); + else if (extract_it) + ret = do_extract(fill_flash); else if (erase_it) ret = do_erase(fill_flash); else if (write_it) diff --git a/flash.h b/flash.h index c0e5c27..dd8e156 100644 --- a/flash.h +++ b/flash.h @@ -357,6 +357,7 @@ int prepare_flash_access(struct flashctx *, bool read_it, bool write_it, bool erase_it, bool verify_it); void finalize_flash_access(struct flashctx *); int do_read(struct flashctx *, const char *filename); +int do_extract(struct flashctx *); int do_erase(struct flashctx *); int do_write(struct flashctx *, const char *const filename, const char *const referencefile); int do_verify(struct flashctx *, const char *const filename); diff --git a/flashrom.c b/flashrom.c index d048a62..152f30c 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2705,6 +2705,12 @@ return ret; } +int do_extract(struct flashctx *const flash) +{ + prepare_layout_for_extraction(flash); + return do_read(flash, NULL); +} + int do_erase(struct flashctx *const flash) { const int ret = flashrom_flash_erase(flash); diff --git a/layout.c b/layout.c index c6276a1..acba58f 100644 --- a/layout.c +++ b/layout.c @@ -15,6 +15,7 @@ * GNU General Public License for more details. */ +#include <ctype.h> #include <errno.h> #include <stdio.h> #include <stdlib.h> @@ -314,6 +315,24 @@ return ret; } +void prepare_layout_for_extraction(struct flashctx *flash) +{ + const struct flashrom_layout *const l = get_layout(flash); + unsigned int i, j; + + for (i = 0; i < l->num_entries; ++i) { + l->entries[i].included = true; + + if (!l->entries[i].file) + l->entries[i].file = strdup(l->entries[i].name); + + for (j = 0; l->entries[i].file[j]; j++) { + if (isspace(l->entries[i].file[j])) + l->entries[i].file[j] = '_'; + } + } +} + const struct romentry *layout_next_included_region( const struct flashrom_layout *const l, const chipoff_t where) { diff --git a/layout.h b/layout.h index b11c432..327f5bf 100644 --- a/layout.h +++ b/layout.h @@ -69,5 +69,6 @@ const struct romentry *layout_next_included_region(const struct flashrom_layout *, chipoff_t); const struct romentry *layout_next_included(const struct flashrom_layout *, const struct romentry *); int included_regions_overlap(const struct flashrom_layout *const flashrom_layout); +void prepare_layout_for_extraction(struct flashrom_flashctx *flash); #endif /* !__LAYOUT_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/52450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8c69223fa92cf5b50abe070f1ab9f19d3b42f6ff Gerrit-Change-Number: 52450 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Add unit test to run init/shutdown for enabled drivers
by Nico Huber (Code Review) 16 Apr '21

16 Apr '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 ) Change subject: Add unit test to run init/shutdown for enabled drivers ...................................................................... Patch Set 2: (5 comments) Patchset: PS2: > Hello my reviewers and cc! What do people think of the latest version that has mocks in a separate c […] Please split and thanks for the patience! The dummyflasher change, for instance can be submitted without any hassle. Splitting `hwaccess.h` can be its own commit, and the introduction of LOG_ME() likewise. The former can be tested by comparing binaries. File hwaccess_io_unittest.h: PS2: Move into `tests/`? https://review.coreboot.org/c/flashrom/+/51487/comment/a471b70b_c2835431 PS2, Line 24: #ifndef __HWACCESS_IO_H__ Maybe leave a comment that we intentionally use the same guard. File tests/meson.build: https://review.coreboot.org/c/flashrom/+/51487/comment/a873de2a_fd0fe161 PS2, Line 36: '-Wl,--wrap=test_outb', : '-Wl,--wrap=test_inb', : '-Wl,--wrap=test_outw', : '-Wl,--wrap=test_inw', : '-Wl,--wrap=test_outl', : '-Wl,--wrap=test_inl', I guess as these are not implemented anywhere, we don't need to "wrap" them? i.e. without these lines and s/__wrap_test_/test_/ in `tests.c`, I'd expect it to work too. We could leave it as is though, for uniformity. File tests/tests.c: https://review.coreboot.org/c/flashrom/+/51487/comment/5975699b_4353155c PS2, Line 99: : 0)); This can get quite complex when additional tests are added. We can figure that out later, though. -- To view, visit https://review.coreboot.org/c/flashrom/+/51487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc Gerrit-Change-Number: 51487 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Apr 2021 17:03:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: Make -r/-w/-v argument optional
by Daniel Campello (Code Review) 16 Apr '21

16 Apr '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52362 ) Change subject: cli_classic: Make -r/-w/-v argument optional ...................................................................... Patch Set 6: (3 comments) File flashrom.c: https://review.coreboot.org/c/flashrom/+/52362/comment/95a4d087_6ab7830f PS1, Line 1351: if ((image = fopen(filename, "rb")) == NULL) { > ``` […] Ack https://review.coreboot.org/c/flashrom/+/52362/comment/433606d3_b3cb5b0f PS1, Line 1361: : if (image_stat.st_size != (intmax_t)size) { > ``` […] Ack https://review.coreboot.org/c/flashrom/+/52362/comment/db03c03c_0f5f423d PS1, Line 1439: if ((image = fopen(filename, "wb")) == NULL) { > ``` […] Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/52362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41 Gerrit-Change-Number: 52362 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 16 Apr 2021 16:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: allow - as filename for stdin/stdout
by Jack Rosenthal (Code Review) 16 Apr '21

16 Apr '21

Attention is currently required from: Edward O'Callaghan, Daniel Campello. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52383 ) Change subject: flashrom.c: allow - as filename for stdin/stdout ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/52383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d Gerrit-Change-Number: 52383 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Apr 2021 15:16:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: allow - as filename for stdin/stdout
by Daniel Campello (Code Review) 16 Apr '21

16 Apr '21

Attention is currently required from: Jack Rosenthal. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52383 ) Change subject: flashrom.c: allow - as filename for stdin/stdout ...................................................................... Patch Set 7: (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/52383/comment/2913d44b_7ce25170 PS7, Line 152: (argv[optind][0] != '-' || argv[optind][1] == '\0') > this is still confusing to read, imo […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/52383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d Gerrit-Change-Number: 52383 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Apr 2021 15:13:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: allow - as filename for stdin/stdout
by Daniel Campello (Code Review) 16 Apr '21

16 Apr '21

Attention is currently required from: Daniel Campello. Hello build bot (Jenkins), Jack Rosenthal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52383 to look at the new patch set (#8). Change subject: flashrom.c: allow - as filename for stdin/stdout ...................................................................... flashrom.c: allow - as filename for stdin/stdout Allows - as filename for -r/-w/-v options Signed-off-by: Daniel Campello <campello(a)chromium.org> Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d --- M cli_classic.c M flashrom.c 2 files changed, 25 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/52383/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/52383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d Gerrit-Change-Number: 52383 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.c: allow - as filename for stdin/stdout
by Jack Rosenthal (Code Review) 16 Apr '21

16 Apr '21

Attention is currently required from: Daniel Campello. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52383 ) Change subject: flashrom.c: allow - as filename for stdin/stdout ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/52383/comment/5704f738_ce1d4569 PS7, Line 152: (argv[optind][0] != '-' || argv[optind][1] == '\0') this is still confusing to read, imo can you add to the comment above on line 150: ... however, - is treated as stdin/stdout, so we still strdup in this case -- To view, visit https://review.coreboot.org/c/flashrom/+/52383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d Gerrit-Change-Number: 52383 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Apr 2021 15:08:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: allow - as filename for stdin/stdout
by Daniel Campello (Code Review) 16 Apr '21

16 Apr '21

Attention is currently required from: Jack Rosenthal. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52383 ) Change subject: flashrom.c: allow - as filename for stdin/stdout ...................................................................... Patch Set 6: (6 comments) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/52383/comment/0af01bf2_389c669a PS6, Line 152: (argv[optind][0] != '-' || argv[optind][1] == '\0') > !strcmp(argv[optind], "-") would be slightly easier to read, IMO This is meant to say "and arg[v] does not start with - or if it does it is only '-'" as if it is -something then it is another flag... File flashrom.c: https://review.coreboot.org/c/flashrom/+/52383/comment/db1cc690_f572ae48 PS6, Line 1351: strncmp(filename, "-", sizeof("-"))) > strncmp here is analagous to "starts with" […] strncmp is considered safer but in this case I think strcmp is fine... https://review.coreboot.org/c/flashrom/+/52383/comment/8b91dd90_eb0490f7 PS6, Line 1352: fdopen(STDIN_FILENO, "rb") > stdin fileno(stdin) https://review.coreboot.org/c/flashrom/+/52383/comment/af074596_492314a6 PS6, Line 1367: (strncmp(filename, "-", sizeof("-")))) > same comment as above Done https://review.coreboot.org/c/flashrom/+/52383/comment/b9542348_17bea525 PS6, Line 1444: trncmp(filename, "-", sizeof("-"))) > ditto, I don't think we want all files that start with - to act this way Ack https://review.coreboot.org/c/flashrom/+/52383/comment/95bce580_6876143d PS6, Line 1445: fdopen(STDOUT_FILENO, "wb") > stdout fileno(stdout) -- To view, visit https://review.coreboot.org/c/flashrom/+/52383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d Gerrit-Change-Number: 52383 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Apr 2021 14:56:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: allow - as filename for stdin/stdout
by Daniel Campello (Code Review) 16 Apr '21

16 Apr '21

Attention is currently required from: Daniel Campello. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52383 to look at the new patch set (#7). Change subject: flashrom.c: allow - as filename for stdin/stdout ...................................................................... flashrom.c: allow - as filename for stdin/stdout Allows - as filename for -r/-w/-v options Signed-off-by: Daniel Campello <campello(a)chromium.org> Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d --- M cli_classic.c M flashrom.c 2 files changed, 22 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/52383/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/52383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d Gerrit-Change-Number: 52383 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2021