April 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: cli_classic: prevent corruption of flash when stdout/stderr is closed
by Nico Huber (Code Review) 18 Apr '21

18 Apr '21

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52215 ) Change subject: cli_classic: prevent corruption of flash when stdout/stderr is closed ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > BTW, it looks like I don't have submit permissions in this repo. […] There is only a small group with submit rights. I also like to give other people time to chime in (not that much time usually). But don't worry, your patch won't be forgotten. -- To view, visit https://review.coreboot.org/c/flashrom/+/52215 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I751c9dd88ad1d30283b94bd2185b4f8f25569c8f Gerrit-Change-Number: 52215 Gerrit-PatchSet: 3 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 18 Apr 2021 10:02:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: cli_classic: prevent corruption of flash when stdout/stderr is closed
by Nico Huber (Code Review) 18 Apr '21

18 Apr '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52215 ) Change subject: cli_classic: prevent corruption of flash when stdout/stderr is closed ...................................................................... cli_classic: prevent corruption of flash when stdout/stderr is closed While it's not posixly-correct, it's possible that a user, script, or application may attempt to start flashrom with stdout or stderr closed. It's possible that we'll get a file descriptor of 1 or 2 when opening a flash device (such as Linux MTD), and flashrom will send garbage debug logs to the flash: # bash -c "exec >&- flashrom ..." Observed corruption: 43 40 45 42 45 44 00 00 00 00 00 00 01 00 00 00 |C@EBED..........| 00 02 00 00 63 65 73 73 66 75 6c 6c 79 0a 46 6f |....cessfully.Fo| 75 6e 64 20 50 72 6f 67 72 61 6d 6d 65 72 20 66 |und Programmer f| 6c 61 73 68 20 63 68 69 70 20 22 4f 70 61 71 75 |lash chip "Opaqu| 65 20 66 6c 61 73 68 20 63 68 69 70 22 20 28 38 |e flash chip" (8| 31 39 32 20 6b 42 2c 20 50 72 6f 67 72 61 6d 6d |192 kB, Programm| 65 72 2d 73 70 65 63 69 66 69 63 29 20 6d 61 70 |er-specific) map| 70 65 64 20 61 74 20 70 68 79 73 69 63 61 6c 20 |ped at physical | 61 64 64 72 65 73 73 20 30 78 30 30 30 30 30 30 |address 0x000000| 30 30 2e 0a ff ff ff ff ff ff ff ff ff ff ff ff |00..............| ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................| ... While for most applications, closing stdout or stderr would just lead to obsure bugs, for flashrom, we should have extra safety guards, as this could mean that we might be bricking a device instead. Add a basic safety check. Signed-off-by: Jack Rosenthal <jrosenth(a)chromium.org> Change-Id: I751c9dd88ad1d30283b94bd2185b4f8f25569c8f Reviewed-on: https://review.coreboot.org/c/flashrom/+/52215 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M cli_classic.c 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/cli_classic.c b/cli_classic.c index 3dbaec2..3160d76 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -22,6 +22,7 @@ #include <fcntl.h> #include <sys/stat.h> #include <string.h> +#include <stdbool.h> #include <stdlib.h> #include <getopt.h> #include "flash.h" @@ -110,6 +111,18 @@ return 0; } +/* Ensure a file is open by means of fstat */ +static bool check_file(FILE *file) +{ +#ifndef STANDALONE + struct stat statbuf; + + if (fstat(fileno(file), &statbuf) < 0) + return false; +#endif /* !STANDALONE */ + return true; +} + static int parse_wp_range(unsigned int *start, unsigned int *len) { char *endptr = NULL, *token = NULL; @@ -219,7 +232,16 @@ struct layout_include_args *include_args = NULL; char *wp_mode_opt = NULL; - flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); + /* + * Safety-guard against a user who has (mistakenly) closed + * stdout or stderr before exec'ing flashrom. We disable + * logging in this case to prevent writing log data to a flash + * chip when a flash device gets opened with fd 1 or 2. + */ + if (check_file(stdout) && check_file(stderr)) { + flashrom_set_log_callback( + (flashrom_log_callback *)&flashrom_print_cb); + } print_version(); print_banner(); -- To view, visit https://review.coreboot.org/c/flashrom/+/52215 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I751c9dd88ad1d30283b94bd2185b4f8f25569c8f Gerrit-Change-Number: 52215 Gerrit-PatchSet: 3 Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashrom.c: automatic generated programmer_enum.h
by Nico Huber (Code Review) 17 Apr '21

17 Apr '21

Attention is currently required from: Sam McNally, Xiang Wang, Stefan Reinauer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 ) Change subject: flashrom.c: automatic generated programmer_enum.h ...................................................................... Patch Set 6: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/49599/comment/1bc73921_ce34e1a3 PS4, Line 681: $(shell bash ./util/generator_programmer_enum.sh) > Please guide me how to modify the Makefile, and meson. […] Sorry for the delay. I don't have much time and some effort the rework the list has already been started: CB:51925. I can give you a brief overview wrt. to Make. But I don't know about Meson. Makefiles specify rules to create files. The syntax is roughly: target_file: dependency_file_1 dependency_file_2 etc # recipe: a shell script to create the file, e.g. cat dependency_file_1 dependency_file_2 >target_file The recipe is always indented with a tab. Each line is run in a shell and only if the shell's return value is 0, Make continues. Now if Make is supposed to create the `target_file`, it would first check for the presence of the dependency files. If there are rules for these files too, they would be checked first and so on. If `target_file` already exists, the recipe will only be executed if any of the dependency files have a newer timestamp than the `target_file`. In case of this patch, you want to create a file `programmer_enum.h` and you know that its contents depend on `programmer_table.c`, so you would write it like this: programmer_enum.h: programmer_table.c ./util/generator_programmer_enum.sh Now to let Make know that `programmer_enum.h` needs to be created or updated, for all the files that (potentially) #include it, you need to add `programmer_enum.h` to the dependency list. This could be done for each file individually, e.g. flashrom.o: programmer_enum.h Or for all `.o` files at once: There is a rule below that says %.o: %.c .features Which means all `.o` files depend on their respective `.c` files plus `.features`. It could be changed to: %.o: %.c .features programmer_enum.h -- To view, visit https://review.coreboot.org/c/flashrom/+/49599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2 Gerrit-Change-Number: 49599 Gerrit-PatchSet: 6 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Xiang Wang <wxjstz(a)126.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Apr 2021 22:14:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Xiang Wang <wxjstz(a)126.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support
by Daniel Campello (Code Review) 17 Apr '21

17 Apr '21

Attention is currently required from: Sam McNally, Nico Huber, Nicola Corna, Jack Rosenthal, Paul Menzel, Stefan Reinauer, David Hendricks, Arthur Heymans, Carl-Daniel Hailfinger. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23021 ) Change subject: layout: Add -i <region>[:<file>] support ...................................................................... Patch Set 33: (1 comment) File layout.c: https://review.coreboot.org/c/flashrom/+/23021/comment/a6dddc75_bb65cf37 PS33, Line 127: name = colon ? strndup(arg, colon - arg) : strdup(arg); : file = colon ? strdup(colon + 1) : NULL; > imo, would be cleaner as […] Personally, when I wrote this, I debated between the two options and I think that the current form is better fit to convey that both `name` and `file` are initialized after that point. -- To view, visit https://review.coreboot.org/c/flashrom/+/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 33 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nicola Corna <nicola(a)corna.info> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Comment-Date: Sat, 17 Apr 2021 16:38:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Disable libusb-dependent Raiden on DOS
by Angel Pons (Code Review) 17 Apr '21

17 Apr '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52474 ) Change subject: Makefile: Disable libusb-dependent Raiden on DOS ...................................................................... Makefile: Disable libusb-dependent Raiden on DOS DOS (DJGPP 6.1.0) has no USB support. Change-Id: I36ee1edfb0e5b8d4e2b099c0f7f8aac64ed7884f Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M Makefile 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/52474/1 diff --git a/Makefile b/Makefile index 0cfff55..d496a9a 100644 --- a/Makefile +++ b/Makefile @@ -202,6 +202,11 @@ else override CONFIG_CH341A_SPI = no endif +ifeq ($(CONFIG_RAIDEN_DEBUG_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_RAIDEN_DEBUG_SPI=yes +else +override CONFIG_RAIDEN_DEBUG_SPI = no +endif ifeq ($(CONFIG_STLINKV3_SPI), yes) UNSUPPORTED_FEATURES += CONFIG_STLINKV3_SPI=yes else -- To view, visit https://review.coreboot.org/c/flashrom/+/52474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I36ee1edfb0e5b8d4e2b099c0f7f8aac64ed7884f Gerrit-Change-Number: 52474 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: s25f.c: Fix mismatched function definitions
by Angel Pons (Code Review) 17 Apr '21

17 Apr '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52473 ) Change subject: s25f.c: Fix mismatched function definitions ...................................................................... s25f.c: Fix mismatched function definitions This was missed because `uint32_t` is `unsigned int` in most cases. However, it is not the case for DJGPP 6.1.0 for some reason. Change-Id: I656a72b85d4c70b57f6ff9268186a4a60933f8a9 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M s25f.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/52473/1 diff --git a/s25f.c b/s25f.c index 32af53e..2fba6bc 100644 --- a/s25f.c +++ b/s25f.c @@ -237,8 +237,7 @@ return ret; } -int s25fs_block_erase_d8(struct flashctx *flash, - uint32_t addr, uint32_t blocklen) +int s25fs_block_erase_d8(struct flashctx *flash, unsigned int addr, unsigned int blocklen) { static int cr3nv_checked = 0; @@ -301,8 +300,7 @@ return s25f_poll_status(flash); } -int s25fl_block_erase(struct flashctx *flash, - uint32_t addr, uint32_t blocklen) +int s25fl_block_erase(struct flashctx *flash, unsigned int addr, unsigned int blocklen) { struct spi_command erase_cmds[] = { { -- To view, visit https://review.coreboot.org/c/flashrom/+/52473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I656a72b85d4c70b57f6ff9268186a4a60933f8a9 Gerrit-Change-Number: 52473 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Use singular they to refer to "the user" in comments
by Angel Pons (Code Review) 17 Apr '21

17 Apr '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52472 ) Change subject: Use singular they to refer to "the user" in comments ...................................................................... Use singular they to refer to "the user" in comments Change-Id: I726006fe2c1780361bdf6f9a1ddd84da0733642d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M dmi.c M libflashrom.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/52472/1 diff --git a/dmi.c b/dmi.c index 3b717cd..55edb03 100644 --- a/dmi.c +++ b/dmi.c @@ -184,7 +184,7 @@ * is invalid, but we cannot reliably locate the next entry. * - If the length value indicates that this structure spreads * across the table border, something is fishy too. - * Better stop at this point, and let the user know his/her + * Better stop at this point, and let the user know their * table is broken. */ if (data[1] < 4 || data + data[1] >= limit) { diff --git a/libflashrom.c b/libflashrom.c index ae2d33d..23358c9 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -65,7 +65,7 @@ } /* TODO: flashrom_set_loglevel()? do we need it? - For now, let the user decide in his callback. */ + For now, let the user decide in their callback. */ /** * @brief Set the log callback function. -- To view, visit https://review.coreboot.org/c/flashrom/+/52472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I726006fe2c1780361bdf6f9a1ddd84da0733642d Gerrit-Change-Number: 52472 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ft2232_spi.c: Fix typo in comment
by Angel Pons (Code Review) 17 Apr '21

17 Apr '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52471 ) Change subject: ft2232_spi.c: Fix typo in comment ...................................................................... ft2232_spi.c: Fix typo in comment his ---> this Change-Id: Ibcc04a1581b3ba0dcd86e6f900c146823ebcd84a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M ft2232_spi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/52471/1 diff --git a/ft2232_spi.c b/ft2232_spi.c index 662dca5..bdc6e37 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -27,7 +27,7 @@ #include <ftdi.h> /* This is not defined in libftdi.h <0.20 (c7e4c09e68cfa6f5e112334aa1b3bb23401c8dc7 to be exact). - * Some tests indicate that his is the only change that it is needed to support the FT232H in flashrom. */ + * Some tests indicate that this is the only change that it is needed to support the FT232H in flashrom. */ #if !defined(HAVE_FT232H) #define TYPE_232H 6 #endif -- To view, visit https://review.coreboot.org/c/flashrom/+/52471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibcc04a1581b3ba0dcd86e6f900c146823ebcd84a Gerrit-Change-Number: 52471 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: hwaccess.c: Fix PowerPC memory barrier
by Angel Pons (Code Review) 17 Apr '21

17 Apr '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52470 ) Change subject: hwaccess.c: Fix PowerPC memory barrier ...................................................................... hwaccess.c: Fix PowerPC memory barrier Use `__asm__ __volatile__` as done in the Linux kernel. Also update rotten link. Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M hwaccess.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/52470/1 diff --git a/hwaccess.c b/hwaccess.c index 48ccb34..da69076 100644 --- a/hwaccess.c +++ b/hwaccess.c @@ -70,8 +70,8 @@ * * See also https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Docume… */ -#if IS_PPC // cf. http://lxr.free-electrons.com/source/arch/powerpc/include/asm/barrier.h - asm("eieio" : : : "memory"); +#if IS_PPC // cf. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arc… + __asm__ __volatile__ ("eieio" : : : "memory"); #elif IS_SPARC #if defined(__sparc_v9__) || defined(__sparcv9) /* Sparc V9 CPUs support three different memory orderings that range from x86-like TSO to PowerPC-like -- To view, visit https://review.coreboot.org/c/flashrom/+/52470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b Gerrit-Change-Number: 52470 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support
by Jack Rosenthal (Code Review) 17 Apr '21

17 Apr '21

Attention is currently required from: Sam McNally, Nico Huber, Nicola Corna, Paul Menzel, Stefan Reinauer, David Hendricks, Daniel Campello, Arthur Heymans, Carl-Daniel Hailfinger. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23021 ) Change subject: layout: Add -i <region>[:<file>] support ...................................................................... Patch Set 33: Code-Review+1 (1 comment) File layout.c: https://review.coreboot.org/c/flashrom/+/23021/comment/50dc3467_7e54d116 PS33, Line 127: name = colon ? strndup(arg, colon - arg) : strdup(arg); : file = colon ? strdup(colon + 1) : NULL; imo, would be cleaner as if (colon) { name = ... file = ... } else { name = ... file = ... } -- To view, visit https://review.coreboot.org/c/flashrom/+/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 33 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nicola Corna <nicola(a)corna.info> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Comment-Date: Sat, 17 Apr 2021 13:47:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2021