February 2021 - flashrom-gerrit

Change in flashrom[master]: flashchips: Mark Macronix MX25L1635D as tested
by Nico Huber (Code Review) 07 Feb '21

07 Feb '21

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, David Hendricks, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49489 ) Change subject: flashchips: Mark Macronix MX25L1635D as tested ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/49489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7421b7e36e687ea2ffff494c00157976db73ac43 Gerrit-Change-Number: 49489 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 07 Feb 2021 15:28:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix building with musl libc
by Evgeny Zinoviev (Code Review) 07 Feb '21

07 Feb '21

Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48314 ) Change subject: Fix building with musl libc ...................................................................... Fix building with musl libc AFAIK, this shouldn't break anything, as glibc just includes fcntl.h from sys/fcntl.h. Change-Id: Ie74ae584619ae8cbc188855aedcf5596d7afcfc8 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io> --- M i2c_helper_linux.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/48314/1 diff --git a/i2c_helper_linux.c b/i2c_helper_linux.c index 0703518..5c191f9 100644 --- a/i2c_helper_linux.c +++ b/i2c_helper_linux.c @@ -17,7 +17,7 @@ #include <errno.h> #include <stdio.h> #include <string.h> -#include <sys/fcntl.h> +#include <fcntl.h> #include <sys/ioctl.h> #include <unistd.h> -- To view, visit https://review.coreboot.org/c/flashrom/+/48314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie74ae584619ae8cbc188855aedcf5596d7afcfc8 Gerrit-Change-Number: 48314 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-MessageType: newchange

3 3

Change in flashrom[master]: flashchips: add definition of the XT25F02E SPI NOR flash
by Angel Pons (Code Review) 05 Feb '21

05 Feb '21

Attention is currently required from: Neil Armstrong. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50263 ) Change subject: flashchips: add definition of the XT25F02E SPI NOR flash ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/50263/comment/820d81f7_8ef98ea1 PS1, Line 19242: TEST_UNTESTED > It has been tested with https://review.coreboot. […] If it works properly, then I'd mark it as tested. -- To view, visit https://review.coreboot.org/c/flashrom/+/50263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Gerrit-Change-Number: 50263 Gerrit-PatchSet: 2 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Comment-Date: Fri, 05 Feb 2021 22:32:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Neil Armstrong <narmstrong(a)baylibre.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: VIA VL805 SPI Flash Bus support
by Neil Armstrong (Code Review) 04 Feb '21

04 Feb '21

Attention is currently required from: jmorrison(a)bogomips.com, Carl-Daniel Hailfinger. Neil Armstrong has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50264 ) Change subject: VIA VL805 SPI Flash Bus support ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > I emailed the log - did it come through? It says it's too big to attach in a reply yes I received it, thanks -- To view, visit https://review.coreboot.org/c/flashrom/+/50264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7439d31cdf5a2174dd27b9dbe5de24ad64963334 Gerrit-Change-Number: 50264 Gerrit-PatchSet: 6 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: jmorrison(a)bogomips.com Gerrit-Attention: jmorrison(a)bogomips.com Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Comment-Date: Thu, 04 Feb 2021 20:01:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Neil Armstrong <narmstrong(a)baylibre.com> Comment-In-Reply-To: jmorrison(a)bogomips.com Gerrit-MessageType: comment

1 0

Change in flashrom[master]: VIA VL805 SPI Flash Bus support
by Name of user not set (Code Review) 04 Feb '21

04 Feb '21

Attention is currently required from: Neil Armstrong, Carl-Daniel Hailfinger. jmorrison(a)bogomips.com has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50264 ) Change subject: VIA VL805 SPI Flash Bus support ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Great ! Could you share the log ? I emailed the log - did it come through? It says it's too big to attach in a reply -- To view, visit https://review.coreboot.org/c/flashrom/+/50264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7439d31cdf5a2174dd27b9dbe5de24ad64963334 Gerrit-Change-Number: 50264 Gerrit-PatchSet: 6 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: jmorrison(a)bogomips.com Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Comment-Date: Thu, 04 Feb 2021 19:53:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Neil Armstrong <narmstrong(a)baylibre.com> Comment-In-Reply-To: jmorrison(a)bogomips.com Gerrit-MessageType: comment

1 0

Change in flashrom[master]: VIA VL805 SPI Flash Bus support
by Neil Armstrong (Code Review) 04 Feb '21

04 Feb '21

Attention is currently required from: jmorrison(a)bogomips.com, Carl-Daniel Hailfinger. Neil Armstrong has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50264 ) Change subject: VIA VL805 SPI Flash Bus support ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Working! […] Great ! Could you share the log ? -- To view, visit https://review.coreboot.org/c/flashrom/+/50264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7439d31cdf5a2174dd27b9dbe5de24ad64963334 Gerrit-Change-Number: 50264 Gerrit-PatchSet: 6 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: jmorrison(a)bogomips.com Gerrit-Attention: jmorrison(a)bogomips.com Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Comment-Date: Thu, 04 Feb 2021 17:06:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jmorrison(a)bogomips.com Gerrit-MessageType: comment

1 0

Change in flashrom[master]: VIA VL805 SPI Flash Bus support
by Name of user not set (Code Review) 04 Feb '21

04 Feb '21

Attention is currently required from: Neil Armstrong, Carl-Daniel Hailfinger. Name of user not set #1003338 has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50264 ) Change subject: VIA VL805 SPI Flash Bus support ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: Working! flashrom unknown on Linux 4.15.0-130-generic (x86_64) flashrom was built with libpci 3.5.2, GCC 7.5.0, little endian Command line (7 args): ./flashrom -VV --programmer vl805 -r test.img -o test.log Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Initializing vl805 programmer Found "VIA VL805" (1106:3483, BDF 01:00.0). -- To view, visit https://review.coreboot.org/c/flashrom/+/50264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7439d31cdf5a2174dd27b9dbe5de24ad64963334 Gerrit-Change-Number: 50264 Gerrit-PatchSet: 6 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: Name of user not set #1003338 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Attention: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Comment-Date: Thu, 04 Feb 2021 16:40:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
by Angel Pons (Code Review) 04 Feb '21

04 Feb '21

Attention is currently required from: Shiyu Sun, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 ) Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49785/comment/076eabd5_4e1ff7cc PS2, Line 9: Gpio 88 toggle is used as write protection disable/enable now : and we need that to happen at the initialization of programmer. > Since Shiyu is unavailable and this seems to fix a bug where 'Block protection could not be disabled […] Alright. Since flashrom patches can be submitted even when there are unresolved comments, let's keep this comment as unresolved until we get a reply from Shiyu. -- To view, visit https://review.coreboot.org/c/flashrom/+/49785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1 Gerrit-Change-Number: 49785 Gerrit-PatchSet: 3 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sam McNally <sammc(a)google.com> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Feb 2021 09:34:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
by Sam McNally (Code Review) 04 Feb '21

04 Feb '21

Attention is currently required from: Shiyu Sun, Edward O'Callaghan, Angel Pons. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 ) Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49785/comment/b02671a7_597f8e6f PS3, Line 12: BUG=b:147402710,b:152558985 Add b:178766553 -- To view, visit https://review.coreboot.org/c/flashrom/+/49785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1 Gerrit-Change-Number: 49785 Gerrit-PatchSet: 3 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sam McNally <sammc(a)google.com> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 04 Feb 2021 02:57:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
by Edward O'Callaghan (Code Review) 04 Feb '21

04 Feb '21

Attention is currently required from: Shiyu Sun, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 ) Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/49785/comment/a1bd8518_3c50fa7b PS2, Line 9: Gpio 88 toggle is used as write protection disable/enable now : and we need that to happen at the initialization of programmer. > Happy to +2 this however I still would like to see a better explanation as to why. Since Shiyu is unavailable and this seems to fix a bug where 'Block protection could not be disabled' I think we can accept this and press forwards. -- To view, visit https://review.coreboot.org/c/flashrom/+/49785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1 Gerrit-Change-Number: 49785 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shiyu Sun <sshiyu(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 04 Feb 2021 02:43:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2021