zapb has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48379 )
Change subject: jlink_spi: Reduce transfer size ......................................................................
jlink_spi: Reduce transfer size
The maximum transfer size is too large for some devices and results in an USB timeout.
Change-Id: If2c00b1524ec56740bdfe290096c3546cf375d73 Signed-off-by: Marc Schink dev@zapb.de --- M jlink_spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/48379/1
diff --git a/jlink_spi.c b/jlink_spi.c index 36611bf..3a73c01 100644 --- a/jlink_spi.c +++ b/jlink_spi.c @@ -34,7 +34,7 @@ * Maximum number of bytes that can be transferred at once via the JTAG * interface, see jaylink_jtag_io(). */ -#define JTAG_MAX_TRANSFER_SIZE (UINT16_MAX / 8) +#define JTAG_MAX_TRANSFER_SIZE (32768 / 8)
/* * Default base frequency in Hz. Used when the base frequency can not be
Attention is currently required from: zapb, Miklós Márton. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48379 )
Change subject: jlink_spi: Reduce transfer size ......................................................................
Patch Set 1: Code-Review+1
Attention is currently required from: zapb. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48379 )
Change subject: jlink_spi: Reduce transfer size ......................................................................
Patch Set 1: Code-Review+2
Attention is currently required from: zapb. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48379 )
Change subject: jlink_spi: Reduce transfer size ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48379 )
Change subject: jlink_spi: Reduce transfer size ......................................................................
jlink_spi: Reduce transfer size
The maximum transfer size is too large for some devices and results in an USB timeout.
Change-Id: If2c00b1524ec56740bdfe290096c3546cf375d73 Signed-off-by: Marc Schink dev@zapb.de Reviewed-on: https://review.coreboot.org/c/flashrom/+/48379 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Miklós Márton martonmiklosqdev@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M jlink_spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Miklós Márton: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/jlink_spi.c b/jlink_spi.c index 36611bf..3a73c01 100644 --- a/jlink_spi.c +++ b/jlink_spi.c @@ -34,7 +34,7 @@ * Maximum number of bytes that can be transferred at once via the JTAG * interface, see jaylink_jtag_io(). */ -#define JTAG_MAX_TRANSFER_SIZE (UINT16_MAX / 8) +#define JTAG_MAX_TRANSFER_SIZE (32768 / 8)
/* * Default base frequency in Hz. Used when the base frequency can not be
-
Angel Pons (Code Review) -
Miklós Márton (Code Review)
-
zapb (Code Review)