February 2021 - flashrom-gerrit

Change in flashrom[master]: flashrom.c: Fix 4BA for non SPI masters
by Edward O'Callaghan (Code Review) 03 Feb '21

03 Feb '21

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/50245 ) Change subject: flashrom.c: Fix 4BA for non SPI masters ...................................................................... flashrom.c: Fix 4BA for non SPI masters Chips that indicate they support 4BA in their feature flags break horribly as the current 4BA support assumes a SPI master bus in spi_master_no_4ba_modes() by dereferencing flash->mst.spi in the mst union type. BUG=b:178419441,b:177252170 TEST=<needed> Change-Id: Ieb59d9d69d5b4f5c1e5aac424898e94c9fe3790b Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c M programmer.h 2 files changed, 13 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/50245/1 diff --git a/flashrom.c b/flashrom.c index c89abad..c1438c9 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2287,12 +2287,14 @@ flash->chip_restore_fn_count = 0; /* Be careful about 4BA chips and broken masters */ - if (flash->chip->total_size > 16 * 1024 && spi_master_no_4ba_modes(flash)) { - /* If we can't use native instructions, bail out */ - if ((flash->chip->feature_bits & FEATURE_4BA_NATIVE) != FEATURE_4BA_NATIVE - || !spi_master_4ba(flash)) { - msg_cerr("Programmer doesn't support this chip. Aborting.\n"); - return 1; + if (flash->chip->total_size > 16 * 1024 && spi_bus_no_4ba_modes(flash)) { + if (spi_master_no_4ba_modes(flash)) { + /* If we can't use native instructions, bail out */ + if ((flash->chip->feature_bits & FEATURE_4BA_NATIVE) != FEATURE_4BA_NATIVE + || !spi_master_4ba(flash)) { + msg_cerr("Programmer doesn't support this chip. Aborting.\n"); + return 1; + } } } diff --git a/programmer.h b/programmer.h index 29a100b..b575a72 100644 --- a/programmer.h +++ b/programmer.h @@ -820,8 +820,11 @@ } static inline bool spi_master_no_4ba_modes(const struct flashctx *const flash) { - return flash->mst->buses_supported & BUS_SPI && - flash->mst->spi.features & SPI_MASTER_NO_4BA_MODES; + return flash->mst->spi.features & SPI_MASTER_NO_4BA_MODES; +} +static inline bool spi_bus_no_4ba_modes(const struct flashctx *const flash) +{ + return flash->mst->buses_supported & BUS_SPI; } /* usbdev.c */ -- To view, visit https://review.coreboot.org/c/flashrom/+/50245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb59d9d69d5b4f5c1e5aac424898e94c9fe3790b Gerrit-Change-Number: 50245 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Hung-Te Lin (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Douglas Anderson, Edward O'Callaghan, Angel Pons, Patrick Rudolph. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 ) Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 1 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 23:46:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Hung-Te Lin (Code Review) 02 Feb '21

02 Feb '21

Attention is currently required from: Douglas Anderson, Edward O'Callaghan, Angel Pons, Patrick Rudolph. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 ) Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 1 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 23:45:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Douglas Anderson (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Hung-Te Lin, Edward O'Callaghan, Angel Pons, Patrick Rudolph. Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 ) Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Posted as requested by Hung-Te in <https://review.coreboot.org/c/flashrom/+/50155>. This should have no impact at all other than just using the lower level API. Hopefully someone can help test this? I tested it downstream, but it looks like Chrome OS still has some forked changes from upstream. Specifically there's a bunch of write protect stuff in that file downstream. Luckily it as easy to just drop that part of the patch that touched the missing code, but I'd still appreciate any testing. I'm a bit of a visitor in flashrom and I don't have a great way to test upstream. -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 1 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 22:43:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: Disable buffering on the mtd device
by Douglas Anderson (Code Review) 01 Feb '21

01 Feb '21

Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50155 ) Change subject: linux_mtd: Disable buffering on the mtd device ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > In the meantime, will it make more sense if we change fopen to open > for MTD device files? OK, I posted this here <https://review.coreboot.org/c/flashrom/+/50206>. -- To view, visit https://review.coreboot.org/c/flashrom/+/50155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I989afd83a33013b2756a0090d6b08245613215c6 Gerrit-Change-Number: 50155 Gerrit-PatchSet: 3 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 22:41:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices
by Douglas Anderson (Code Review) 01 Feb '21

01 Feb '21

Douglas Anderson has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/50206 ) Change subject: linux_mtd: Switch fopen() to open() for MTD devices ...................................................................... linux_mtd: Switch fopen() to open() for MTD devices There's no benefit to using the higher level "FILE *" for file operations for writing to mtd devices. Let's move to the lower level ones which matches the kernel more closely. Signed-off-by: Douglas Anderson <dianders(a)chromium.org> Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d --- M linux_mtd.c 1 file changed, 16 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/50206/1 diff --git a/linux_mtd.c b/linux_mtd.c index 22702e9..0af0c0b 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -31,7 +31,7 @@ #define LINUX_DEV_ROOT "/dev" #define LINUX_MTD_SYSFS_ROOT "/sys/class/mtd" -static FILE *dev_fp = NULL; +static int dev_fileno = -1; static int mtd_device_is_writeable; @@ -189,7 +189,7 @@ unsigned int eb_size = flash->chip->block_erasers[0].eraseblocks[0].size; unsigned int i; - if (fseek(dev_fp, start, SEEK_SET) != 0) { + if (lseek(dev_fileno, start, SEEK_SET) == (off_t)-1) { msg_perr("Cannot seek to 0x%06x: %s\n", start, strerror(errno)); return 1; } @@ -203,7 +203,7 @@ unsigned int step = eb_size - ((start + i) % eb_size); step = min(step, len - i); - if (fread(buf + i, step, 1, dev_fp) != 1) { + if (read(dev_fileno, buf + i, step) != step) { msg_perr("Cannot read 0x%06x bytes at 0x%06x: %s\n", step, start + i, strerror(errno)); return 1; @@ -225,7 +225,7 @@ if (!mtd_device_is_writeable) return 1; - if (fseek(dev_fp, start, SEEK_SET) != 0) { + if (lseek(dev_fileno, start, SEEK_SET) == (off_t)-1) { msg_perr("Cannot seek to 0x%06x: %s\n", start, strerror(errno)); return 1; } @@ -240,15 +240,17 @@ unsigned int step = chunksize - ((start + i) % chunksize); step = min(step, len - i); - if (fwrite(buf + i, step, 1, dev_fp) != 1) { + if (write(dev_fileno, buf + i, step) != step) { msg_perr("Cannot write 0x%06x bytes at 0x%06x\n", step, start + i); return 1; } - if (fflush(dev_fp) == EOF) { - msg_perr("Failed to flush buffer: %s\n", strerror(errno)); - return 1; - } + /* + * MTD layer on Linux doesn't implement flush so the next call + * is expected to return an error. We'll still call it just + * in case it's ever useful. + */ + fsync(dev_fileno); i += step; } @@ -280,7 +282,7 @@ .length = mtd_erasesize, }; - if (ioctl(fileno(dev_fp), MEMERASE, &erase_info) == -1) { + if (ioctl(dev_fileno, MEMERASE, &erase_info) == -1) { msg_perr("%s: ioctl: %s\n", __func__, strerror(errno)); return 1; } @@ -336,13 +338,10 @@ goto linux_mtd_setup_exit; /* open file stream and go! */ - if ((dev_fp = fopen(dev_path, "r+")) == NULL) { + if ((dev_fileno = open(dev_path, O_RDWR)) == -1) { msg_perr("Cannot open file stream for %s\n", dev_path); goto linux_mtd_setup_exit; } - ret = setvbuf(dev_fp, NULL, _IONBF, 0); - if (ret) - msg_pwarn("Failed to set MTD device to unbuffered: %d\n", ret); msg_pinfo("Opened %s successfully\n", dev_path); @@ -353,9 +352,9 @@ static int linux_mtd_shutdown(void *data) { - if (dev_fp != NULL) { - fclose(dev_fp); - dev_fp = NULL; + if (dev_fileno != -1) { + close(dev_fileno); + dev_fileno = -1; } return 0; -- To view, visit https://review.coreboot.org/c/flashrom/+/50206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d Gerrit-Change-Number: 50206 Gerrit-PatchSet: 1 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: linux_mtd: Disable buffering on the mtd device
by Angel Pons (Code Review) 01 Feb '21

01 Feb '21

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/50155 ) Change subject: linux_mtd: Disable buffering on the mtd device ...................................................................... linux_mtd: Disable buffering on the mtd device We open the device node for the MTD device with this: dev_fp = fopen(dev_path, "r+") In C fopen() is allowed to provide _buffered_ access to the file. That means that the standard library is allowed to read ahead and/or return cached data. That's really not what we want for something like this. Let's turn it off. This fixes a problem where flashrom would sometimes fail to "verify" that it erased the flash. The error message would look something like this: Erasing and writing flash chip... FAILED at 0x0000e220! Expected=0xff, Found=0xe9, failed byte count from 0x0000e200-0x0000e2ff: 0xdc failed byte count from 0x0000e000-0x0000efff: 0xffffffff ERASE_FAILED FAILED! Uh oh. Erase/write failed. Checking if anything changed. After the failure I could read the flash device with a new invocation of flashrom and I would see that, indeed, the erase had worked. Tracing in the kernel showed that when the failure happened we saw a pattern that looked like this: * Read 0x0b00 bytes starting at 0x0000d000 * Read 0x1000 bytes starting at 0x0000db00 * Erase 0x1000 bytes starting at 0x0000e000 ...and then there was _not_ a read after the erase. It can be assumed that, since userspace had already read 0xdb00 - 0xeaff that it was looking at old buffered data after the erase. Signed-off-by: Douglas Anderson <dianders(a)chromium.org> Change-Id: I989afd83a33013b2756a0090d6b08245613215c6 Reviewed-on: https://review.coreboot.org/c/flashrom/+/50155 Reviewed-by: Hung-Te Lin <hungte(a)chromium.org> Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M linux_mtd.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, approved Hung-Te Lin: Looks good to me, but someone else must approve diff --git a/linux_mtd.c b/linux_mtd.c index d2df95e..22702e9 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -340,6 +340,10 @@ msg_perr("Cannot open file stream for %s\n", dev_path); goto linux_mtd_setup_exit; } + ret = setvbuf(dev_fp, NULL, _IONBF, 0); + if (ret) + msg_pwarn("Failed to set MTD device to unbuffered: %d\n", ret); + msg_pinfo("Opened %s successfully\n", dev_path); ret = 0; -- To view, visit https://review.coreboot.org/c/flashrom/+/50155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I989afd83a33013b2756a0090d6b08245613215c6 Gerrit-Change-Number: 50155 Gerrit-PatchSet: 3 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: linux_mtd: Disable buffering on the mtd device
by Angel Pons (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Hung-Te Lin, Douglas Anderson, David Hendricks, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50155 ) Change subject: linux_mtd: Disable buffering on the mtd device ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > > I'm surprised why we didn't see issues until now. […] Only developers can submit changes, but everyone is free to ask a developer to submit a change :) -- To view, visit https://review.coreboot.org/c/flashrom/+/50155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I989afd83a33013b2756a0090d6b08245613215c6 Gerrit-Change-Number: 50155 Gerrit-PatchSet: 2 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 15:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: Disable buffering on the mtd device
by Douglas Anderson (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Hung-Te Lin, David Hendricks, Edward O'Callaghan. Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50155 ) Change subject: linux_mtd: Disable buffering on the mtd device ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm surprised why we didn't see issues until now. > > In the meantime, will it make more sense if we change fopen to open for MTD device files? I can do a follow-up change since this is +2 and feels safer (touches less code). I don't seem to be setup for access to actually submit this change. Can anyone help me with that? -- To view, visit https://review.coreboot.org/c/flashrom/+/50155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I989afd83a33013b2756a0090d6b08245613215c6 Gerrit-Change-Number: 50155 Gerrit-PatchSet: 2 Gerrit-Owner: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 14:45:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix spi sequence in time and rename
by Xiang Wang (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 ) Change subject: bitbang_spi.c: fix spi sequence in time and rename ...................................................................... Patch Set 13: (2 comments) Patchset: PS13: > How do you test this? This is a timing issue, and the signal changes sent should be earlier than received. I tested it with sysfsgpio under raspberry pi zero PS13: Have anything update? -- To view, visit https://review.coreboot.org/c/flashrom/+/49264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1 Gerrit-Change-Number: 49264 Gerrit-PatchSet: 13 Gerrit-Owner: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Feb 2021 03:42:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2021