December 2021 - flashrom-gerrit

Change in flashrom[master]: libflashrom,writeprotect: add flashrom_wp_set_range()
by Nico Huber (Code Review) 17 Dec '21

17 Dec '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58482 ) Change subject: libflashrom,writeprotect: add flashrom_wp_set_range() ...................................................................... Patch Set 23: (1 comment) File writeprotect.c: https://review.coreboot.org/c/flashrom/+/58482/comment/36b36a8f_9d974dcc PS23, Line 357: Overwrite This has misled me somehow to believe that the fields that don't matter for the range (i.e. SRP) are overwritten as well. However, it seems they are implicitly maintained by get_range_cfg_pairs(). That seems like some- thing worth a comment (instead of yet another stating-the-obvious one). -- To view, visit https://review.coreboot.org/c/flashrom/+/58482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7d26f43fb05c5828b9839bb57a28fa1088dcd9a0 Gerrit-Change-Number: 58482 Gerrit-PatchSet: 23 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 17 Dec 2021 17:36:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom,writeprotect: add flashrom_wp_get_available_ranges()
by Nico Huber (Code Review) 17 Dec '21

17 Dec '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 ) Change subject: libflashrom,writeprotect: add flashrom_wp_get_available_ranges() ...................................................................... Patch Set 23: (13 comments) File libflashrom.h: https://review.coreboot.org/c/flashrom/+/58481/comment/edc2be39_ebfc32a3 PS23, Line 137: #define FLASHROM_WP_MAX_RANGES 128 Should we use dynamic allocation instead? https://review.coreboot.org/c/flashrom/+/58481/comment/4a270989_115931b3 PS23, Line 143: size_t Technically `size_t` is supposed to specify a byte count. It's often accepted as a short hand for unsigned int, but I don't think we should do that in the public API. File writeprotect.c: https://review.coreboot.org/c/flashrom/+/58481/comment/91ee1087_a5ad6241 PS23, Line 183: }; That this is actually useful (to search for a configuration) is only visible in a later commit. Please mention such things in the commit message. https://review.coreboot.org/c/flashrom/+/58481/comment/f4f84209_da0278a2 PS23, Line 187: preferred What is preferred and why? https://review.coreboot.org/c/flashrom/+/58481/comment/66979be6_a770a7f8 PS23, Line 233: TB in a OTP register Please mention the chip where you have seen something like this. Sometimes these things are hard to believe and you can spare future readers the pain of having to search for such a chip. https://review.coreboot.org/c/flashrom/+/58481/comment/748ce95a_a39f399e PS23, Line 234: perserved p*re*served https://review.coreboot.org/c/flashrom/+/58481/comment/2920f0e1_17ca99ca PS23, Line 237: 20 ARRAY_SIZE(bits->bp) + 1 /* TB */ + 1 /* SEC */ + 1 /* CMP */ ? https://review.coreboot.org/c/flashrom/+/58481/comment/b22142db_0361f08d PS23, Line 240: can_write_bit(bits->bp[i]) This would stop at the first not writable bit and skip further writable ones, right? https://review.coreboot.org/c/flashrom/+/58481/comment/5c3164d5_90c55d22 PS23, Line 254: (1 << bit_count) Nit, no parentheses needed. https://review.coreboot.org/c/flashrom/+/58481/comment/61cfdedb_56d6effb PS23, Line 255: 32 Why 32? https://review.coreboot.org/c/flashrom/+/58481/comment/4417747c_54c7ec49 PS23, Line 255: for (uint32_t range_index = 0; range_index < *count; range_index++) { Please check that the destination arrays don't overflow (wouldn't be necessary if they were allocated with `*count` elements). https://review.coreboot.org/c/flashrom/+/58481/comment/cb298bd0_6d007222 PS23, Line 301: Not sure if we should use tabs here. https://review.coreboot.org/c/flashrom/+/58481/comment/0219ab50_4c4151d1 PS23, Line 308: struct wp_range_cfg_pair range_cfg_pairs[FLASHROM_WP_MAX_RANGES]; Not on the stack, please. Flashrom sometimes runs in embedded environments. -- To view, visit https://review.coreboot.org/c/flashrom/+/58481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d Gerrit-Change-Number: 58481 Gerrit-PatchSet: 23 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 17 Dec 2021 17:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: document W25Q128FV is emulated by dummyflasher
by Angel Pons (Code Review) 17 Dec '21

17 Dec '21

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/59811 ) Change subject: flashrom.8.tmpl: document W25Q128FV is emulated by dummyflasher ...................................................................... flashrom.8.tmpl: document W25Q128FV is emulated by dummyflasher It was absent from the list of emulated chips. Change-Id: I50f6cd6c5d853d6c70921e8027ada52d27982708 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/59811 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashrom.8.tmpl 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 73ad1ed..fe2d9d6 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -688,6 +688,8 @@ .sp .RB "* Macronix " MX25L6436 " SPI flash chip (8192 kB, RDID, SFDP)" .sp +.RB "* Winbond " W25Q128FV " SPI flash chip (16384 kB, RDID)" +.sp .RB "* Dummy vendor " VARIABLE_SIZE " SPI flash chip (configurable size, page write)" .sp Example: -- To view, visit https://review.coreboot.org/c/flashrom/+/59811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50f6cd6c5d853d6c70921e8027ada52d27982708 Gerrit-Change-Number: 59811 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashrom.8.tmpl: document W25Q128FV is emulated by dummyflasher
by Sergii Dmytruk (Code Review) 17 Dec '21

17 Dec '21

Attention is currently required from: Edward O'Callaghan. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59811 ) Change subject: flashrom.8.tmpl: document W25Q128FV is emulated by dummyflasher ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: While at it, this patch is ready for submission as well. -- To view, visit https://review.coreboot.org/c/flashrom/+/59811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50f6cd6c5d853d6c70921e8027ada52d27982708 Gerrit-Change-Number: 59811 Gerrit-PatchSet: 3 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Comment-Date: Fri, 17 Dec 2021 15:58:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: remove outdated warning about v1.0
by Angel Pons (Code Review) 17 Dec '21

17 Dec '21

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/59408 ) Change subject: flashrom.8.tmpl: remove outdated warning about v1.0 ...................................................................... flashrom.8.tmpl: remove outdated warning about v1.0 This section is rather outdated and should be dispensed with. Change-Id: Id7e0ce412901ccb27124a9958d5ef214ab289518 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/59408 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashrom.8.tmpl 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 989d677..73ad1ed 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -65,11 +65,6 @@ TSOP48, and BGA chips, which use various protocols such as LPC, FWH, parallel flash, or SPI. .SH OPTIONS -.B IMPORTANT: -Please note that the command line interface for flashrom will change before -flashrom 1.0. Do not use flashrom in scripts or other automated tools without -checking that your flashrom version won't interpret options in a different way. -.PP You can specify one of .BR \-h ", " \-R ", " \-L ", " \-z ", " \-E ", " \-r ", " \-w ", " \-v or no operation. -- To view, visit https://review.coreboot.org/c/flashrom/+/59408 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7e0ce412901ccb27124a9958d5ef214ab289518 Gerrit-Change-Number: 59408 Gerrit-PatchSet: 5 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashrom.8.tmpl: remove outdated warning about v1.0
by Angel Pons (Code Review) 17 Dec '21

17 Dec '21

Attention is currently required from: Edward O'Callaghan, Nico Huber, Sergii Dmytruk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59408 ) Change subject: flashrom.8.tmpl: remove outdated warning about v1.0 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Can anyone with enough permissions hit "SUBMIT" button on this? Or outdated warning will remain for […] Sure, thanks for the reminder 😊 -- To view, visit https://review.coreboot.org/c/flashrom/+/59408 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7e0ce412901ccb27124a9958d5ef214ab289518 Gerrit-Change-Number: 59408 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 17 Dec 2021 14:53:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: remove outdated warning about v1.0
by Sergii Dmytruk (Code Review) 17 Dec '21

17 Dec '21

Attention is currently required from: Edward O'Callaghan, Nico Huber. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59408 ) Change subject: flashrom.8.tmpl: remove outdated warning about v1.0 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Can anyone with enough permissions hit "SUBMIT" button on this? Or outdated warning will remain for a couple more years :) -- To view, visit https://review.coreboot.org/c/flashrom/+/59408 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7e0ce412901ccb27124a9958d5ef214ab289518 Gerrit-Change-Number: 59408 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 17 Dec 2021 13:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michał Żygowski (Code Review) 17 Dec '21

17 Dec '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... Patch Set 25: (1 comment) File ite_ecfw.c: https://review.coreboot.org/c/flashrom/+/55715/comment/714b81f5_f5607ba0 PS20, Line 332: if (blocks_1_2) { : itestring->flags.clock_source = CLOCK_SOURCE_INTERNAL; : > The datasheet also says the clock source bit should be always 1. […] Added the comment -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 25 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 17 Dec 2021 13:45:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michał Żygowski (Code Review) 17 Dec '21

17 Dec '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Nico Huber, Sergii Dmytruk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55715 to look at the new patch set (#25). Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops Add a new programmer supporting ITE Embedded Controllers found on TUXEDO laptops. Tested on TUXEDO InfinityBook S 14 Gen6 and 15 Gen6 with EC firmware updates from IBV, EC versions 1.07.02TR1 and 1.07.04TR4. Example standard command to update EC firmware on a TUXEDO laptop: "flashrom -p ite_ec:romsize=128K,autoload=disable -w eL14MU02.TR1" Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 --- M Makefile M flashrom.8.tmpl M it87spi.c A ite_ecfw.c A ite_ecfw.h M meson.build M meson_options.txt M programmer.h M programmer_table.c 9 files changed, 1,127 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/55715/25 -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 25 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michał Żygowski (Code Review) 17 Dec '21

17 Dec '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... Patch Set 24: (1 comment) File ite_ecfw.c: https://review.coreboot.org/c/flashrom/+/55715/comment/4831a1e6_b6ee3984 PS20, Line 332: if (blocks_1_2) { : itestring->flags.clock_source = CLOCK_SOURCE_INTERNAL; : > Maybe, maybe not :S Let's keep it for now but add a comment The datasheet also says the clock source bit should be always 1. The only path that selects external source is the autoload off when the flash size is larger than 128k. Maybe later we can force the internal oscillator in all paths and remove the comment... -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 24 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 17 Dec 2021 13:32:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2021