Melvyn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58774 )
Change subject: chipset_enable.c: Mark Intel Z390 as DEP
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58774/comment/c3b2de35_52bf299d
PS3, Line 12: melvyn2
> As per our Sign-off procedure [1], I'm afraid you have to use your real name here. […]
I'm not sure how I missed the bright red text there, sorry about that. That does mean I won't be able to contribute this however. In the hopes someone else can pick this up:
I release the included works into the public domain free from my own copyright to the furthest extent possible.
This probably doesn't fulfill the copyright creativity clause but might as well.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If14d45c144bb32a1d1046185d4476ea29e4d0912
Gerrit-Change-Number: 58774
Gerrit-PatchSet: 3
Gerrit-Owner: Melvyn <melvyn2(a)brcok.tk>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 05 Nov 2021 01:19:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58623 )
Change subject: Makefile: Use pkg-config to find libftdi1
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I41f5186d9f3e063c12c8c6eea888d0b0bf534259
Gerrit-Change-Number: 58623
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 04 Nov 2021 20:38:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Rob Barnes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58529 )
Change subject: sb600spi: Cleanup spispeed and spireamode warnings
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Angel, do you have the power to merge?
I do, I just need to be reminded about it 😜
--
To view, visit https://review.coreboot.org/c/flashrom/+/58529
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c
Gerrit-Change-Number: 58529
Gerrit-PatchSet: 1
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Thu, 04 Nov 2021 17:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Rob Barnes.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58529 )
Change subject: sb600spi: Cleanup spispeed and spireamode warnings
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Angel, do you have the power to merge?
--
To view, visit https://review.coreboot.org/c/flashrom/+/58529
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c
Gerrit-Change-Number: 58529
Gerrit-PatchSet: 1
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Thu, 04 Nov 2021 16:52:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Angel Pons.
Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58467 )
Change subject: flashchips.c: big erase blocksize first
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> I didn't take a look at the code, but I imagine this tries to use a full chip erase command where po […]
The clou is the condition
```
if ((block_size == flashctx->chip->total_size * 1024) && per_blockfn == &erase_block){
```
So when the block size equals the flash size it uses the biggest possible erase block size (assuming the eraseblocks are always given in ascending order).
I have never worked with a layout that´s why I didn´t test it. However in case of a given layout the "normal" way should be taken.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58467
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I862ce0b5f8912565e43c340578d8126aa2e6aa3b
Gerrit-Change-Number: 58467
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 04 Nov 2021 09:46:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Buhrow
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58480 )
Change subject: [RFC] flashchips, writeprotect_ranges: add range decoding function
......................................................................
Patch Set 8:
(2 comments)
File writeprotect_ranges.c:
https://review.coreboot.org/c/flashrom/+/58480/comment/a8a45e4e_154f4f85
PS7, Line 20: TODO
> Need new line before TODO.
Done
https://review.coreboot.org/c/flashrom/+/58480/comment/9eb84193_5f71d849
PS7, Line 91:
> Probably can remove empty line at the end? (line 91)
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/58480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id163ed80938a946a502ed116e48e8236e36eb203
Gerrit-Change-Number: 58480
Gerrit-PatchSet: 8
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Thu, 04 Nov 2021 01:27:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58479 )
Change subject: [RFC] writeprotect: add functions to read and write wp_chip_state
......................................................................
Patch Set 7:
(3 comments)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/11276b83_372f1b8d
PS6, Line 26: print_wp_chip_state
> You can move print_wp_chip_state here on the top, and avoid forward declaration.
I think it's a bit nicer to keep it with the other printing functions that get added at the bottom of the file.
Alternatively I can change it to a function that writes to a string and declare it in the header since that would be somewhat useful for wp users.
https://review.coreboot.org/c/flashrom/+/58479/comment/32435360_69c2f8c5
PS6, Line 28: static int read_reg_bit(
: const struct flashctx *flash,
: const struct reg_bit_info bit,
: uint8_t *value,
: bool *present)
> Just to check: does this not fit into 112 chars? It really helps to grep when all parameters are on […]
Done
https://review.coreboot.org/c/flashrom/+/58479/comment/7a1d6e9f_42837122
PS6, Line 73: void *suppress_unused_warning_for_read_wp_chip_state = read_wp_chip_state;
> This merely avoids a warning about the `read_wp_chip_state()` function being unused. […]
I can move the read/write functions into another commit if it really would be easier to review them that way, but they are helper functions that get used in several places so they don't really belong with any other change.
They are also quite complicated but do a well defined task so I thought it would be easier to them review them on their own.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58479
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ad25708c3321b8fb0216c3eaf6ffc07616537ad
Gerrit-Change-Number: 58479
Gerrit-PatchSet: 7
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Thu, 04 Nov 2021 01:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment