flashrom-gerrit November 2021

flashrom-gerrit@flashrom.org

1 participants
483 discussions

Change in flashrom[master]: tests: Add wraps for __xstat variants of stat
by Anastasia Klimchuk (Code Review) 01 Nov '21

01 Nov '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58103 to look at the new patch set (#4). Change subject: tests: Add wraps for __xstat variants of stat ...................................................................... tests: Add wraps for __xstat variants of stat __xstat variants of stat are invoked under chromium chroot. For all existing tests it is sufficient for stat to "do nothing, return 0", so new wraps do just that. Without this patch linux_mtd test fails under chromium chroot. BUG=b:181803212 TEST=running tests on three different environments, 1) stat64 (ninja tests in upstream tree) 2) stat64 (ninja tests in chromium tree) 2) __xstat64 (emerge with tests in chromium tree) Change-Id: I4c5c243acde09dc5bb6b2a14042fcd23a49707db Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/meson.build M tests/tests.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/58103/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/58103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4c5c243acde09dc5bb6b2a14042fcd23a49707db Gerrit-Change-Number: 58103 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: Add wraps for all variants of stat
by Anastasia Klimchuk (Code Review) 01 Nov '21

01 Nov '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58103 ) Change subject: tests: Add wraps for all variants of stat ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58103/comment/a917cdb8_c9b64ed7 PS2, Line 9: all > Yes you are right, I will do this. […] Environment this applies to: __xstat64 wrap is needed to run unit tests with emerge under chromium chroot. When I run same tests, in the same chromium tree, with meson, then stat64 is called. There was, as I understand, some change in chromium chroot recently, which caused the switch from stat64 to __xstat64, however I couldn't find what exactly has changed. Good news: "some flashrom developer" won't have a failing test locally, because this only affects people who are running tests with emerge under chromium chroot. Bad news: this affects me :( Partially, because I can work on upstream tree as usual. I will re-write commit message later today, I agree it is too vague. Did I answer your question about environment? Let me know if not! https://review.coreboot.org/c/flashrom/+/58103/comment/7e03e1f7_6d2987c4 PS2, Line 17: TEST=running tests on two different environments, : with 1) stat64 and 2) __xstat64 invoked > Yes sure, I will do this. Let's keep this comment unresolved. I looked into all potentially relevant minijail policies, could not find any recent policy change that would look like it caused switching from stat64 to __xstat64. Maybe it's not minijail. > before being sure we need this wrap Currently, anyone who wants to run unit tests with emerge under chroot, needs this wrap. I think we need it... Patchset: PS3: Sorry for delay, I was gathering info. I am back. -- To view, visit https://review.coreboot.org/c/flashrom/+/58103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4c5c243acde09dc5bb6b2a14042fcd23a49707db Gerrit-Change-Number: 58103 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Nov 2021 06:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC] writeprotect: implement wp_get_ranges()
by Nikolai Artemiev (Code Review) 01 Nov '21

01 Nov '21

Attention is currently required from: Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 ) Change subject: [RFC] writeprotect: implement wp_get_ranges() ...................................................................... Patch Set 6: (1 comment) File writeprotect.h: https://review.coreboot.org/c/flashrom/+/58481/comment/4e9ef98b_36c4fa28 PS6, Line 57: wp_get_ranges > How about renaming it to, say, `wp_list_ranges` to make it less confusing? This will separate it fro […] I previously had wp_get_available_ranges() but thought it was a bit too long. Maybe we should call it wp_get_range_list() since it's returning the list rather than printing it. -- To view, visit https://review.coreboot.org/c/flashrom/+/58481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d Gerrit-Change-Number: 58481 Gerrit-PatchSet: 6 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 01 Nov 2021 04:44:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2021