November 2021 - flashrom-gerrit

Change in flashrom[master]: tests: Add run_probe_lifecycle and use it in dummyflasher test
by Edward O'Callaghan (Code Review) 30 Nov '21

30 Nov '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59741 ) Change subject: tests: Add run_probe_lifecycle and use it in dummyflasher test ...................................................................... Patch Set 1: (1 comment) File tests/lifecycle.c: https://review.coreboot.org/c/flashrom/+/59741/comment/59ff7b54_880583e6 PS1, Line 68: "bus=spi,emulate=W25Q128FV", "W25Q128.V" this is changing the behavior of the test in a rename commit. -- To view, visit https://review.coreboot.org/c/flashrom/+/59741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9eb7fe3a436fbba5e70db957139fd26e00efec36 Gerrit-Change-Number: 59741 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Nov 2021 08:26:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Rename run_lifecycle into run_basic_lifecycle
by Edward O'Callaghan (Code Review) 30 Nov '21

30 Nov '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59740 ) Change subject: tests: Rename run_lifecycle into run_basic_lifecycle ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/59740/comment/5a0d744f_3acdb42f PS1, Line 7: basic but what does "basic" mean, seems like a bit of a spectrum of meaning? -- To view, visit https://review.coreboot.org/c/flashrom/+/59740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2771921ae2bd37f4b3f49342e03d9abb5ee36ea0 Gerrit-Change-Number: 59740 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Nov 2021 06:59:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Rename init_shutdown.c into lifecycle.c
by Edward O'Callaghan (Code Review) 30 Nov '21

30 Nov '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59739 ) Change subject: tests: Rename init_shutdown.c into lifecycle.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/59739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8d734c43cc15c7ec1055d3fb5bdcdca8c90d0987 Gerrit-Change-Number: 59739 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Nov 2021 06:58:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Set up mock chip memory in consistent and predictable way
by Anastasia Klimchuk (Code Review) 30 Nov '21

30 Nov '21

Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59237 ) Change subject: tests: Set up mock chip memory in consistent and predictable way ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/59237/comment/bdeb0fdf_5b05a38a PS3, Line 7: Setup > Set up Done. You are welcome to do a review for the rest of the chain! -- To view, visit https://review.coreboot.org/c/flashrom/+/59237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0d7623a601c207bfc62d54ab89d94cda56d85871 Gerrit-Change-Number: 59237 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 30 Nov 2021 06:55:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add tests for verify operation
by Anastasia Klimchuk (Code Review) 30 Nov '21

30 Nov '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59239 to look at the new patch set (#4). Change subject: tests: Add tests for verify operation ...................................................................... tests: Add tests for verify operation This patch adds two tests which run do_verify operation, and adds io_mock for fread. BUG=b:181803212 TEST=ninja test Change-Id: I1cc6f73f9b1e385eb963adccf20759c13a40ed3b Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/chip.c M tests/tests.c M tests/tests.h 3 files changed, 91 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/39/59239/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/59239 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1cc6f73f9b1e385eb963adccf20759c13a40ed3b Gerrit-Change-Number: 59239 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: Add comprehensive comment for chip.c
by Anastasia Klimchuk (Code Review) 30 Nov '21

30 Nov '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59238 to look at the new patch set (#4). Change subject: tests: Add comprehensive comment for chip.c ...................................................................... tests: Add comprehensive comment for chip.c Change-Id: Ie498ec55cce8460fc0b2e1fe27254d3a9f763fac Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/chip.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/59238/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/59238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie498ec55cce8460fc0b2e1fe27254d3a9f763fac Gerrit-Change-Number: 59238 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: Set up mock chip memory in consistent and predictable way
by Anastasia Klimchuk (Code Review) 30 Nov '21

30 Nov '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/59237 to look at the new patch set (#4). Change subject: tests: Set up mock chip memory in consistent and predictable way ...................................................................... tests: Set up mock chip memory in consistent and predictable way This patch adds a macro MOCK_CHIP_CONTENT which represents a memory state of a mock chip. The macro is used to initialise mock chip memory at the beginning of a test (in setup_chip function). Previously mock chip memory was not reset between tests. For existing tests that did not matter, however new test for verify operation (added later in this chain) needs mock chip memory to be setup in a predictable way. BUG=b:181803212 TEST=ninja test Change-Id: I0d7623a601c207bfc62d54ab89d94cda56d85871 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/chip.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/59237/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/59237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0d7623a601c207bfc62d54ab89d94cda56d85871 Gerrit-Change-Number: 59237 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: tests: Upgrade linux_mtd test to run probe lifecycle
by Anastasia Klimchuk (Code Review) 30 Nov '21

30 Nov '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/59743 ) Change subject: tests: Upgrade linux_mtd test to run probe lifecycle ...................................................................... tests: Upgrade linux_mtd test to run probe lifecycle No additional mocks are needed, because linux_mtd is doing most of the job in init function. BUG=b:181803212 TEST=ninja test Change-Id: I74436f36f628680c22c7225b1584f06464307775 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/lifecycle.c M tests/tests.c M tests/tests.h 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/59743/1 diff --git a/tests/lifecycle.c b/tests/lifecycle.c index d25681a..b733f62 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -273,7 +273,7 @@ return 0; } -void linux_mtd_basic_lifecycle_test_success(void **state) +void linux_mtd_probe_lifecycle_test_success(void **state) { #if CONFIG_LINUX_MTD == 1 struct linux_mtd_io_state linux_mtd_io_state = { NULL }; @@ -286,7 +286,7 @@ io_mock_register(&linux_mtd_io); - run_basic_lifecycle(state, &programmer_linux_mtd, ""); + run_probe_lifecycle(state, &programmer_linux_mtd, "", "Opaque flash chip"); io_mock_register(NULL); #else diff --git a/tests/tests.c b/tests/tests.c index 3d9ef5f..6e398a1 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -353,7 +353,7 @@ cmocka_unit_test(nicrealtek_basic_lifecycle_test_success), cmocka_unit_test(raiden_debug_basic_lifecycle_test_success), cmocka_unit_test(dediprog_basic_lifecycle_test_success), - cmocka_unit_test(linux_mtd_basic_lifecycle_test_success), + cmocka_unit_test(linux_mtd_probe_lifecycle_test_success), cmocka_unit_test(linux_spi_probe_lifecycle_test_success), cmocka_unit_test(realtek_mst_basic_lifecycle_test_success), }; diff --git a/tests/tests.h b/tests/tests.h index f77f9e5..21b8d07 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -45,7 +45,7 @@ void nicrealtek_basic_lifecycle_test_success(void **state); void raiden_debug_basic_lifecycle_test_success(void **state); void dediprog_basic_lifecycle_test_success(void **state); -void linux_mtd_basic_lifecycle_test_success(void **state); +void linux_mtd_probe_lifecycle_test_success(void **state); void linux_spi_probe_lifecycle_test_success(void **state); void realtek_mst_basic_lifecycle_test_success(void **state); -- To view, visit https://review.coreboot.org/c/flashrom/+/59743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I74436f36f628680c22c7225b1584f06464307775 Gerrit-Change-Number: 59743 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Upgrade linux_spi test to run probe lifecycle
by Anastasia Klimchuk (Code Review) 30 Nov '21

30 Nov '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/59742 ) Change subject: tests: Upgrade linux_spi test to run probe lifecycle ...................................................................... tests: Upgrade linux_spi test to run probe lifecycle No additional mocks are needed, because ioctl is already mocked for some of existing tests. Default behaviour for the mock to do nothing and return success is sufficient to test probe for linux_spi. BUG=b:181803212 TEST=ninja test Change-Id: I32d8e972d99b52c2b18f688aa6aeae75dd170f72 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/lifecycle.c M tests/tests.c M tests/tests.h 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/59742/1 diff --git a/tests/lifecycle.c b/tests/lifecycle.c index 4fd554a..d25681a 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -302,7 +302,7 @@ return memcpy(buf, max_buf_size, min(len, strlen(max_buf_size) + 1)); } -void linux_spi_basic_lifecycle_test_success(void **state) +void linux_spi_probe_lifecycle_test_success(void **state) { /* * Current implementation tests a particular path of the init procedure. @@ -315,7 +315,7 @@ io_mock_register(&linux_spi_io); - run_basic_lifecycle(state, &programmer_linux_spi, "dev=/dev/null"); + run_probe_lifecycle(state, &programmer_linux_spi, "dev=/dev/null", "W25Q128.V"); io_mock_register(NULL); #else diff --git a/tests/tests.c b/tests/tests.c index c840ba4..3d9ef5f 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -354,7 +354,7 @@ cmocka_unit_test(raiden_debug_basic_lifecycle_test_success), cmocka_unit_test(dediprog_basic_lifecycle_test_success), cmocka_unit_test(linux_mtd_basic_lifecycle_test_success), - cmocka_unit_test(linux_spi_basic_lifecycle_test_success), + cmocka_unit_test(linux_spi_probe_lifecycle_test_success), cmocka_unit_test(realtek_mst_basic_lifecycle_test_success), }; ret |= cmocka_run_group_tests_name("lifecycle.c tests", lifecycle_tests, NULL, NULL); diff --git a/tests/tests.h b/tests/tests.h index e450f15..f77f9e5 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -46,7 +46,7 @@ void raiden_debug_basic_lifecycle_test_success(void **state); void dediprog_basic_lifecycle_test_success(void **state); void linux_mtd_basic_lifecycle_test_success(void **state); -void linux_spi_basic_lifecycle_test_success(void **state); +void linux_spi_probe_lifecycle_test_success(void **state); void realtek_mst_basic_lifecycle_test_success(void **state); /* layout.c */ -- To view, visit https://review.coreboot.org/c/flashrom/+/59742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I32d8e972d99b52c2b18f688aa6aeae75dd170f72 Gerrit-Change-Number: 59742 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Add run_probe_lifecycle and use it in dummyflasher test
by Anastasia Klimchuk (Code Review) 30 Nov '21

30 Nov '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/59741 ) Change subject: tests: Add run_probe_lifecycle and use it in dummyflasher test ...................................................................... tests: Add run_probe_lifecycle and use it in dummyflasher test This patch implements run_probe_lifecycle and upgrades dummyflasher lifecycle test to run probing lifecycle. run_probe_lifecycle is operating via libflashrom API. Long term goal for cli_classic is to operate via libflashrom API, so the test is trying this approach. BUG=b:181803212 TEST=ninja test Change-Id: I9eb7fe3a436fbba5e70db957139fd26e00efec36 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/lifecycle.c M tests/tests.c M tests/tests.h 3 files changed, 30 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/41/59741/1 diff --git a/tests/lifecycle.c b/tests/lifecycle.c index 8cb604b..4fd554a 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -16,6 +16,7 @@ #include <include/test.h> #include <string.h> +#include "libflashrom.h" #include "io_mock.h" #include "programmer.h" @@ -36,10 +37,35 @@ free(param_dup); } -void dummy_basic_lifecycle_test_success(void **state) +static void run_probe_lifecycle(void **state, const struct programmer_entry *prog, + const char *param, const char *const chip_name) +{ + (void) state; /* unused */ + + struct flashrom_programmer *flashprog = NULL; + struct flashrom_flashctx *flashctx = NULL; + char *param_dup = strdup(param); + + printf("Testing flashrom_programmer_init for programmer=%s ...\n", prog->name); + assert_int_equal(0, flashrom_programmer_init(&flashprog, prog->name, param_dup)); + printf("... flashrom_programmer_init for programmer=%s successful\n", prog->name); + + printf("Testing flashrom_flash_probe for programmer=%s, chip=%s ... \n", prog->name, chip_name); + assert_int_equal(0, flashrom_flash_probe(&flashctx, flashprog, chip_name)); + printf("... flashrom_flash_probe for programmer=%s successful\n", prog->name); + + printf("Testing flashrom_programmer_shutdown for programmer=%s ...\n", prog->name); + assert_int_equal(0, flashrom_programmer_shutdown(flashprog)); + printf("... flashrom_programmer_shutdown for programmer=%s successful\n", prog->name); + + flashrom_flash_release(flashctx); /* cleanup */ + free(param_dup); +} + +void dummy_probe_lifecycle_test_success(void **state) { #if CONFIG_DUMMY == 1 - run_basic_lifecycle(state, &programmer_dummy, "bus=parallel+lpc+fwh+spi"); + run_probe_lifecycle(state, &programmer_dummy, "bus=spi,emulate=W25Q128FV", "W25Q128.V"); #else skip(); #endif diff --git a/tests/tests.c b/tests/tests.c index a9faa58..c840ba4 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -349,7 +349,7 @@ ret |= cmocka_run_group_tests_name("spi25.c tests", spi25_tests, NULL, NULL); const struct CMUnitTest lifecycle_tests[] = { - cmocka_unit_test(dummy_basic_lifecycle_test_success), + cmocka_unit_test(dummy_probe_lifecycle_test_success), cmocka_unit_test(nicrealtek_basic_lifecycle_test_success), cmocka_unit_test(raiden_debug_basic_lifecycle_test_success), cmocka_unit_test(dediprog_basic_lifecycle_test_success), diff --git a/tests/tests.h b/tests/tests.h index 8a3de44..e450f15 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -41,7 +41,7 @@ void probe_spi_st95_test_success(void **state); /* spi95.c */ /* lifecycle.c */ -void dummy_basic_lifecycle_test_success(void **state); +void dummy_probe_lifecycle_test_success(void **state); void nicrealtek_basic_lifecycle_test_success(void **state); void raiden_debug_basic_lifecycle_test_success(void **state); void dediprog_basic_lifecycle_test_success(void **state); -- To view, visit https://review.coreboot.org/c/flashrom/+/59741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9eb7fe3a436fbba5e70db957139fd26e00efec36 Gerrit-Change-Number: 59741 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2021