January 2021 - flashrom-gerrit

Change in flashrom[master]: Makefile: Add a DISABLE_CLOCK_GETTIME option
by Martin Lucina (Code Review) 11 Jan '21

11 Jan '21

Martin Lucina has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48796 ) Change subject: Makefile: Add a DISABLE_CLOCK_GETTIME option ...................................................................... Makefile: Add a DISABLE_CLOCK_GETTIME option Allows to force-disable the use of clock_gettime() at build time, falling back to busy-looping for udelay. This is useful when building for systems which are known to lie about the resolution of clock_gettime(). Change-Id: I645a5d3f29ffdbd24a58127ab73d7d8755304f45 Signed-off-by: Martin Lucina <martin(a)lucina.net> --- M Makefile 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/48796/1 diff --git a/Makefile b/Makefile index 1f7ea46..09b2154 100644 --- a/Makefile +++ b/Makefile @@ -1663,12 +1663,17 @@ ( echo "found."; echo "UTSNAME := yes" >> .features.tmp ) || \ ( echo "not found."; echo "UTSNAME := no" >> .features.tmp ) } 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) @printf "Checking for clock_gettime support... " | tee -a $(BUILD_DETAILS_FILE) +ifeq ($(DISABLE_CLOCK_GETTIME), yes) + @ { ( echo "disabled."; echo "CLOCK_GETTIME := no" >>.features.tmp ) } \ + 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) +else @echo "$$CLOCK_GETTIME_TEST" >.featuretest.c @printf "\nexec: %s\n" "$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -lrt .featuretest.c -o .featuretest$(EXEC_SUFFIX)" >>$(BUILD_DETAILS_FILE) @ { $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -lrt .featuretest.c -o .featuretest$(EXEC_SUFFIX) >&2 && \ ( echo "found."; echo "CLOCK_GETTIME := yes" >>.features.tmp ) || \ ( echo "not found."; echo "CLOCK_GETTIME := no" >>.features.tmp ) } \ 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) +endif @$(DIFF) -q .features.tmp .features >/dev/null 2>&1 && rm .features.tmp || mv .features.tmp .features @rm -f .featuretest.c .featuretest$(EXEC_SUFFIX) -- To view, visit https://review.coreboot.org/c/flashrom/+/48796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I645a5d3f29ffdbd24a58127ab73d7d8755304f45 Gerrit-Change-Number: 48796 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Lucina <martin(a)lucina.net> Gerrit-MessageType: newchange

2 6

Change in flashrom[master]: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49271 ) Change subject: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: This implementation is wrong -- To view, visit https://review.coreboot.org/c/flashrom/+/49271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I415a528c013f1a523e883d812b6890be39bfcc7b Gerrit-Change-Number: 49271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Jan 2021 15:53:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nicintel_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso`
by Angel Pons (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49267 ) Change subject: nicintel_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > very good job. […] I handle this in CB:49269 -- To view, visit https://review.coreboot.org/c/flashrom/+/49267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I52a0ae5ff331ee2ed41652eb5c2ed7ebe7253d74 Gerrit-Change-Number: 49267 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Comment-Date: Sun, 10 Jan 2021 15:25:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: rayer_spi.c: Implement `set_sck_set_mosi` operation
by Angel Pons (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49265 ) Change subject: rayer_spi.c: Implement `set_sck_set_mosi` operation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > very good job. […] I handle this in CB:49269 -- To view, visit https://review.coreboot.org/c/flashrom/+/49265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb05a35967685c2444d064cb61cec98e2a00f590 Gerrit-Change-Number: 49265 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Comment-Date: Sun, 10 Jan 2021 15:25:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: mcp6x_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso`
by Angel Pons (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Xiang Wang. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49266 ) Change subject: mcp6x_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > very good job. […] I handle this in CB:49269 -- To view, visit https://review.coreboot.org/c/flashrom/+/49266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie86cc9d4df6c7f0609c30ff00d6f2d77fbb8b836 Gerrit-Change-Number: 49266 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Comment-Date: Sun, 10 Jan 2021 15:24:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi: Drop `set_mosi` and `get_miso` operations
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49268 ) Change subject: bitbang_spi: Drop `set_mosi` and `get_miso` operations ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Not every platform can use this method to speed up, and the deleted interface helps portability. The set_sck_set_mosi in bitbang_spi.c can all go wrong, why do you think those who adapt better understand the working principle of spi? -- To view, visit https://review.coreboot.org/c/flashrom/+/49268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6b1edb1e01330feffc5f1ed2ca2c2ebc4fb3b66 Gerrit-Change-Number: 49268 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Jan 2021 15:23:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: nicintel_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso`
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49267 ) Change subject: nicintel_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: very good job. Because set_sck_set_mosi needs to be renamed to set_mosi_set_sck, this patch is best merged after https://review.coreboot.org/c/flashrom/+/49264. -- To view, visit https://review.coreboot.org/c/flashrom/+/49267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I52a0ae5ff331ee2ed41652eb5c2ed7ebe7253d74 Gerrit-Change-Number: 49267 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Jan 2021 15:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: mcp6x_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso`
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49266 ) Change subject: mcp6x_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: very good job. Because set_sck_set_mosi needs to be renamed to set_mosi_set_sck, this patch is best merged after https://review.coreboot.org/c/flashrom/+/49264. -- To view, visit https://review.coreboot.org/c/flashrom/+/49266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie86cc9d4df6c7f0609c30ff00d6f2d77fbb8b836 Gerrit-Change-Number: 49266 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Jan 2021 15:16:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: rayer_spi.c: Implement `set_sck_set_mosi` operation
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49265 ) Change subject: rayer_spi.c: Implement `set_sck_set_mosi` operation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: very good job. Because set_sck_set_mosi needs to be renamed to set_mosi_set_sck, this patch is best merged after https://review.coreboot.org/c/flashrom/+/49264. -- To view, visit https://review.coreboot.org/c/flashrom/+/49265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb05a35967685c2444d064cb61cec98e2a00f590 Gerrit-Change-Number: 49265 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Jan 2021 15:16:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase
by Xiang Wang (Code Review) 10 Jan '21

10 Jan '21

Attention is currently required from: Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49271 ) Change subject: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase ...................................................................... Patch Set 1: (1 comment) File bitbang_spi.c: https://review.coreboot.org/c/flashrom/+/49271/comment/d75f89f6_ba003f69 PS1, Line 71: cpha > Have you tested this patch? Note that the clock phase is conditionally shifted in `bitbang_spi_send_ […] Tested on my raspberry pi zero with W25Q128.V only mode1 not work -- To view, visit https://review.coreboot.org/c/flashrom/+/49271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I415a528c013f1a523e883d812b6890be39bfcc7b Gerrit-Change-Number: 49271 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Jan 2021 14:58:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Xiang Wang <merle(a)hardenedlinux.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2021