Hello Paul Menzel, build bot (Jenkins), Brian Norris,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/22511
to look at the new patch set (#2).
Change subject: linux_mtd: Support for NO_ERASE type devices
......................................................................
linux_mtd: Support for NO_ERASE type devices
Some mtd devices have the MTD_NO_ERASE flag set. This means
these devices don't require an erase to write and might not have
implemented an erase function. We should be conservative and skip
erasing altogether, falling back to performing writes over the whole
flash.
BUG=b:35104688
TESTED=Zaius flash is now written correctly for the 0xff regions.
Change-Id: I4c2fc769a8e0865edf8507f6bd796dc3344b4226
Signed-off-by: William A. Kennington III <wak(a)google.com>
Reviewed-on: https://chromium-review.googlesource.com/472128
Commit-Ready: William Kennington <wak(a)google.com>
Tested-by: William Kennington <wak(a)google.com>
Reviewed-by: Brian Norris <briannorris(a)chromium.org>
---
M flash.h
M flashrom.c
M linux_mtd.c
3 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/22511/2
--
To view, visit https://review.coreboot.org/22511
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4c2fc769a8e0865edf8507f6bd796dc3344b4226
Gerrit-Change-Number: 22511
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25681
to look at the new patch set (#2).
Change subject: ch341a_spi: Avoid deprecated libusb functions
......................................................................
ch341a_spi: Avoid deprecated libusb functions
libusb 1.0.22 marked libusb_set_debug as deprecated. For such versions
of libusb, use libusb_set_option instead.
Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487
Signed-off-by: Alex James <theracermaster(a)gmail.com>
---
M ch341a_spi.c
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/25681/2
--
To view, visit https://review.coreboot.org/25681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487
Gerrit-Change-Number: 25681
Gerrit-PatchSet: 2
Gerrit-Owner: Alex James <theracermaster(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/25681 )
Change subject: ch341a_spi: Avoid deprecated libusb functions
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/25681/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/25681/1//COMMIT_MSG@9
PS1, Line 9: libusb 1.0.22 marked libusb_set_debug as deprecated. Use
: libusb_set_option instead for newer versions of libusb.
Please use the full line length of 72 characters.
--
To view, visit https://review.coreboot.org/25681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487
Gerrit-Change-Number: 25681
Gerrit-PatchSet: 1
Gerrit-Owner: Alex James <theracermaster(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 15 Apr 2018 12:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/25380 )
Change subject: Fix whitespace errors
......................................................................
Patch Set 3:
I' m also confused, as I didn't changed any thing related to EOL to buspirate_spi.c.
I've just removed white spaces ...
--
To view, visit https://review.coreboot.org/25380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113
Gerrit-Change-Number: 25380
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 02 Apr 2018 21:13:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No