April 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add SST26VF016B(A), SST26VF032B(A), SST26VF064B(A)
by David Hendricks (Code Review) 30 Apr '18

30 Apr '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25962 ) Change subject: flashchips: Add SST26VF016B(A), SST26VF032B(A), SST26VF064B(A) ...................................................................... Patch Set 1: Someone on github tested the OpenEmbedded patch and confirmed that it works: https://github.com/flashrom/flashrom/pull/36 -- To view, visit https://review.coreboot.org/25962 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib019bed8ce955049703eb3376c32a83ef607c219 Gerrit-Change-Number: 25962 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 21:29:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by David Hendricks (Code Review) 30 Apr '18

30 Apr '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25465 ) Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... Patch Set 3: -Code-Review There was a pull request for a similar patch at https://github.com/flashrom/flashrom/pull/36. I pointed one of the commenters at the OpenEmbedded patch and they reported that the OE version of the patch works. Also, I noticed that support for this chip series seems to have originated here: https://patchwork.coreboot.org/patch/4126/ I went ahead and uploaded the latest known (AFAICT) version here: https://review.coreboot.org/#/c/flashrom/+/25962/ -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 21:28:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add SST26VF016B(A), SST26VF032B(A), SST26VF064B(A)
by build bot (Jenkins) (Code Review) 30 Apr '18

30 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25962 ) Change subject: flashchips: Add SST26VF016B(A), SST26VF032B(A), SST26VF064B(A) ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1061/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1278/ : SUCCESS -- To view, visit https://review.coreboot.org/25962 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib019bed8ce955049703eb3376c32a83ef607c219 Gerrit-Change-Number: 25962 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 21:28:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add SST26VF016B(A), SST26VF032B(A), SST26VF064B(A)
by David Hendricks (Code Review) 30 Apr '18

30 Apr '18

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/25962 Change subject: flashchips: Add SST26VF016B(A), SST26VF032B(A), SST26VF064B(A) ...................................................................... flashchips: Add SST26VF016B(A), SST26VF032B(A), SST26VF064B(A) This patch seems to have originally been from https://patchwork.coreboot.org/patch/4126/ . The most recent version seems to be in OpenEmbedded (commit 503a572) which added support for 16Mbit and 32Mbit variants. The OpenEmbedded patch also makes changes to linux_spi.c to add some debug prints which are omitted in this version. >From the original commit message: Differences between SST26 and SST25: 1. The WREN instruction must be executed prior to WRSR [Section 5.31]. There is no EWSR. 2. Block protection bits are no longer in the status register. There is a dedicated 144-bit register [Table 5-6]. The device is write-protected by default. A Global Block-Protection Unlock command unlocks the entire memory [Section 4.1]. Change-Id: Ib019bed8ce955049703eb3376c32a83ef607c219 Signed-off-by: Wei Hu <wei(a)aristanetworks.com> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- M chipdrivers.h M flashchips.c M flashchips.h M spi25_statusreg.c 4 files changed, 130 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/25962/1 diff --git a/chipdrivers.h b/chipdrivers.h index af59c30..0ae45f4 100644 --- a/chipdrivers.h +++ b/chipdrivers.h @@ -107,6 +107,7 @@ int spi_prettyprint_status_register_sst25(struct flashctx *flash); int spi_prettyprint_status_register_sst25vf016(struct flashctx *flash); int spi_prettyprint_status_register_sst25vf040b(struct flashctx *flash); +int spi_disable_blockprotect_sst26_global_unprotect(struct flashctx *flash); /* sfdp.c */ int probe_spi_sfdp(struct flashctx *flash); diff --git a/flashchips.c b/flashchips.c index 70057d4..86498af 100644 --- a/flashchips.c +++ b/flashchips.c @@ -12922,6 +12922,120 @@ { .vendor = "SST", + .name = "SST26VF016B(A)", + .bustype = BUS_SPI, + .manufacture_id = SST_ID, + .model_id = SST_SST26VF016B, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { + {8 * 1024, 4}, + {32 * 1024, 1}, + {64 * 1024, 30}, + {32 * 1024, 1}, + {8 * 1024, 4}, + }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + }, + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect_sst26_global_unprotect, + .write = spi_chip_write_256, /* Multi I/O supported */ + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + }, + { + .vendor = "SST", + .name = "SST26VF032B(A)", + .bustype = BUS_SPI, + .manufacture_id = SST_ID, + .model_id = SST_SST26VF032B, + .total_size = 4096, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { + {8 * 1024, 4}, + {32 * 1024, 1}, + {64 * 1024, 62}, + {32 * 1024, 1}, + {8 * 1024, 4}, + }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + }, + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect_sst26_global_unprotect, + .write = spi_chip_write_256, /* Multi I/O supported */ + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + }, + + + { + .vendor = "SST", + .name = "SST26VF064B(A)", + .bustype = BUS_SPI, + .manufacture_id = SST_ID, + .model_id = SST_SST26VF064B, + .total_size = 8192, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { + {8 * 1024, 4}, + {32 * 1024, 1}, + {64 * 1024, 126}, + {32 * 1024, 1}, + {8 * 1024, 4}, + }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + }, + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect_sst26_global_unprotect, + .write = spi_chip_write_256, /* Multi I/O supported */ + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "SST", .name = "SST25WF512", .bustype = BUS_SPI, .manufacture_id = SST_ID, diff --git a/flashchips.h b/flashchips.h index 68a67fa..36d7af6 100644 --- a/flashchips.h +++ b/flashchips.h @@ -703,6 +703,8 @@ #define SST_SST25VF064C 0x254B #define SST_SST26VF016 0x2601 #define SST_SST26VF032 0x2602 +#define SST_SST26VF016B 0x2641 +#define SST_SST26VF032B 0x2642 #define SST_SST26VF064B 0x2643 #define SST_SST27SF512 0xA4 #define SST_SST27SF010 0xA5 diff --git a/spi25_statusreg.c b/spi25_statusreg.c index 05c7acf..d4f0b5d 100644 --- a/spi25_statusreg.c +++ b/spi25_statusreg.c @@ -199,6 +199,19 @@ return spi_disable_blockprotect_generic(flash, 0x3C, 0, 0, 0xFF); } +int spi_disable_blockprotect_sst26_global_unprotect(struct flashctx *flash) +{ + int result = spi_write_enable(flash); + if (result) + return result; + + static const unsigned char cmd[] = { 0x98 }; /* ULBPR */ + result = spi_send_command(flash, sizeof(cmd), 0, cmd, NULL); + if (result) + msg_cerr("ULBPR failed\n"); + return result; +} + /* A common block protection disable that tries to unset the status register bits masked by 0x0C (BP0-1) and * protected/locked by bit #7. Useful when bits 4-5 may be non-0). */ int spi_disable_blockprotect_bp1_srwd(struct flashctx *flash) -- To view, visit https://review.coreboot.org/25962 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib019bed8ce955049703eb3376c32a83ef607c219 Gerrit-Change-Number: 25962 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by David Hendricks (Code Review) 30 Apr '18

30 Apr '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25465 ) Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... Patch Set 3: Code-Review+2 For what it's worth, there seems to be a more complete version of this patch here: http://cgit.openembedded.org/meta-openembedded/tree/meta-oe/recipes-bsp/fla… Should abandon this and import the openembedded one instead? -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 01:23:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Winbond 25Q40EW and rename 25Q40.W
by David Hendricks (Code Review) 30 Apr '18

30 Apr '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25462 ) Change subject: flashchips: Add Winbond 25Q40EW and rename 25Q40.W ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/25462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Gerrit-Change-Number: 25462 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 00:38:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by David Hendricks (Code Review) 30 Apr '18

30 Apr '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25683/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25683/1//COMMIT_MSG@7 PS1, Line 7: - Added support > Just *Add support* without the bullet point. Done -- To view, visit https://review.coreboot.org/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 00:32:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by David Hendricks (Code Review) 30 Apr '18

30 Apr '18

Hello Miklós Márton, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25683 to look at the new patch set (#2). Change subject: Add support for National Instruments USB-845x devices ...................................................................... Add support for National Instruments USB-845x devices Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M Makefile M flashrom.8.tmpl M flashrom.c A ni845x_spi.c M programmer.h 5 files changed, 636 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/25683/2 -- To view, visit https://review.coreboot.org/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by David Hendricks (Code Review) 30 Apr '18

30 Apr '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25681 ) Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 2 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Apr 2018 00:29:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: linux_mtd: Initial import
by David Hendricks (Code Review) 29 Apr '18

29 Apr '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25706 ) Change subject: linux_mtd: Initial import ...................................................................... Patch Set 2: Ping -- To view, visit https://review.coreboot.org/25706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599 Gerrit-Change-Number: 25706 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sun, 29 Apr 2018 09:31:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2018