April 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Remove address from GPLv2 headers
by Nico Huber (Code Review) April 24, 2018

April 24, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 24 Apr 2018 20:18:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fix whitespace errors
by Nico Huber (Code Review) April 24, 2018

April 24, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25380 ) Change subject: Fix whitespace errors ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 24 Apr 2018 20:15:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by build bot (Jenkins) (Code Review) April 23, 2018

April 23, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23338 ) Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1271/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1058/ : SUCCESS -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 5 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Apr 2018 21:15:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by Lubomir Rintel (Code Review) April 23, 2018

April 23, 2018

Lubomir Rintel has posted comments on this change. ( https://review.coreboot.org/23338 ) Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... Patch Set 5: (5 comments) https://review.coreboot.org/#/c/23338/4/digilent_spi.c File digilent_spi.c: https://review.coreboot.org/#/c/23338/4/digilent_spi.c@221 PS4, Line 221: } > Looking at iceBurn, the meaning of the bytes seems known? 2-byte […] Added some more checking of the response. https://review.coreboot.org/#/c/23338/4/digilent_spi.c@230 PS4, Line 230: ret = do_command(req, sizeof(req), res, sizeof(res)); > This seems flawed or at least confuses me too much. If I read iceBurn […] They got this wrong. In fact, they end up padding the read count in the callers of __ICE40SPIPort.io() and then chop the padding from the response. E.g.: def read(self, addr, size): return self.io([self.CMD_FAST_READ...], size+5)[5:] Eek. I suspect that they didn't grok this might be the reason iceBurn might not support readback of the memory. https://review.coreboot.org/#/c/23338/4/digilent_spi.c@236 PS4, Line 236: return -1; > iceBurn pads with zeros, aiui. And not by `readcnt` bytes but only […] Yes, but their read count already contains the write size -- see above. They perhaps didn't realize it, or just didn't bother tidying up their code after they did. The 0x00 vs. 0xff doesn't seem to matter. I don't remember why i chose 0xff, perhaps I've seen it in the trace from the proprietary digilent's tool. https://review.coreboot.org/#/c/23338/4/digilent_spi.c@246 PS4, Line 246: if ((res[1] & 0x40) == 0) { > Maybe we should check `tx_len` as well. True. Done. https://review.coreboot.org/#/c/23338/4/digilent_spi.c@276 PS4, Line 276: : ret = spi_start_io(re > These are about the payload size, i.e. data actually read / written […] Raised to 252, empirically determined as the actual limit of the payload the hardware can handle. Not sure if an inner loop would significantly speed this up, I'd prefer keeping things simple now. -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 5 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Apr 2018 21:15:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by Lubomir Rintel (Code Review) April 23, 2018

April 23, 2018

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23338 to look at the new patch set (#5). Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... digilent_spi: add a driver for the iCEblink40 development board This is driver that supports the Lattice iCE40 evaluation kits. On the board is a SPI flash memory chip labeled ST 25P10VP. Tested to work read/write/erase with "-p digilent_spi -c M25P10" or with a patch that resets the part beforehands (in which case it gets detected as a M25P10-A and is way faster due to paged writes). Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M Makefile A digilent_spi.c M flashrom.8.tmpl M flashrom.c M programmer.h 5 files changed, 508 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/23338/5 -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 5 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Fix whitespace errors
by build bot (Jenkins) (Code Review) April 19, 2018

April 19, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25380 ) Change subject: Fix whitespace errors ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1270/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1057/ : SUCCESS -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 11:09:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fix whitespace errors
by Elyes HAOUAS (Code Review) April 19, 2018

April 19, 2018

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25380 to look at the new patch set (#5). Change subject: Fix whitespace errors ...................................................................... Fix whitespace errors Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M board_enable.c M buspirate_spi.c M cbtable.c M chipset_enable.c M coreboot_tables.h M dediprog.c M flashchips.c M flashchips.h M ichspi.c M it85spi.c M jedec.c M nicintel.c M pcidev.c M serprog.c M udelay.c 15 files changed, 26 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/25380/5 -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by Elyes HAOUAS (Code Review) April 19, 2018

April 19, 2018

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/25381/5/coreboot_tables.h File coreboot_tables.h: https://review.coreboot.org/#/c/25381/5/coreboot_tables.h@28 PS5, Line 28: * All of the information should be Position Independent Data. > I just noticed that this long comment has a few trailing whitespaces which you may want to address i […] this is done here: https://review.coreboot.org/#/c/flashrom/+/25380/ -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 19 Apr 2018 10:20:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by build bot (Jenkins) (Code Review) April 19, 2018

April 19, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1269/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1056/ : SUCCESS -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 19 Apr 2018 10:18:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by Elyes HAOUAS (Code Review) April 19, 2018

April 19, 2018

Hello David Hendricks, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25381 to look at the new patch set (#6). Change subject: Remove address from GPLv2 headers ...................................................................... Remove address from GPLv2 headers Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M 82802ab.c M Makefile M amd_imc.c M at45db.c M atahpt.c M atapromise.c M atavia.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipdrivers.h M chipset_enable.c M cli_classic.c M cli_common.c M cli_output.c M coreboot_tables.h M custom_baud.c M custom_baud.h M dediprog.c M dmi.c M drkaiser.c M dummyflasher.c M en29lv640b.c M flash.h M flashchips.c M flashchips.h M flashrom.c M ft2232_spi.c M gfxnvidia.c M helpers.c M hwaccess.c M hwaccess.h M ich_descriptors.c M ich_descriptors.h M ichspi.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M layout.c M layout.h M libflashrom.c M libflashrom.h M linux_spi.c M mcp6x_spi.c M mstarddc_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M opaque.c M os.h M pcidev.c M physmap.c M pickit2_spi.c M platform.h M pony_spi.c M print.c M print_wiki.c M processor_enable.c M programmer.c M programmer.h M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M sfdp.c M spi.c M spi.h M spi25.c M spi25_statusreg.c M sst28sf040.c M sst49lfxxxc.c M sst_fwhub.c M stm50.c M udelay.c M usbblaster_spi.c M util/flashrom_partial_write_test.sh M util/getrevision.sh M util/ich_descriptors_tool/ich_descriptors_tool.c M util/z60_flashrom.rules M w29ee011.c M w39.c M wbsio_spi.c 92 files changed, 0 insertions(+), 368 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/25381/6 -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0