flashrom-gerrit April 2018

flashrom-gerrit@flashrom.org

1 participants
94 discussions

Change in flashrom[master]: Fix whitespace errors
by Elyes HAOUAS (Code Review) 01 Apr '18

01 Apr '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25380 to look at the new patch set (#3). Change subject: Fix whitespace errors ...................................................................... Fix whitespace errors Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M board_enable.c M buspirate_spi.c M dediprog.c M flashchips.c M ichspi.c M pcidev.c M serprog.c 7 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/25380/3 -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by Nico Huber (Code Review) 01 Apr '18

01 Apr '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 1: I would rather remove the whole paragraph like other projects did... -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 01 Apr 2018 12:08:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Remove unneeded white spaces
by Nico Huber (Code Review) 01 Apr '18

01 Apr '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25380 ) Change subject: Remove unneeded white spaces ...................................................................... Patch Set 2: Code-Review+2 (2 comments) https://review.coreboot.org/#/c/25380/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25380/2//COMMIT_MSG@7 PS2, Line 7: Remove unneeded white spaces You also added the missing EOL to buspirate_spi.c, so maybe call it something more general like "Fix whitespace errors". https://review.coreboot.org/#/c/25380/2/board_enable.c File board_enable.c: https://review.coreboot.org/#/c/25380/2/board_enable.c@551 PS2, Line 551: This one too maybe? -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Apr 2018 12:06:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove unneeded white spaces
by build bot (Jenkins) (Code Review) 01 Apr '18

01 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25380 ) Change subject: Remove unneeded white spaces ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1241/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1029/ : SUCCESS -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Apr 2018 07:01:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2018