March 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Remove address from GPLv2 headers
by Elyes HAOUAS (Code Review) 27 Mar '18

27 Mar '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/25381 Change subject: Remove address from GPLv2 headers ...................................................................... Remove address from GPLv2 headers Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M 82802ab.c M Makefile M amd_imc.c M at45db.c M atahpt.c M atapromise.c M atavia.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipdrivers.h M chipset_enable.c M cli_classic.c M cli_common.c M cli_output.c M coreboot_tables.h M custom_baud.c M custom_baud.h M dediprog.c M dmi.c M drkaiser.c M dummyflasher.c M en29lv640b.c M flash.h M flashchips.c M flashchips.h M flashrom.c M ft2232_spi.c M gfxnvidia.c M helpers.c M hwaccess.c M hwaccess.h M ich_descriptors.c M ich_descriptors.h M ichspi.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M layout.c M layout.h M libflashrom.c M libflashrom.h M linux_spi.c M mcp6x_spi.c M mstarddc_spi.c M nic3com.c M nicintel.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M opaque.c M os.h M pcidev.c M physmap.c M pickit2_spi.c M platform.h M pony_spi.c M print.c M print_wiki.c M processor_enable.c M programmer.c M programmer.h M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M sfdp.c M spi.c M spi.h M spi25.c M spi25_statusreg.c M sst28sf040.c M sst49lfxxxc.c M sst_fwhub.c M stm50.c M udelay.c M usbblaster_spi.c M util/flashrom_partial_write_test.sh M util/getrevision.sh M util/ich_descriptors_tool/ich_descriptors_tool.c M util/z60_flashrom.rules M w29ee011.c M w39.c M wbsio_spi.c 91 files changed, 91 insertions(+), 91 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/25381/1 diff --git a/82802ab.c b/82802ab.c index 1436f8a..96a7027 100644 --- a/82802ab.c +++ b/82802ab.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/Makefile b/Makefile index e26b41e..3732216 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# Foundation, Inc. # PROGRAM = flashrom diff --git a/amd_imc.c b/amd_imc.c index b05390c..14647ba 100644 --- a/amd_imc.c +++ b/amd_imc.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) diff --git a/at45db.c b/at45db.c index b00a751..26803bd 100644 --- a/at45db.c +++ b/at45db.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <string.h> diff --git a/atahpt.c b/atahpt.c index 5966be8..4e90ea7 100644 --- a/atahpt.c +++ b/atahpt.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) diff --git a/atapromise.c b/atapromise.c index e0de290..a33a936 100644 --- a/atapromise.c +++ b/atapromise.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) diff --git a/atavia.c b/atavia.c index db29eea..0694a42 100644 --- a/atavia.c +++ b/atavia.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdlib.h> diff --git a/bitbang_spi.c b/bitbang_spi.c index 5af2370..d7db50c 100644 --- a/bitbang_spi.c +++ b/bitbang_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdio.h> diff --git a/board_enable.c b/board_enable.c index cf19c95..dd27213 100644 --- a/board_enable.c +++ b/board_enable.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/buspirate_spi.c b/buspirate_spi.c index bfbdc6a..09f6d79 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdio.h> diff --git a/cbtable.c b/cbtable.c index c1c264a..7a02a55 100644 --- a/cbtable.c +++ b/cbtable.c @@ -19,7 +19,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <unistd.h> diff --git a/ch341a_spi.c b/ch341a_spi.c index 2253e43..6c6f44c 100644 --- a/ch341a_spi.c +++ b/ch341a_spi.c @@ -18,7 +18,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <string.h> diff --git a/chipdrivers.h b/chipdrivers.h index af59c30..0c9067a 100644 --- a/chipdrivers.h +++ b/chipdrivers.h @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. * * * Header file for flash chip drivers. Included from flash.h. diff --git a/chipset_enable.c b/chipset_enable.c index 8243455..c3c9604 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -21,7 +21,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/cli_classic.c b/cli_classic.c index 31f7394..30b75b5 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -18,7 +18,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdio.h> diff --git a/cli_common.c b/cli_common.c index 256f1fa..0e2ef54 100644 --- a/cli_common.c +++ b/cli_common.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdlib.h> diff --git a/cli_output.c b/cli_output.c index 61a9af6..8a64d6b 100644 --- a/cli_output.c +++ b/cli_output.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdio.h> diff --git a/coreboot_tables.h b/coreboot_tables.h index 2e96526..a13baa8 100644 --- a/coreboot_tables.h +++ b/coreboot_tables.h @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA, 02110-1301 USA + * Foundation, Inc. */ #ifndef COREBOOT_TABLES_H diff --git a/custom_baud.c b/custom_baud.c index 0caca80..8b2539e 100644 --- a/custom_baud.c +++ b/custom_baud.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "platform.h" diff --git a/custom_baud.h b/custom_baud.h index ae286f5..133b8fe 100644 --- a/custom_baud.h +++ b/custom_baud.h @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __CUSTOM_BAUD_H__ diff --git a/dediprog.c b/dediprog.c index 0982f0f..d0b46af 100644 --- a/dediprog.c +++ b/dediprog.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "platform.h" diff --git a/dmi.c b/dmi.c index 70b1177..87df840 100644 --- a/dmi.c +++ b/dmi.c @@ -18,7 +18,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* strnlen is in POSIX but was a GNU extension up to glibc 2.10 */ diff --git a/drkaiser.c b/drkaiser.c index 75cc085..869d69f 100644 --- a/drkaiser.c +++ b/drkaiser.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdlib.h> diff --git a/dummyflasher.c b/dummyflasher.c index 1c0c85b..c4177b3 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <string.h> diff --git a/en29lv640b.c b/en29lv640b.c index 3a5f611..091770f 100644 --- a/en29lv640b.c +++ b/en29lv640b.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "flash.h" diff --git a/flash.h b/flash.h index 40a7f1a..f5d6e3f 100644 --- a/flash.h +++ b/flash.h @@ -18,7 +18,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __FLASH_H__ diff --git a/flashchips.c b/flashchips.c index c2f09ba..c904afa 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19,7 +19,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "flash.h" diff --git a/flashchips.h b/flashchips.h index 98d6e03..84069a9 100644 --- a/flashchips.h +++ b/flashchips.h @@ -18,7 +18,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __FLASHCHIPS_H__ diff --git a/flashrom.c b/flashrom.c index d87a431..2f8ee6a 100644 --- a/flashrom.c +++ b/flashrom.c @@ -20,7 +20,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdio.h> diff --git a/ft2232_spi.c b/ft2232_spi.c index 3889eed..56281be 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if CONFIG_FT2232_SPI == 1 diff --git a/gfxnvidia.c b/gfxnvidia.c index 1e5a23a..6c7c347 100644 --- a/gfxnvidia.c +++ b/gfxnvidia.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdlib.h> diff --git a/helpers.c b/helpers.c index 8bc808a..777a4a5 100644 --- a/helpers.c +++ b/helpers.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <ctype.h> diff --git a/hwaccess.c b/hwaccess.c index 2bf6f42..4fbf7e9 100644 --- a/hwaccess.c +++ b/hwaccess.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "platform.h" diff --git a/hwaccess.h b/hwaccess.h index bc5cb9b..80a9b1d 100644 --- a/hwaccess.h +++ b/hwaccess.h @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/ich_descriptors.c b/ich_descriptors.c index 69fcd75..1093bc8 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "ich_descriptors.h" diff --git a/ich_descriptors.h b/ich_descriptors.h index db4d28f..8749daf 100644 --- a/ich_descriptors.h +++ b/ich_descriptors.h @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __ICH_DESCRIPTORS_H__ diff --git a/ichspi.c b/ichspi.c index 5abc5f8..d45cbad 100644 --- a/ichspi.c +++ b/ichspi.c @@ -20,7 +20,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) diff --git a/internal.c b/internal.c index 4d58eb9..9b7036b 100644 --- a/internal.c +++ b/internal.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <strings.h> diff --git a/it8212.c b/it8212.c index 460e820..74fa941 100644 --- a/it8212.c +++ b/it8212.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdlib.h> diff --git a/it85spi.c b/it85spi.c index 1cc8730..651341d 100644 --- a/it85spi.c +++ b/it85spi.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/it87spi.c b/it87spi.c index 0a1e894..bbdff15 100644 --- a/it87spi.c +++ b/it87spi.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/jedec.c b/jedec.c index af13876..207ce6a 100644 --- a/jedec.c +++ b/jedec.c @@ -20,7 +20,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "flash.h" diff --git a/layout.c b/layout.c index 7ce7c57..7bf9534 100644 --- a/layout.c +++ b/layout.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdio.h> diff --git a/layout.h b/layout.h index fd1049d..5dc8c3a 100644 --- a/layout.h +++ b/layout.h @@ -19,7 +19,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __LAYOUT_H__ diff --git a/libflashrom.c b/libflashrom.c index 6e0f42c..9113c4f 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /** * @mainpage diff --git a/libflashrom.h b/libflashrom.h index 786147b..5211c8c 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __LIBFLASHROM_H__ diff --git a/linux_spi.c b/linux_spi.c index 714e612..510d189 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if CONFIG_LINUX_SPI == 1 diff --git a/mcp6x_spi.c b/mcp6x_spi.c index 4a57cb0..0b64abe 100644 --- a/mcp6x_spi.c +++ b/mcp6x_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* Driver for the NVIDIA MCP6x/MCP7x MCP6X_SPI controller. diff --git a/mstarddc_spi.c b/mstarddc_spi.c index 809d690..897a405 100644 --- a/mstarddc_spi.c +++ b/mstarddc_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if CONFIG_MSTARDDC_SPI == 1 diff --git a/nic3com.c b/nic3com.c index 4d4702a..9a837e2 100644 --- a/nic3com.c +++ b/nic3com.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) diff --git a/nicintel.c b/nicintel.c index 69b40d3..9c21fef 100644 --- a/nicintel.c +++ b/nicintel.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* Datasheet: http://download.intel.com/design/network/datashts/82559_Fast_Ethernet_Multi… */ diff --git a/nicintel_spi.c b/nicintel_spi.c index 3c43e8b..bf142c2 100644 --- a/nicintel_spi.c +++ b/nicintel_spi.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/nicnatsemi.c b/nicnatsemi.c index ce22c94..70a02cd 100644 --- a/nicnatsemi.c +++ b/nicnatsemi.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) diff --git a/nicrealtek.c b/nicrealtek.c index 07910a8..d02cb55 100644 --- a/nicrealtek.c +++ b/nicrealtek.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) diff --git a/ogp_spi.c b/ogp_spi.c index 929ecd9..e6ce842 100644 --- a/ogp_spi.c +++ b/ogp_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdlib.h> diff --git a/opaque.c b/opaque.c index a5a829c..8c4cb5b 100644 --- a/opaque.c +++ b/opaque.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/os.h b/os.h index b59e087..4518f16 100644 --- a/os.h +++ b/os.h @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/pcidev.c b/pcidev.c index 24b7aa1..cc71ed6 100644 --- a/pcidev.c +++ b/pcidev.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdlib.h> diff --git a/physmap.c b/physmap.c index 3338b62..a9165ca 100644 --- a/physmap.c +++ b/physmap.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <unistd.h> diff --git a/pickit2_spi.c b/pickit2_spi.c index 102fe37..03c0a48 100644 --- a/pickit2_spi.c +++ b/pickit2_spi.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/platform.h b/platform.h index 65fe858..6e8f9ef 100644 --- a/platform.h +++ b/platform.h @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/pony_spi.c b/pony_spi.c index f8faeb3..8e5f4de 100644 --- a/pony_spi.c +++ b/pony_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* Driver for serial programmers compatible with SI-Prog or AJAWe. diff --git a/print.c b/print.c index 08bad02..7a92979 100644 --- a/print.c +++ b/print.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdio.h> diff --git a/print_wiki.c b/print_wiki.c index d2fb5e2..4571893 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdio.h> diff --git a/processor_enable.c b/processor_enable.c index 117aa1e..71706a6 100644 --- a/processor_enable.c +++ b/processor_enable.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/programmer.c b/programmer.c index 1b27c3c..ca3b87c 100644 --- a/programmer.c +++ b/programmer.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "flash.h" diff --git a/programmer.h b/programmer.h index 139f4fa..d08cbe0 100644 --- a/programmer.h +++ b/programmer.h @@ -18,7 +18,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __PROGRAMMER_H__ diff --git a/rayer_spi.c b/rayer_spi.c index 3656d26..dceab3c 100644 --- a/rayer_spi.c +++ b/rayer_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* Driver for various LPT adapters. diff --git a/satamv.c b/satamv.c index e76d126..c8a57df 100644 --- a/satamv.c +++ b/satamv.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* Datasheets are not public (yet?) */ diff --git a/satasii.c b/satasii.c index 368d7d4..a6c7b4d 100644 --- a/satasii.c +++ b/satasii.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* Datasheets can be found on http://www.siliconimage.com. Great thanks! */ diff --git a/sb600spi.c b/sb600spi.c index 68f8d8a..918b503 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -19,7 +19,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) diff --git a/serial.c b/serial.c index aa75708..ddccb59 100644 --- a/serial.c +++ b/serial.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "platform.h" diff --git a/serprog.c b/serprog.c index c5a35b4..1abc783 100644 --- a/serprog.c +++ b/serprog.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "platform.h" diff --git a/sfdp.c b/sfdp.c index bc69dd0..01e8388 100644 --- a/sfdp.c +++ b/sfdp.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <stdint.h> diff --git a/spi.c b/spi.c index 56f1fdf..6e8a07a 100644 --- a/spi.c +++ b/spi.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/spi.h b/spi.h index 4da7b73..f7911a0 100644 --- a/spi.h +++ b/spi.h @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __SPI_H__ diff --git a/spi25.c b/spi25.c index 00e0992..dbd384f 100644 --- a/spi25.c +++ b/spi25.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/spi25_statusreg.c b/spi25_statusreg.c index 05c7acf..e887200 100644 --- a/spi25_statusreg.c +++ b/spi25_statusreg.c @@ -18,7 +18,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "flash.h" diff --git a/sst28sf040.c b/sst28sf040.c index 4d8cb66..65dec97 100644 --- a/sst28sf040.c +++ b/sst28sf040.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "flash.h" diff --git a/sst49lfxxxc.c b/sst49lfxxxc.c index d6c85c8..5eee0a8 100644 --- a/sst49lfxxxc.c +++ b/sst49lfxxxc.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "flash.h" diff --git a/sst_fwhub.c b/sst_fwhub.c index 3dd140e..b3e230e 100644 --- a/sst_fwhub.c +++ b/sst_fwhub.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* Adapted from the Intel FW hub stuff for 82802ax parts. */ diff --git a/stm50.c b/stm50.c index 1ae2bc4..810f15a 100644 --- a/stm50.c +++ b/stm50.c @@ -17,7 +17,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/udelay.c b/udelay.c index 3a44c16..8256c10 100644 --- a/udelay.c +++ b/udelay.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #ifndef __LIBPAYLOAD__ diff --git a/usbblaster_spi.c b/usbblaster_spi.c index 7a609f1..85ce62f 100644 --- a/usbblaster_spi.c +++ b/usbblaster_spi.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/util/flashrom_partial_write_test.sh b/util/flashrom_partial_write_test.sh index 2d83752..0378d1e 100755 --- a/util/flashrom_partial_write_test.sh +++ b/util/flashrom_partial_write_test.sh @@ -15,7 +15,7 @@ # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# Foundation, Inc. # # This script attempts to test Flashrom partial write capability by writing # patterns of 0xff and 0x00 bytes to the lowest 128kB of flash. 128kB is chosen diff --git a/util/getrevision.sh b/util/getrevision.sh index 80812b4..e7d890d 100755 --- a/util/getrevision.sh +++ b/util/getrevision.sh @@ -20,7 +20,7 @@ # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# Foundation, Inc. # EXIT_SUCCESS=0 diff --git a/util/ich_descriptors_tool/ich_descriptors_tool.c b/util/ich_descriptors_tool/ich_descriptors_tool.c index 5ab946f..fcb7276 100644 --- a/util/ich_descriptors_tool/ich_descriptors_tool.c +++ b/util/ich_descriptors_tool/ich_descriptors_tool.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ /* diff --git a/util/z60_flashrom.rules b/util/z60_flashrom.rules index 68df5d1..9b1e91a 100644 --- a/util/z60_flashrom.rules +++ b/util/z60_flashrom.rules @@ -15,7 +15,7 @@ ## ## You should have received a copy of the GNU General Public License ## along with this program; if not, write to the Free Software -## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +## Foundation, Inc. ## ## diff --git a/w29ee011.c b/w29ee011.c index 4df4687..745c13d 100644 --- a/w29ee011.c +++ b/w29ee011.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include <string.h> diff --git a/w39.c b/w39.c index 4dd366c..e08d59a 100644 --- a/w39.c +++ b/w39.c @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #include "flash.h" diff --git a/wbsio_spi.c b/wbsio_spi.c index 0eeeb9b..8c8e2bb 100644 --- a/wbsio_spi.c +++ b/wbsio_spi.c @@ -15,7 +15,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc. */ #if defined(__i386__) || defined(__x86_64__) -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in flashrom[master]: Remove unneeded white spaces
by Elyes HAOUAS (Code Review) 27 Mar '18

27 Mar '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/25380 Change subject: Remove unneeded white spaces ...................................................................... Remove unneeded white spaces Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M board_enable.c M buspirate_spi.c M dediprog.c M flashchips.c M ichspi.c M pcidev.c M serprog.c 7 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/25380/1 diff --git a/board_enable.c b/board_enable.c index 5e8f4dd..cf19c95 100644 --- a/board_enable.c +++ b/board_enable.c @@ -547,7 +547,7 @@ } } else { msg_pinfo("BIOS ROM is disabled\n"); - } + } w836xx_ext_leave(port); } diff --git a/buspirate_spi.c b/buspirate_spi.c index f825415..bfbdc6a 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -42,7 +42,7 @@ { /* 115200bps, 8 databits, no parity, 1 stopbit */ sp_fd = sp_openserport(dev, BP_DEFAULTBAUD); - if (sp_fd == SER_INV_FD) + if (sp_fd == SER_INV_FD) return 1; return 0; } @@ -661,4 +661,4 @@ memcpy(readarr, bp_commbuf + 1, readcnt); return ret; -} \ No newline at end of file +} diff --git a/dediprog.c b/dediprog.c index 2f5b441..0982f0f 100644 --- a/dediprog.c +++ b/dediprog.c @@ -458,8 +458,8 @@ if (!transfers[i]) { msg_perr("Allocating libusb transfer %i failed: %s!\n", i, libusb_error_name(ret)); goto err_free; - } - } + } + } /* Now transfer requested chunks using libusb's asynchronous interface. */ while (!status.error && (status.queued_idx < count)) { diff --git a/flashchips.c b/flashchips.c index 46e8807..c2f09ba 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3030,7 +3030,7 @@ } }, .printlock = printlock_at49f, - .write = write_jedec_1, + .write = write_jedec_1, .read = read_memmapped, .voltage = {4500, 5500}, }, @@ -13795,7 +13795,7 @@ .name = "SST49LF080A", .bustype = BUS_LPC, /* A/A Mux */ .manufacture_id = SST_ID, - .model_id = SST_SST49LF080A, + .model_id = SST_SST49LF080A, .total_size = 1024, .page_size = 4096, .feature_bits = FEATURE_EITHER_RESET, diff --git a/ichspi.c b/ichspi.c index 5fe25f6..5abc5f8 100644 --- a/ichspi.c +++ b/ichspi.c @@ -712,7 +712,7 @@ bbar_off = ICH9_REG_BBAR; break; } - + ichspi_bbar = mmio_readl(ich_spibar + bbar_off) & ~BBAR_MASK; if (ichspi_bbar) { msg_pdbg("Reserved bits in BBAR not zero: 0x%08x\n", @@ -737,7 +737,7 @@ * may even crash. */ static void ich_read_data(uint8_t *data, int len, int reg0_off) - { +{ int i; uint32_t temp32 = 0; diff --git a/pcidev.c b/pcidev.c index f4e5542..24b7aa1 100644 --- a/pcidev.c +++ b/pcidev.c @@ -325,13 +325,13 @@ register_undo_pci_write_byte(dev, reg); return pci_write_byte(dev, reg, data); } - + int rpci_write_word(struct pci_dev *dev, int reg, uint16_t data) { register_undo_pci_write_word(dev, reg); return pci_write_word(dev, reg, data); } - + int rpci_write_long(struct pci_dev *dev, int reg, uint32_t data) { register_undo_pci_write_long(dev, reg); diff --git a/serprog.c b/serprog.c index 62f2820..c5a35b4 100644 --- a/serprog.c +++ b/serprog.c @@ -662,7 +662,7 @@ } msg_pdbg(MSGHEADER "operation buffer size is %d\n", sp_device_opbuf_size); - } + } if (sp_check_commandavail(S_CMD_S_PIN_STATE)) { uint8_t en = 1; -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in flashrom[master]: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW.
by Nico Huber (Code Review) 26 Mar '18

26 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25099 ) Change subject: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW. ...................................................................... Patch Set 2: Code-Review+2 (2 comments) https://review.coreboot.org/#/c/25099/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25099/2//COMMIT_MSG@7 PS2, Line 7: . still https://review.coreboot.org/#/c/25099/2/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/25099/2/flashchips.c@a1523 PS2, Line 1523: lost empty line? -- To view, visit https://review.coreboot.org/25099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2 Gerrit-Change-Number: 25099 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Mar 2018 16:19:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW.
by David Hendricks (Code Review) 26 Mar '18

26 Mar '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25099 ) Change subject: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW. ...................................................................... Patch Set 2: (7 comments) https://review.coreboot.org/#/c/25099/1/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/25099/1/flashchips.c@1531 PS1, Line 1531: .feature_bits = FEATURE_WRSR_WREN, > Can't find OTP in datasheet. The comment is inaccurate, but there is OTP capability via security registers that can be permanently locked. Is it accurate to say these are OTP registers in the sense that flashrom knows of them? I'm not really an expert on this aspect as I haven't used OTP bits, so perhaps my intuition is incorrect. What I am asking is: Should the comment change should FEATURE_OTP be removed for this chip? https://review.coreboot.org/#/c/25099/1/flashchips.c@1532 PS1, Line 1532: > Just noticed the notion of EWSR as "Write Enable for Volatile […] IIRC Spansion S25FL chips (or maybe FS?) had a similar feature where one could change a volatile register rather than non-volatile. Whether it suits flashrom better depends on the use case. We should probably expose this on the CLI when we get around to adding the writeprotect stuff to upstream. I think that for the common case in flashrom we will want the non-volatile registers to be updated. For things like BIOS security it's important that write-protection is activated by hardware once /WP is asserted. Otherwise we need to wait for the a master to issue a command to write volatile status bits, and that may leave some attack surface open. https://review.coreboot.org/#/c/25099/1/flashchips.c@1555 PS1, Line 1555: .unlock = spi_disable_blockprotect_at2x_global_unprotect, : .write = spi_chip_write_256, > SF family uses very different status register layout fixed (made generic) https://review.coreboot.org/#/c/25099/1/flashchips.c@1559 PS1, Line 1559: > can't find 2. […] fixed (copypasta) https://review.coreboot.org/#/c/25099/1/flashchips.c@1878 PS1, Line 1878: .tested = TEST_UNTESTED, Not sure if this was intentional, so reverted for now. https://review.coreboot.org/#/c/25099/1/flashchips.c@15075 PS1, Line 15075: _bit > 3*256B ? Done https://review.coreboot.org/#/c/25099/1/flashchips.c@15103 PS1, Line 15103: > 1. […] True, but other chips in this series have it wrong as well :-/ Not sure if it's better to be correct or consistent. I went ahead and corrected this one. -- To view, visit https://review.coreboot.org/25099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2 Gerrit-Change-Number: 25099 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Mar 2018 07:48:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW.
by build bot (Jenkins) (Code Review) 26 Mar '18

26 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25099 ) Change subject: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW. ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1220/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1014/ : SUCCESS -- To view, visit https://review.coreboot.org/25099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2 Gerrit-Change-Number: 25099 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Mar 2018 07:46:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW.
by David Hendricks (Code Review) 26 Mar '18

26 Mar '18

Hello Stefan Tauner, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25099 to look at the new patch set (#2). Change subject: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW. ...................................................................... Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW. Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2 Signed-off-by: Stanislav Sedov <ssedov(a)fb.com> --- M flashchips.c M flashchips.h 2 files changed, 78 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/25099/2 -- To view, visit https://review.coreboot.org/25099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2 Gerrit-Change-Number: 25099 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by Nico Huber (Code Review) 23 Mar '18

23 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23338 ) Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... Patch Set 4: (5 comments) I'm pretty much confused by the padding, did you try what it replies without a padded write? https://review.coreboot.org/#/c/23338/4/digilent_spi.c File digilent_spi.c: https://review.coreboot.org/#/c/23338/4/digilent_spi.c@221 PS4, Line 221: uint8_t res[read_follows ? 10 : 6]; Looking at iceBurn, the meaning of the bytes seems known? 2-byte status, received write length, returned read length. Why not check them? https://review.coreboot.org/#/c/23338/4/digilent_spi.c@230 PS4, Line 230: int len = writecnt + readcnt; This seems flawed or at least confuses me too much. If I read iceBurn correctly, it pads up to `readcnt` so the length of the write is `MAX( writecnt, readcnt)` but not `writecnt + readcnt`. The length of the read in iceBurn seems to always be `readcnt` without anything to drop from the read data. https://review.coreboot.org/#/c/23338/4/digilent_spi.c@236 PS4, Line 236: memset(buf + writecnt, 0xff, readcnt); iceBurn pads with zeros, aiui. And not by `readcnt` bytes but only up to a total length of `readcnt`. https://review.coreboot.org/#/c/23338/4/digilent_spi.c@246 PS4, Line 246: ret = libusb_bulk_transfer(handle, DATA_WRITE_EP, buf, len, &tx_len, USB_TIMEOUT); Maybe we should check `tx_len` as well. https://review.coreboot.org/#/c/23338/4/digilent_spi.c@276 PS4, Line 276: .max_data_read = 64, : .max_data_write = 64, These are about the payload size, i.e. data actually read / written from / to the flash storage. iceBurn seems to use 64 as a limit for the bulk transfers, though, which will include the SPI command and address. So to limit the bulk transfer to 64 bytes, we should set 59 here, I guess. OTOH, if you'd implement a loop around the 64 byte bulk transfers like iceBurn, we wouldn't need a limit here (could speed things a little up due to less protocol overhead). -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 4 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 23 Mar 2018 15:39:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: platform: Add riscv to known platforms
by build bot (Jenkins) (Code Review) 23 Mar '18

23 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25260 ) Change subject: platform: Add riscv to known platforms ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1219/ : SUCCESS -- To view, visit https://review.coreboot.org/25260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I724a99e2493fcbf71c2fc2d9f6a1ad607c737087 Gerrit-Change-Number: 25260 Gerrit-PatchSet: 2 Gerrit-Owner: Khem Raj Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 23 Mar 2018 14:33:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: platform: Add riscv to known platforms
by Nico Huber (Code Review) 23 Mar '18

23 Mar '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/25260 ) Change subject: platform: Add riscv to known platforms ...................................................................... platform: Add riscv to known platforms Change-Id: I724a99e2493fcbf71c2fc2d9f6a1ad607c737087 Signed-off-by: Khem Raj <raj.khem(a)gmail.com> Reviewed-on: https://review.coreboot.org/25260 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M platform.h 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve diff --git a/platform.h b/platform.h index e3b7674..65fe858 100644 --- a/platform.h +++ b/platform.h @@ -69,6 +69,9 @@ #elif defined (__m68k__) #define __FLASHROM_ARCH__ "m68k" #define IS_M68K 1 +#elif defined (__riscv) + #define __FLASHROM_ARCH__ "riscv" + #define IS_RISCV 1 #elif defined (__sh__) #define __FLASHROM_ARCH__ "sh" #define IS_SH 1 @@ -77,7 +80,7 @@ #define IS_S390 1 #endif -#if !(IS_X86 || IS_MIPS || IS_PPC || IS_ARM || IS_SPARC || IS_ALPHA || IS_HPPA || IS_M68K || IS_SH || IS_S390) +#if !(IS_X86 || IS_MIPS || IS_PPC || IS_ARM || IS_SPARC || IS_ALPHA || IS_HPPA || IS_M68K || IS_RISCV || IS_SH || IS_S390) #error Unknown architecture #endif -- To view, visit https://review.coreboot.org/25260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I724a99e2493fcbf71c2fc2d9f6a1ad607c737087 Gerrit-Change-Number: 25260 Gerrit-PatchSet: 2 Gerrit-Owner: Khem Raj Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Fix compilation with older MinGW versions
by build bot (Jenkins) (Code Review) 23 Mar '18

23 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25130 ) Change subject: Fix compilation with older MinGW versions ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1218/ : SUCCESS -- To view, visit https://review.coreboot.org/25130 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48de3e4303b9a389c515a8ce230282d9210576fd Gerrit-Change-Number: 25130 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Ospite <ao2(a)ao2.it> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 23 Mar 2018 14:32:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2018