March 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1211/ : SUCCESS -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 9 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Wed, 14 Mar 2018 11:04:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for Atmel / Adesto AT25SF041 SPI flash chip
by Nico Huber (Code Review) 14 Mar '18

14 Mar '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/25047 ) Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ...................................................................... Add support for Atmel / Adesto AT25SF041 SPI flash chip probe/erase/read/write/verify hardware-tests were done. Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Signed-off-by: Julian von Mendel <git(a)jinvent.de> Signed-off-by: jvm <git(a)jinvent.de> Reviewed-on: https://review.coreboot.org/25047 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 1ab4986..46e8807 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2177,6 +2177,44 @@ { .vendor = "Atmel", + .name = "AT25SF041", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25SF041, + .total_size = 512, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 16} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2500, 3600}, + }, + + { + .vendor = "Atmel", .name = "AT26DF041", .bustype = BUS_SPI, .manufacture_id = ATMEL_ID, diff --git a/flashchips.h b/flashchips.h index 452f776..98d6e03 100644 --- a/flashchips.h +++ b/flashchips.h @@ -150,6 +150,7 @@ #define ATMEL_AT25F4096 0x64 /* Needs AT25F_RDID */ #define ATMEL_AT25FS010 0x6601 #define ATMEL_AT25FS040 0x6604 +#define ATMEL_AT25SF041 0x8401 #define ATMEL_AT26DF041 0x4400 #define ATMEL_AT26DF081 0x4500 /* guessed, no datasheet available */ #define ATMEL_AT26DF081A 0x4501 -- To view, visit https://review.coreboot.org/25047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2 Gerrit-Change-Number: 25047 Gerrit-PatchSet: 9 Gerrit-Owner: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julian von Mendel <git(a)jinvent.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[1.0.x]: linux_spi: Reduce maximum read chunksize
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25150 ) Change subject: linux_spi: Reduce maximum read chunksize ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1210/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1010/ : SUCCESS -- To view, visit https://review.coreboot.org/25150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Gerrit-Change-Number: 25150 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 11:01:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[1.0.x]: linux_spi: Reduce maximum read chunksize
by Nico Huber (Code Review) 14 Mar '18

14 Mar '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25150 Change subject: linux_spi: Reduce maximum read chunksize ...................................................................... linux_spi: Reduce maximum read chunksize It turned out that older kernels use a single buffer for combined input and output data. So we have to account for the read command + max 3 address bytes. Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M linux_spi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/25150/1 diff --git a/linux_spi.c b/linux_spi.c index e51fbc4..d276402 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -183,7 +183,7 @@ unsigned int start, unsigned int len) { return spi_read_chunked(flash, buf, start, len, - (unsigned int)getpagesize()); + (unsigned int)getpagesize() - 4); } static int linux_spi_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len) -- To view, visit https://review.coreboot.org/25150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: newchange Gerrit-Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Gerrit-Change-Number: 25150 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: linux_spi: Reduce maximum read chunksize
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25149 ) Change subject: linux_spi: Reduce maximum read chunksize ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1209/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1009/ : SUCCESS -- To view, visit https://review.coreboot.org/25149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Gerrit-Change-Number: 25149 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 10:56:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: linux_spi: Reduce maximum read chunksize
by Nico Huber (Code Review) 14 Mar '18

14 Mar '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25149 Change subject: linux_spi: Reduce maximum read chunksize ...................................................................... linux_spi: Reduce maximum read chunksize It turned out that older kernels use a single buffer of `bufsiz` bytes for combined input and output data. So we have to account for the read command + max 4 address bytes. Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M linux_spi.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/25149/1 diff --git a/linux_spi.c b/linux_spi.c index 1d3605a..714e612 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -221,8 +221,9 @@ static int linux_spi_read(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len) { - /* Read buffer is fully utilized for data. */ - return spi_read_chunked(flash, buf, start, len, max_kernel_buf_size); + /* Older kernels use a single buffer for combined input and output + data. So account for longest possible command + address, too. */ + return spi_read_chunked(flash, buf, start, len, max_kernel_buf_size - 5); } static int linux_spi_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len) -- To view, visit https://review.coreboot.org/25149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Gerrit-Change-Number: 25149 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Enable native 4BA instructions for Spansion 25FL256S
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25134 ) Change subject: Enable native 4BA instructions for Spansion 25FL256S ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1208/ : SUCCESS -- To view, visit https://review.coreboot.org/25134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ffc816ca714ecce5b89b1eaadb5e73ccb38d9ab Gerrit-Change-Number: 25134 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 10:46:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Enable 4BA mode for Spansion 25FL256S
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25133 ) Change subject: Enable 4BA mode for Spansion 25FL256S ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1207/ : SUCCESS -- To view, visit https://review.coreboot.org/25133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I807bf55d65763a9f48a6a3377f14f4e5288a7a4c Gerrit-Change-Number: 25133 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 10:46:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Spansion 25FL256S......0
by build bot (Jenkins) (Code Review) 14 Mar '18

14 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25132 ) Change subject: flashchips: Add Spansion 25FL256S......0 ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1206/ : SUCCESS -- To view, visit https://review.coreboot.org/25132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a95a81dfe86434f049215ebd8477392391b9efc Gerrit-Change-Number: 25132 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 10:46:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Enable native 4BA instructions for Spansion 25FL256S
by Nico Huber (Code Review) 14 Mar '18

14 Mar '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25134 to look at the new patch set (#5). Change subject: Enable native 4BA instructions for Spansion 25FL256S ...................................................................... Enable native 4BA instructions for Spansion 25FL256S Change-Id: I0ffc816ca714ecce5b89b1eaadb5e73ccb38d9ab Signed-off-by: Nico Huber <nico.h(a)gmx.de> Tested-by: Michael Fuckner <michael(a)fuckner.net> --- M flashchips.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/25134/5 -- To view, visit https://review.coreboot.org/25134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ffc816ca714ecce5b89b1eaadb5e73ccb38d9ab Gerrit-Change-Number: 25134 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2018