March 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Enable 4BA mode for Spansion 25FL256S
by Nico Huber (Code Review) 13 Mar '18

13 Mar '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25133 to look at the new patch set (#2). Change subject: Enable 4BA mode for Spansion 25FL256S ...................................................................... Enable 4BA mode for Spansion 25FL256S 4BA mode is entered by setting bit 7 for the extended address register. Change-Id: I807bf55d65763a9f48a6a3377f14f4e5288a7a4c Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flash.h M flashchips.c M flashrom.c M spi25.c 4 files changed, 11 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/25133/2 -- To view, visit https://review.coreboot.org/25133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I807bf55d65763a9f48a6a3377f14f4e5288a7a4c Gerrit-Change-Number: 25133 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Enable native 4BA instructions for Spansion 25FL256S
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25134 ) Change subject: Enable native 4BA instructions for Spansion 25FL256S ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1199/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1002/ : SUCCESS -- To view, visit https://review.coreboot.org/25134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ffc816ca714ecce5b89b1eaadb5e73ccb38d9ab Gerrit-Change-Number: 25134 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 17:23:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Spansion 25FL256S......0
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25132 ) Change subject: flashchips: Add Spansion 25FL256S......0 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1197/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1000/ : SUCCESS -- To view, visit https://review.coreboot.org/25132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a95a81dfe86434f049215ebd8477392391b9efc Gerrit-Change-Number: 25132 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 17:23:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Enable 4BA mode for Spansion 25FL256S
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25133 ) Change subject: Enable 4BA mode for Spansion 25FL256S ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1198/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1001/ : SUCCESS -- To view, visit https://review.coreboot.org/25133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I807bf55d65763a9f48a6a3377f14f4e5288a7a4c Gerrit-Change-Number: 25133 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 17:23:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Enable native 4BA instructions for Spansion 25FL256S
by Nico Huber (Code Review) 13 Mar '18

13 Mar '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25134 Change subject: Enable native 4BA instructions for Spansion 25FL256S ...................................................................... Enable native 4BA instructions for Spansion 25FL256S Change-Id: I0ffc816ca714ecce5b89b1eaadb5e73ccb38d9ab Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/25134/1 diff --git a/flashchips.c b/flashchips.c index 3022423..a90cc17 100644 --- a/flashchips.c +++ b/flashchips.c @@ -12246,7 +12246,7 @@ .total_size = 32768, .page_size = 256, /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_EAR7, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_4BA_EAR7, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, @@ -12262,6 +12262,9 @@ .block_erase = spi_block_erase_20, }, { */ .eraseblocks = { { 64 * 1024, 512} }, + .block_erase = spi_block_erase_dc, + }, { + .eraseblocks = { { 64 * 1024, 512} }, .block_erase = spi_block_erase_d8, }, { .eraseblocks = { { 16384 * 1024, 1} }, -- To view, visit https://review.coreboot.org/25134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0ffc816ca714ecce5b89b1eaadb5e73ccb38d9ab Gerrit-Change-Number: 25134 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Enable 4BA mode for Spansion 25FL256S
by Nico Huber (Code Review) 13 Mar '18

13 Mar '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25133 Change subject: Enable 4BA mode for Spansion 25FL256S ...................................................................... Enable 4BA mode for Spansion 25FL256S 4BA mode is entered by setting bit 7 for the extended address register. Change-Id: I807bf55d65763a9f48a6a3377f14f4e5288a7a4c Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flash.h M flashchips.c M flashrom.c M spi25.c 4 files changed, 10 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/25133/1 diff --git a/flash.h b/flash.h index f8b420f..e0ce669 100644 --- a/flash.h +++ b/flash.h @@ -121,15 +121,17 @@ #define FEATURE_QPI (1 << 9) #define FEATURE_4BA_ENTER (1 << 10) /**< Can enter/exit 4BA mode with instructions 0xb7/0xe9 w/o WREN */ #define FEATURE_4BA_ENTER_WREN (1 << 11) /**< Can enter/exit 4BA mode with instructions 0xb7/0xe9 after WREN */ -#define FEATURE_4BA_EXT_ADDR (1 << 12) /**< Regular 3-byte operations can be used by writing the most +#define FEATURE_4BA_ENTER_EAR7 (1 << 12) /**< Can enter/exit 4BA mode by setting bit7 of the ext addr reg */ +#define FEATURE_4BA_EXT_ADDR (1 << 13) /**< Regular 3-byte operations can be used by writing the most significant address byte into an extended address register. */ -#define FEATURE_4BA_READ (1 << 13) /**< Native 4BA read instruction (0x13) is supported. */ -#define FEATURE_4BA_FAST_READ (1 << 14) /**< Native 4BA fast read instruction (0x0c) is supported. */ -#define FEATURE_4BA_WRITE (1 << 15) /**< Native 4BA byte program (0x12) is supported. */ +#define FEATURE_4BA_READ (1 << 14) /**< Native 4BA read instruction (0x13) is supported. */ +#define FEATURE_4BA_FAST_READ (1 << 15) /**< Native 4BA fast read instruction (0x0c) is supported. */ +#define FEATURE_4BA_WRITE (1 << 16) /**< Native 4BA byte program (0x12) is supported. */ /* 4BA Shorthands */ #define FEATURE_4BA_NATIVE (FEATURE_4BA_READ | FEATURE_4BA_FAST_READ | FEATURE_4BA_WRITE) #define FEATURE_4BA (FEATURE_4BA_ENTER | FEATURE_4BA_EXT_ADDR | FEATURE_4BA_NATIVE) #define FEATURE_4BA_WREN (FEATURE_4BA_ENTER_WREN | FEATURE_4BA_EXT_ADDR | FEATURE_4BA_NATIVE) +#define FEATURE_4BA_EAR7 (FEATURE_4BA_ENTER_EAR7 | FEATURE_4BA_EXT_ADDR | FEATURE_4BA_NATIVE) /* * Most flash chips are erased to ones and programmed to zeros. However, some * other flash chips, such as the ENE KB9012 internal flash, work the opposite way. diff --git a/flashchips.c b/flashchips.c index 77aa4f7..3022423 100644 --- a/flashchips.c +++ b/flashchips.c @@ -12246,7 +12246,7 @@ .total_size = 32768, .page_size = 256, /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_EXT_ADDR, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_ENTER_EAR7, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, diff --git a/flashrom.c b/flashrom.c index d87a431..c310b98 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2227,7 +2227,7 @@ flash->in_4ba_mode = false; /* Enable/disable 4-byte addressing mode if flash chip supports it */ - if (flash->chip->feature_bits & (FEATURE_4BA_ENTER | FEATURE_4BA_ENTER_WREN)) { + if (flash->chip->feature_bits & (FEATURE_4BA_ENTER | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_ENTER_EAR7)) { int ret; if (spi_master_4ba(flash)) ret = spi_enter_4ba(flash); diff --git a/spi25.c b/spi25.c index db4756d..b3f4a87 100644 --- a/spi25.c +++ b/spi25.c @@ -853,6 +853,8 @@ ret = spi_send_command(flash, sizeof(cmd), 0, &cmd, NULL); else if (flash->chip->feature_bits & FEATURE_4BA_ENTER_WREN) ret = spi_simple_write_cmd(flash, cmd, 0); + else if (flash->chip->feature_bits & FEATURE_4BA_ENTER_EAR7) + ret = spi_set_extended_address(flash, enter ? 0x80 : 0x00); if (!ret) flash->in_4ba_mode = enter; -- To view, visit https://review.coreboot.org/25133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I807bf55d65763a9f48a6a3377f14f4e5288a7a4c Gerrit-Change-Number: 25133 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: flashchips: Add Spansion 25FL256S......0
by Nico Huber (Code Review) 13 Mar '18

13 Mar '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25132 Change subject: flashchips: Add Spansion 25FL256S......0 ...................................................................... flashchips: Add Spansion 25FL256S......0 The Spansion 25SFL256S supports 4BA through an extended address register, a 4BA mode set by bit 7 of that register, or native 4BA instructions. Enable the former only for now. Unfortunately the S25SF256S uses another instruction to write the exten- ded address register. So we add an override for the instruction byte. Change-Id: I0a95a81dfe86434f049215ebd8477392391b9efc Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flash.h M flashchips.c M spi25.c 3 files changed, 47 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/25132/1 diff --git a/flash.h b/flash.h index a80a9c2..f8b420f 100644 --- a/flash.h +++ b/flash.h @@ -235,6 +235,9 @@ uint16_t max; } voltage; enum write_granularity gran; + + /* SPI specific options (TODO: Make it a union in case other bustypes get specific options.) */ + uint8_t wrea_override; /**< override opcode for write extended address register */ }; struct flashrom_flashctx { diff --git a/flashchips.c b/flashchips.c index 1ab4986..77aa4f7 100644 --- a/flashchips.c +++ b/flashchips.c @@ -12238,6 +12238,48 @@ }, { + .vendor = "Spansion", + .name = "S25FL256S......0", /* hybrid: 32 (top or bottom) 4 kB sub-sectors + 64 kB sectors */ + .bustype = BUS_SPI, + .manufacture_id = SPANSION_ID, + .model_id = SPANSION_S25FL256, + .total_size = 32768, + .page_size = 256, + /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_EXT_ADDR, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = { + { + /* This chip supports erasing of the 32 so-called "parameter sectors" with + * opcode 0x20. Trying to access an address outside these 4kB blocks does + * have no effect on the memory contents, but sets a flag in the SR. + .eraseblocks = { + {4 * 1024, 32}, + {64 * 1024, 254} // inaccessible + }, + .block_erase = spi_block_erase_20, + }, { */ + .eraseblocks = { { 64 * 1024, 512} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { { 16384 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { { 16384 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_ep_srwd, /* TODO: SR2 and many others */ + .unlock = spi_disable_blockprotect_bp2_srwd, /* TODO: various other locks */ + .write = spi_chip_write_256, /* Multi I/O supported */ + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + .wrea_override = 0x17, + }, + + { .vendor = "SST", .name = "SST25LF020A", .bustype = BUS_SPI, diff --git a/spi25.c b/spi25.c index 00e0992..db4756d 100644 --- a/spi25.c +++ b/spi25.c @@ -345,13 +345,14 @@ static int spi_write_extended_address_register(struct flashctx *const flash, const uint8_t regdata) { + const uint8_t op = flash->chip->wrea_override ? : JEDEC_WRITE_EXT_ADDR_REG; struct spi_command cmds[] = { { .writecnt = 1, .writearr = (const unsigned char[]){ JEDEC_WREN }, }, { .writecnt = 2, - .writearr = (const unsigned char[]){ JEDEC_WRITE_EXT_ADDR_REG, regdata }, + .writearr = (const unsigned char[]){ op, regdata }, }, NULL_SPI_CMD, }; -- To view, visit https://review.coreboot.org/25132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0a95a81dfe86434f049215ebd8477392391b9efc Gerrit-Change-Number: 25132 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Fix compilation with older MinGW versions
by Nico Huber (Code Review) 13 Mar '18

13 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25130 ) Change subject: Fix compilation with older MinGW versions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25130 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48de3e4303b9a389c515a8ce230282d9210576fd Gerrit-Change-Number: 25130 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Ospite <ao2(a)ao2.it> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 16:33:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fix compilation with older MinGW versions
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25130 ) Change subject: Fix compilation with older MinGW versions ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1196/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/999/ : SUCCESS -- To view, visit https://review.coreboot.org/25130 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48de3e4303b9a389c515a8ce230282d9210576fd Gerrit-Change-Number: 25130 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Ospite <ao2(a)ao2.it> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 16:07:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fix compilation with older MinGW versions
by Antonio Ospite (Code Review) 13 Mar '18

13 Mar '18

Antonio Ospite has uploaded this change for review. ( https://review.coreboot.org/25130 Change subject: Fix compilation with older MinGW versions ...................................................................... Fix compilation with older MinGW versions The __MINGW_PRINTF_FORMAT constant has been defined back in 2012 https://sourceforge.net/p/mingw-w64/mingw-w64/ci/77bc5d6103b5fb9f59fbddab15… However older toolchains are still around and some user reported the following compilation failure: flash.h:336:1: error: '__MINGW_PRINTF_FORMAT' is an unrecognized format function type [-Werror=format=] __attribute__((format(__MINGW_PRINTF_FORMAT, 2, 3))); Fix this by defining the constant when it isn't already; the change does not affect other compilers because it's guarded by "#ifdef __MINGW32__". Setting __MINGW_PRINTF_FORMAT to gnu_printf is exactly what newer MinGW versions do when __USE_MINGW_ANSI_STDIO is defined, which it is in flashrom Makefile. Change-Id: I48de3e4303b9a389c515a8ce230282d9210576fd Tested-by: Miklos Marton <martonmiklosqdev(a)gmail.com> Signed-off-by: Antonio Ospite <ao2(a)ao2.it> --- M flash.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/25130/1 diff --git a/flash.h b/flash.h index a80a9c2..40a7f1a 100644 --- a/flash.h +++ b/flash.h @@ -360,6 +360,9 @@ /* Let gcc and clang check for correct printf-style format strings. */ int print(enum flashrom_log_level level, const char *fmt, ...) #ifdef __MINGW32__ +# ifndef __MINGW_PRINTF_FORMAT +# define __MINGW_PRINTF_FORMAT gnu_printf +# endif __attribute__((format(__MINGW_PRINTF_FORMAT, 2, 3))); #else __attribute__((format(printf, 2, 3))); -- To view, visit https://review.coreboot.org/25130 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I48de3e4303b9a389c515a8ce230282d9210576fd Gerrit-Change-Number: 25130 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Ospite <ao2(a)ao2.it>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2018