March 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: board_enable: add AOpen i965GMt-LA
by build bot (Jenkins) (Code Review) 29 Mar '18

29 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25396 ) Change subject: board_enable: add AOpen i965GMt-LA ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1235/ : SUCCESS -- To view, visit https://review.coreboot.org/25396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8899bbe06707fe76256539f90f5b670301228d52 Gerrit-Change-Number: 25396 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 11:01:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: board_enable: add AOpen i965GMt-LA
by Nico Huber (Code Review) 29 Mar '18

29 Mar '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/25396 ) Change subject: board_enable: add AOpen i965GMt-LA ...................................................................... board_enable: add AOpen i965GMt-LA Change-Id: I8899bbe06707fe76256539f90f5b670301228d52 Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Reviewed-on: https://review.coreboot.org/25396 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M board_enable.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/board_enable.c b/board_enable.c index 5e8f4dd..182a455 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1692,6 +1692,7 @@ /* * Suited for: * - ASUS P5BV-R: LGA775 + 3200 + ICH7 + * - AOpen i965GMt-LA: Intel Socket479 + 965GM + ICH8M */ static int intel_ich_gpio20_raise(void) { @@ -2324,6 +2325,7 @@ {0x1022, 0x2090, 0, 0, 0x1022, 0x2080, 0, 0, NULL, "artecgroup", "dbe61", P3, "Artec Group", "DBE61", 0, OK, board_artecgroup_dbe6x}, {0x1022, 0x2090, 0, 0, 0x1022, 0x2080, 0, 0, NULL, "artecgroup", "dbe62", P3, "Artec Group", "DBE62", 0, OK, board_artecgroup_dbe6x}, {0x8086, 0x27b9, 0xa0a0, 0x0632, 0x8086, 0x27da, 0xa0a0, 0x0632, NULL, NULL, NULL, P3, "AOpen", "i945GMx-VFX", 0, OK, intel_ich_gpio38_raise}, + {0x8086, 0x2a00, 0xa0a0, 0x063e, 0x8086, 0x2815, 0xa0a0, 0x063e, NULL, NULL, NULL, P3, "AOpen", "i965GMt-LA", 0, OK, intel_ich_gpio20_raise}, {0x8086, 0x277c, 0xa0a0, 0x060b, 0x8086, 0x27da, 0xa0a0, 0x060b, NULL, NULL, NULL, P3, "AOpen", "i975Xa-YDG", 0, OK, board_aopen_i975xa_ydg}, {0x8086, 0x27A0, 0x8086, 0x7270, 0x8086, 0x27B9, 0x8086, 0x7270, "^iMac5,2$", NULL, NULL, P2, "Apple", "iMac5,2", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27A0, 0x8086, 0x7270, 0x8086, 0x27B9, 0x8086, 0x7270, "^MacBook2,1$", NULL, NULL, P2, "Apple", "MacBook2,1", 0, OK, p2_whitelist_laptop}, -- To view, visit https://review.coreboot.org/25396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8899bbe06707fe76256539f90f5b670301228d52 Gerrit-Change-Number: 25396 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: board_enable: add AOpen i965GMt-LA
by build bot (Jenkins) (Code Review) 29 Mar '18

29 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25396 ) Change subject: board_enable: add AOpen i965GMt-LA ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1234/ : SUCCESS -- To view, visit https://review.coreboot.org/25396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8899bbe06707fe76256539f90f5b670301228d52 Gerrit-Change-Number: 25396 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 11:01:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: board_enable: add AOpen i965GMt-LA
by Nico Huber (Code Review) 29 Mar '18

29 Mar '18

Nico Huber has uploaded a new patch set (#3) to the change originally created by Idwer Vollering. ( https://review.coreboot.org/25396 ) Change subject: board_enable: add AOpen i965GMt-LA ...................................................................... board_enable: add AOpen i965GMt-LA Change-Id: I8899bbe06707fe76256539f90f5b670301228d52 Signed-off-by: Luc Verhaegen <libv(a)skynet.be> --- M board_enable.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/25396/3 -- To view, visit https://review.coreboot.org/25396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8899bbe06707fe76256539f90f5b670301228d52 Gerrit-Change-Number: 25396 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [PATCH 1/1] board_enable: add AOpen i965GMt-LA
by Nico Huber (Code Review) 29 Mar '18

29 Mar '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25396 ) Change subject: [PATCH 1/1] board_enable: add AOpen i965GMt-LA ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/25396/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25396/2//COMMIT_MSG@7 PS2, Line 7: [PATCH 1/1] [PATCH] tags are for mailing lists, I'll drop it... -- To view, visit https://review.coreboot.org/25396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8899bbe06707fe76256539f90f5b670301228d52 Gerrit-Change-Number: 25396 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Mar 2018 11:00:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: dediprog: implement command spec for firmware >= 7.2.30
by build bot (Jenkins) (Code Review) 29 Mar '18

29 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23836 ) Change subject: dediprog: implement command spec for firmware >= 7.2.30 ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1233/ : SUCCESS -- To view, visit https://review.coreboot.org/23836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Gerrit-Change-Number: 23836 Gerrit-PatchSet: 9 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Mar 2018 22:08:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: dediprog: implement command spec for firmware >= 7.2.30
by David Hendricks (Code Review) 29 Mar '18

29 Mar '18

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/23836 ) Change subject: dediprog: implement command spec for firmware >= 7.2.30 ...................................................................... dediprog: implement command spec for firmware >= 7.2.30 This adds support for the latest command spec for Dediprog SF100/SF600 programmers. Since we now have more than two protocols to deal with the is_new_prot() function is replaced with protocol() which returns an enum specifying which protocol is supported. The latest spec (FW >= 7.2.30) updates read and write packets. It's been tested on an SF600 using firmware 7.2.21 and SF600Plus using FW 7.2.30. The latest command protocol has a few small but important changes: - Read packets have two more bytes: 11: B4Addr: address len (3 or 4) 12: Dummy cycle /2 - Write packets have four more bytes: 11, 12: 16 HSBs of page size 13, 14: 16 LSBs of page size (The spec seems to be mistaken, though, as 11 and 12 are actually LSBs instead of HSBs) Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Signed-off-by: David Hendricks <dhendricks(a)fb.com> Reviewed-on: https://review.coreboot.org/23836 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M dediprog.c 1 file changed, 83 insertions(+), 18 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/dediprog.c b/dediprog.c index 2f5b441..146b3e7 100644 --- a/dediprog.c +++ b/dediprog.c @@ -144,6 +144,17 @@ LEAVE_STANDALONE_MODE = 1, }; +/* + * These are not official designations; they are for use in flashrom only. + * Order must be preserved so that comparison operators work. + */ +enum protocol { + PROTOCOL_UNKNOWN, + PROTOCOL_V1, + PROTOCOL_V2, + PROTOCOL_V3, +}; + const struct dev_entry devs_dediprog[] = { {0x0483, 0xDADA, OK, "Dediprog", "SF100/SF600"}, @@ -169,16 +180,24 @@ } #endif -/* Returns true if firmware (and thus hardware) supports the "new" protocol */ -static bool is_new_prot(void) +static enum protocol protocol(void) { + /* Firmware version < 5.0.0 is handled explicitly in some cases. */ switch (dediprog_devicetype) { case DEV_SF100: - return dediprog_firmwareversion >= FIRMWARE_VERSION(5, 5, 0); + if (dediprog_firmwareversion < FIRMWARE_VERSION(5, 5, 0)) + return PROTOCOL_V1; + else + return PROTOCOL_V2; case DEV_SF600: - return dediprog_firmwareversion >= FIRMWARE_VERSION(6, 9, 0); + if (dediprog_firmwareversion < FIRMWARE_VERSION(6, 9, 0)) + return PROTOCOL_V1; + else if (dediprog_firmwareversion <= FIRMWARE_VERSION(7, 2, 21)) + return PROTOCOL_V2; + else + return PROTOCOL_V3; default: - return 0; + return PROTOCOL_UNKNOWN; } } @@ -287,7 +306,7 @@ * FIXME: take IO pins into account */ int target_leds, ret; - if (is_new_prot()) { + if (protocol() >= PROTOCOL_V2) { target_leds = (leds ^ 7) << 8; ret = dediprog_write(CMD_SET_IO_LED, target_leds, 0, NULL, 0); } else { @@ -387,7 +406,8 @@ return 0; } -static void fill_rw_cmd_payload(uint8_t *data_packet, unsigned int count, uint8_t dedi_spi_cmd, unsigned int *value, unsigned int *idx, unsigned int start) { +static void fill_rw_cmd_payload(uint8_t *data_packet, unsigned int count, uint8_t dedi_spi_cmd, + unsigned int *value, unsigned int *idx, unsigned int start, int is_read) { /* First 5 bytes are common in both generations. */ data_packet[0] = count & 0xff; data_packet[1] = (count >> 8) & 0xff; @@ -395,13 +415,26 @@ data_packet[3] = dedi_spi_cmd; /* Read/Write Mode (currently READ_MODE_STD, WRITE_MODE_PAGE_PGM or WRITE_MODE_2B_AAI) */ data_packet[4] = 0; /* "Opcode". Specs imply necessity only for READ_MODE_4B_ADDR_FAST and WRITE_MODE_4B_ADDR_256B_PAGE_PGM */ - if (is_new_prot()) { + if (protocol() >= PROTOCOL_V2) { *value = *idx = 0; data_packet[5] = 0; /* RFU */ data_packet[6] = (start >> 0) & 0xff; data_packet[7] = (start >> 8) & 0xff; data_packet[8] = (start >> 16) & 0xff; data_packet[9] = (start >> 24) & 0xff; + if (protocol() >= PROTOCOL_V3) { + if (is_read) { + data_packet[10] = 0x00; /* address length (3 or 4) */ + data_packet[11] = 0x00; /* dummy cycle / 2 */ + } else { + /* 16 LSBs and 16 HSBs of page size */ + /* FIXME: This assumes page size of 256. */ + data_packet[10] = 0x00; + data_packet[11] = 0x01; + data_packet[12] = 0x00; + data_packet[13] = 0x00; + } + } } else { *value = start % 0x10000; *idx = start / 0x10000; @@ -434,10 +467,24 @@ if (len == 0) return 0; - /* Command packet size of protocols: new 10 B, old 5 B. */ - uint8_t data_packet[is_new_prot() ? 10 : 5]; + int command_packet_size; + switch (protocol()) { + case PROTOCOL_V1: + command_packet_size = 5; + break; + case PROTOCOL_V2: + command_packet_size = 10; + break; + case PROTOCOL_V3: + command_packet_size = 12; + break; + default: + return 1; + } + + uint8_t data_packet[command_packet_size]; unsigned int value, idx; - fill_rw_cmd_payload(data_packet, count, READ_MODE_STD, &value, &idx, start); + fill_rw_cmd_payload(data_packet, count, READ_MODE_STD, &value, &idx, start, 1); int ret = dediprog_write(CMD_READ, value, idx, data_packet, sizeof(data_packet)); if (ret != sizeof(data_packet)) { @@ -576,10 +623,24 @@ if (len == 0) return 0; - /* Command packet size of protocols: new 10 B, old 5 B. */ - uint8_t data_packet[is_new_prot() ? 10 : 5]; + int command_packet_size; + switch (protocol()) { + case PROTOCOL_V1: + command_packet_size = 5; + break; + case PROTOCOL_V2: + command_packet_size = 10; + break; + case PROTOCOL_V3: + command_packet_size = 14; + break; + default: + return 1; + } + + uint8_t data_packet[command_packet_size]; unsigned int value, idx; - fill_rw_cmd_payload(data_packet, count, dedi_spi_cmd, &value, &idx, start); + fill_rw_cmd_payload(data_packet, count, dedi_spi_cmd, &value, &idx, start, 0); int ret = dediprog_write(CMD_WRITE, value, idx, data_packet, sizeof(data_packet)); if (ret != sizeof(data_packet)) { msg_perr("Command Write SPI Bulk failed, %s!\n", libusb_error_name(ret)); @@ -686,7 +747,7 @@ unsigned int idx, value; /* New protocol has options and timeout combined as value while the old one used the value field for * timeout and the index field for options. */ - if (is_new_prot()) { + if (protocol() >= PROTOCOL_V2) { idx = 0; value = readcnt ? 0x1 : 0x0; // Indicate if we require a read } else { @@ -711,7 +772,7 @@ * The specification also uses only 0 in its examples, so the lesson to learn here: * "Never trust the description of an interface in the documentation but use the example code and pray." const uint8_t read_timeout = 10 + readcnt/512; - if (is_new_prot()) { + if (protocol() >= PROTOCOL_V2) { idx = 0; value = min(read_timeout, 0xFF) | (0 << 8) ; // Timeout in lower byte, option in upper byte } else { @@ -762,7 +823,12 @@ msg_perr("Unexpected firmware version %d.%d.%d!\n", fw[0], fw[1], fw[2]); return 1; } + dediprog_firmwareversion = FIRMWARE_VERSION(fw[0], fw[1], fw[2]); + if (protocol() == PROTOCOL_UNKNOWN) { + msg_perr("Internal error: Unable to determine protocol version.\n"); + return 1; + } return 0; } @@ -922,7 +988,6 @@ static int dediprog_shutdown(void *data) { - dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); dediprog_devicetype = DEV_UNKNOWN; /* URB 28. Command Set SPI Voltage to 0. */ @@ -1083,7 +1148,7 @@ /* Set all possible LEDs as soon as possible to indicate activity. * Because knowing the firmware version is required to set the LEDs correctly we need to this after - * dediprog_check_devicestring() has queried the device and set dediprog_firmwareversion. */ + * dediprog_check_devicestring() has queried the device. */ dediprog_set_leds(LED_ALL); /* Select target/socket, frequency and VCC. */ -- To view, visit https://review.coreboot.org/23836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Gerrit-Change-Number: 23836 Gerrit-PatchSet: 9 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: dediprog: implement command spec for firmware >= 7.2.30
by David Hendricks (Code Review) 29 Mar '18

29 Mar '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23836 ) Change subject: dediprog: implement command spec for firmware >= 7.2.30 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/23836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a53c143948ec40d40433621891a2871d8815f2f Gerrit-Change-Number: 23836 Gerrit-PatchSet: 8 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Mar 2018 22:06:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[staging]: 4BA: Print power-up addressing mode for N25Q SPI flash chips
by David Hendricks (Code Review) 28 Mar '18

28 Mar '18

David Hendricks has abandoned this change. ( https://review.coreboot.org/20512 ) Change subject: 4BA: Print power-up addressing mode for N25Q SPI flash chips ...................................................................... Abandoned Obsolete, thus stuff was merged and subsequently refactored in master. -- To view, visit https://review.coreboot.org/20512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: I95f1a8182dd15ca024bbee2b6f7b0dad0d8dd8b3 Gerrit-Change-Number: 20512 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: test_v2.sh: Copy layout to local tempdir in local-layout mode
by David Hendricks (Code Review) 28 Mar '18

28 Mar '18

David Hendricks has abandoned this change. ( https://review.coreboot.org/19406 ) Change subject: test_v2.sh: Copy layout to local tempdir in local-layout mode ...................................................................... Abandoned Obsolete, newer patch revisions are based on master. -- To view, visit https://review.coreboot.org/19406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: Ia2328d367ee3df5ac1c481c16e4502a81d69fd98 Gerrit-Change-Number: 19406 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2018