David Hendricks has posted comments on this change. ( https://review.coreboot.org/25099 )
Change subject: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW
......................................................................
Patch Set 3: Code-Review+2
Made trivial fixes to address the remaining comments, carrying forward the +2 from earlier.
--
To view, visit https://review.coreboot.org/25099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2
Gerrit-Change-Number: 25099
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 28 Mar 2018 19:34:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
David Hendricks has posted comments on this change. ( https://review.coreboot.org/25099 )
Change subject: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/25099/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/25099/2//COMMIT_MSG@7
PS2, Line 7:
> still
Done
https://review.coreboot.org/#/c/25099/2/flashchips.c
File flashchips.c:
https://review.coreboot.org/#/c/25099/2/flashchips.c@a1523
PS2, Line 1523:
> lost empty line?
Done
--
To view, visit https://review.coreboot.org/25099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2
Gerrit-Change-Number: 25099
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 28 Mar 2018 19:33:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Stefan Tauner, Paul Menzel, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25099
to look at the new patch set (#3).
Change subject: Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW
......................................................................
Add support for Atmel/Adesto AT25SF161 and Winbond W25Q80EW
Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2
Signed-off-by: Stanislav Sedov <ssedov(a)fb.com>
---
M flashchips.c
M flashchips.h
2 files changed, 78 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/25099/3
--
To view, visit https://review.coreboot.org/25099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9e8f7f23896f7002401c6b1e616c0dc102198e2
Gerrit-Change-Number: 25099
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>