October 2018 - flashrom-gerrit

Change in flashrom[master]: ati: add rv730/rv740 support
by Arthur Heymans (Code Review) 20 Oct '18

20 Oct '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29093 ) Change subject: ati: add rv730/rv740 support ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29093/2/ati_spi.c File ati_spi.c: https://review.coreboot.org/#/c/29093/2/ati_spi.c@34 PS2, Line 34: #define ATI_SPI_TYPE_R600 1 : #define ATI_SPI_TYPE_RV730 2 : int type; use an enum? -- To view, visit https://review.coreboot.org/29093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b6abc817c7ba0f12adc94c07bf81de118adffe5 Gerrit-Change-Number: 29093 Gerrit-PatchSet: 2 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 20 Oct 2018 12:42:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: ati: add all rx6xx ids
by Arthur Heymans (Code Review) 20 Oct '18

20 Oct '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29091 ) Change subject: ati: add all rx6xx ids ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29091/2/ati_spi.c File ati_spi.c: https://review.coreboot.org/#/c/29091/2/ati_spi.c@366 PS2, Line 366: 0x9588 Tested. Reads fine. -- To view, visit https://review.coreboot.org/29091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1db93efcc4e10e6f651564ca194a146c668d68b Gerrit-Change-Number: 29091 Gerrit-PatchSet: 2 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 20 Oct 2018 12:30:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: ati: add rv710/rv770/rv790 ids
by Arthur Heymans (Code Review) 20 Oct '18

20 Oct '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29092 ) Change subject: ati: add rv710/rv770/rv790 ids ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29092/2/ati_spi.c File ati_spi.c: https://review.coreboot.org/#/c/29092/2/ati_spi.c@383 PS2, Line 383: 0x1002, 0x954F tested. Reads fine. -- To view, visit https://review.coreboot.org/29092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3bad57e00a29741b67fb1e8141c1c9cce887331 Gerrit-Change-Number: 29092 Gerrit-PatchSet: 2 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 20 Oct 2018 12:29:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Mark MX25L25635F as tested
by Angel Pons (Code Review) 20 Oct '18

20 Oct '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29202 Change subject: flashchips: Mark MX25L25635F as tested ...................................................................... flashchips: Mark MX25L25635F as tested As reported by Kasper Revsbech on 2018-10-19. Change-Id: Icf05288c4e7e34af2e3f4b951457df695078847d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/29202/1 diff --git a/flashchips.c b/flashchips.c index 4a66176..8065283 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8473,7 +8473,7 @@ .page_size = 256, /* OTP: 512B total; enter 0xB1, exit 0xC1 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/29202 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icf05288c4e7e34af2e3f4b951457df695078847d Gerrit-Change-Number: 29202 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: [WIP]dediprog: Implement 4-byte-address support
by Ronald G. Minnich (Code Review) 17 Oct '18

17 Oct '18

Ronald G. Minnich has posted comments on this change. ( https://review.coreboot.org/28804 ) Change subject: [WIP]dediprog: Implement 4-byte-address support ...................................................................... Patch Set 1: oh well ... Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Found Winbond flash chip "W25Q256.V" (32768 kB, SPI) on dediprog. Reading flash... SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! Read operation failed! FAILED. -- To view, visit https://review.coreboot.org/28804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I665d0806aec469a3509620a760815861fbe22841 Gerrit-Change-Number: 28804 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 16 Oct 2018 22:45:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [WIP]dediprog: Implement 4-byte-address support
by Ronald G. Minnich (Code Review) 17 Oct '18

17 Oct '18

Ronald G. Minnich has posted comments on this change. ( https://review.coreboot.org/28804 ) Change subject: [WIP]dediprog: Implement 4-byte-address support ...................................................................... Patch Set 1: > Patch Set 1: > > on build I get this error: > make: *** No rule to make target 'spi4ba.h', needed by 'spi25.o'. Stop. oh nvm it needed a make clean -- To view, visit https://review.coreboot.org/28804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I665d0806aec469a3509620a760815861fbe22841 Gerrit-Change-Number: 28804 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 16 Oct 2018 22:43:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [WIP]dediprog: Implement 4-byte-address support
by Ronald G. Minnich (Code Review) 17 Oct '18

17 Oct '18

Ronald G. Minnich has posted comments on this change. ( https://review.coreboot.org/28804 ) Change subject: [WIP]dediprog: Implement 4-byte-address support ...................................................................... Patch Set 1: on build I get this error: make: *** No rule to make target 'spi4ba.h', needed by 'spi25.o'. Stop. -- To view, visit https://review.coreboot.org/28804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I665d0806aec469a3509620a760815861fbe22841 Gerrit-Change-Number: 28804 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 16 Oct 2018 22:42:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: pci2: add wiki printing support
by Luc Verhaegen (Code Review) 13 Oct '18

13 Oct '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29084 to look at the new patch set (#2). Change subject: pci2: add wiki printing support ...................................................................... pci2: add wiki printing support Change-Id: I8c839feda2ef3ec97183f1e06712881786622ebf Signed-off-by: Luc Verhaegen <libv(a)skynet.be> --- M print.c M print_wiki.c 2 files changed, 100 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/84/29084/2 -- To view, visit https://review.coreboot.org/29084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8c839feda2ef3ec97183f1e06712881786622ebf Gerrit-Change-Number: 29084 Gerrit-PatchSet: 2 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: ati: add northern island family
by Luc Verhaegen (Code Review) 13 Oct '18

13 Oct '18

Luc Verhaegen has uploaded this change for review. ( https://review.coreboot.org/29095 Change subject: ati: add northern island family ...................................................................... ati: add northern island family Change-Id: I3be35e16bc253f2598bb59d8833eab7dbe20f15e Signed-off-by: Luc Verhaegen <libv(a)skynet.be> --- M ati_spi.c 1 file changed, 66 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/29095/1 diff --git a/ati_spi.c b/ati_spi.c index 98b780a..48790d9 100644 --- a/ati_spi.c +++ b/ati_spi.c @@ -31,9 +31,10 @@ struct ati_spi_pci_private { int io_bar; -#define ATI_SPI_TYPE_R600 1 -#define ATI_SPI_TYPE_RV730 2 -#define ATI_SPI_TYPE_EVERGREEN 3 +#define ATI_SPI_TYPE_R600 1 +#define ATI_SPI_TYPE_RV730 2 +#define ATI_SPI_TYPE_EVERGREEN 3 +#define ATI_SPI_TYPE_NORTHERN_ISLAND 4 int type; int (*save) (struct flashrom_pci_device *device); @@ -187,6 +188,16 @@ /* software enable clock gating and set sck divider to 1 */ mmio_mask(R600_ROM_CNTL, 0x10000002, 0xF0000002); + if (private->type == ATI_SPI_TYPE_NORTHERN_ISLAND) { + /* + * Probably some other gpio lines... + * These are not restored by ATIs own tool. + */ + mmio_mask(0x64A0, 0x100, 0x100); + mmio_mask(0x64A8, 0x100, 0x100); + mmio_mask(0x64A4, 0x100, 0x100); + } + /* set gpio7,8,9 low */ mmio_mask(R600_GPIOPAD_A, 0, 0x0700); /* gpio7 is input, gpio8/9 are output */ @@ -202,7 +213,8 @@ mmio_mask(R600_MEDIUM_VID_LOWER_GPIO_CNTL, 0, 0x0400); mmio_mask(R600_LOW_VID_LOWER_GPIO_CNTL, 0, 0x0400); - if (private->type != ATI_SPI_TYPE_EVERGREEN) + if ((private->type == ATI_SPI_TYPE_R600) || + (private->type == ATI_SPI_TYPE_RV730)) mmio_mask(R600_LOWER_GPIO_ENABLE, 0x0400, 0x0400); programmer_delay(1000); @@ -366,7 +378,57 @@ .master = &r600_spi_master, }; +/* + * Used by Cayman, Barts, Turks, and Caicos. + */ +static const struct ati_spi_pci_private northern_island_spi_pci_private = { + .io_bar = 2, + .type = ATI_SPI_TYPE_NORTHERN_ISLAND, + .save = r600_spi_save, + .restore = r600_spi_restore, + .enable = r600_spi_enable, + .master = &r600_spi_master, +}; + const struct flashrom_pci_match ati_spi_pci_devices[] = { + {0x1002, 0x6704, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6707, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6718, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6719, NT, &northern_island_spi_pci_private}, + {0x1002, 0x671C, NT, &northern_island_spi_pci_private}, + {0x1002, 0x671D, NT, &northern_island_spi_pci_private}, + {0x1002, 0x671F, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6720, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6738, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6739, NT, &northern_island_spi_pci_private}, + {0x1002, 0x673E, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6740, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6741, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6742, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6743, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6749, NT, &northern_island_spi_pci_private}, + {0x1002, 0x674A, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6750, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6751, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6758, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6759, NT, &northern_island_spi_pci_private}, + {0x1002, 0x675b, NT, &northern_island_spi_pci_private}, + {0x1002, 0x675d, NT, &northern_island_spi_pci_private}, + {0x1002, 0x675f, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6760, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6761, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6763, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6764, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6765, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6766, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6767, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6768, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6770, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6771, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6772, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6778, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6779, NT, &northern_island_spi_pci_private}, + {0x1002, 0x677B, NT, &northern_island_spi_pci_private}, {0x1002, 0x6880, NT, &evergreen_spi_pci_private}, {0x1002, 0x6888, NT, &evergreen_spi_pci_private}, {0x1002, 0x6889, NT, &evergreen_spi_pci_private}, -- To view, visit https://review.coreboot.org/29095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3be35e16bc253f2598bb59d8833eab7dbe20f15e Gerrit-Change-Number: 29095 Gerrit-PatchSet: 1 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be>

1 0

Change in flashrom[master]: ati: add lombok southern island cards
by Luc Verhaegen (Code Review) 13 Oct '18

13 Oct '18

Luc Verhaegen has uploaded this change for review. ( https://review.coreboot.org/29096 Change subject: ati: add lombok southern island cards ...................................................................... ati: add lombok southern island cards The other southern island cards have some hack that needs to be tested on real hardware before adding support. Change-Id: Icffafeafddce4b697211657082a9a0f550ea5fc3 Signed-off-by: Luc Verhaegen <libv(a)skynet.be> --- M ati_spi.c 1 file changed, 27 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/29096/1 diff --git a/ati_spi.c b/ati_spi.c index 48790d9..1b34c18 100644 --- a/ati_spi.c +++ b/ati_spi.c @@ -35,6 +35,7 @@ #define ATI_SPI_TYPE_RV730 2 #define ATI_SPI_TYPE_EVERGREEN 3 #define ATI_SPI_TYPE_NORTHERN_ISLAND 4 +#define ATI_SPI_TYPE_SOUTHERN_ISLAND 5 int type; int (*save) (struct flashrom_pci_device *device); @@ -208,10 +209,15 @@ /* disable open drain pads */ mmio_mask(R600_GENERAL_PWRMGT, 0, 0x0800); - mmio_mask(R600_CTXSW_VID_LOWER_GPIO_CNTL, 0, 0x0400); - mmio_mask(R600_HIGH_VID_LOWER_GPIO_CNTL, 0, 0x0400); - mmio_mask(R600_MEDIUM_VID_LOWER_GPIO_CNTL, 0, 0x0400); - mmio_mask(R600_LOW_VID_LOWER_GPIO_CNTL, 0, 0x0400); + if ((private->type == ATI_SPI_TYPE_R600) || + (private->type == ATI_SPI_TYPE_RV730) || + (private->type == ATI_SPI_TYPE_EVERGREEN) || + (private->type == ATI_SPI_TYPE_NORTHERN_ISLAND)) { + mmio_mask(R600_CTXSW_VID_LOWER_GPIO_CNTL, 0, 0x0400); + mmio_mask(R600_HIGH_VID_LOWER_GPIO_CNTL, 0, 0x0400); + mmio_mask(R600_MEDIUM_VID_LOWER_GPIO_CNTL, 0, 0x0400); + mmio_mask(R600_LOW_VID_LOWER_GPIO_CNTL, 0, 0x0400); + } if ((private->type == ATI_SPI_TYPE_R600) || (private->type == ATI_SPI_TYPE_RV730)) @@ -390,6 +396,19 @@ .master = &r600_spi_master, }; +/* + * Used by Lombok. + * Verde, Pitcairn, Hainan and Oland are pending. + */ +static const struct ati_spi_pci_private southern_island_spi_pci_private = { + .io_bar = 2, + .type = ATI_SPI_TYPE_SOUTHERN_ISLAND, + .save = r600_spi_save, + .restore = r600_spi_restore, + .enable = r600_spi_enable, + .master = &r600_spi_master, +}; + const struct flashrom_pci_match ati_spi_pci_devices[] = { {0x1002, 0x6704, NT, &northern_island_spi_pci_private}, {0x1002, 0x6707, NT, &northern_island_spi_pci_private}, @@ -429,6 +448,10 @@ {0x1002, 0x6778, NT, &northern_island_spi_pci_private}, {0x1002, 0x6779, NT, &northern_island_spi_pci_private}, {0x1002, 0x677B, NT, &northern_island_spi_pci_private}, + {0x1002, 0x6840, NT, &southern_island_spi_pci_private}, + {0x1002, 0x6841, NT, &southern_island_spi_pci_private}, + {0x1002, 0x6842, NT, &southern_island_spi_pci_private}, + {0x1002, 0x6843, NT, &southern_island_spi_pci_private}, {0x1002, 0x6880, NT, &evergreen_spi_pci_private}, {0x1002, 0x6888, NT, &evergreen_spi_pci_private}, {0x1002, 0x6889, NT, &evergreen_spi_pci_private}, -- To view, visit https://review.coreboot.org/29096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icffafeafddce4b697211657082a9a0f550ea5fc3 Gerrit-Change-Number: 29096 Gerrit-PatchSet: 1 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2018