October 2018 - flashrom-gerrit

Change in flashrom[master]: flashchips: Add Sanyo LE25FU206/A and LE25FU106B
by Nico Huber (Code Review) 23 Oct '18

23 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28813 ) Change subject: flashchips: Add Sanyo LE25FU206/A and LE25FU106B ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28813/2/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/28813/2/flashchips.c@11632 PS2, Line 11632: .manufacture_id = PMC_ID_NOPREFIX, > Any news? Nope, maybe just comment this entry out? -- To view, visit https://review.coreboot.org/28813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c26aafdca232110986334e85297d73d513600dc Gerrit-Change-Number: 28813 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 23 Oct 2018 21:14:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Mark MX25L25635F as tested
by Nico Huber (Code Review) 23 Oct '18

23 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29202 ) Change subject: flashchips: Mark MX25L25635F as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29202 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf05288c4e7e34af2e3f4b951457df695078847d Gerrit-Change-Number: 29202 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 23 Oct 2018 15:01:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom)
by Nico Huber (Code Review) 23 Oct '18

23 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: Add support to get layout from fmap (e.g. coreboot rom) ...................................................................... Patch Set 26: Code-Review+2 (1 comment) We can fix the manpage later, I guess. I'll merge this later tonight if there is no further action. https://review.coreboot.org/#/c/23203/26/flashrom.8.tmpl File flashrom.8.tmpl: https://review.coreboot.org/#/c/23203/26/flashrom.8.tmpl@49 PS26, Line 49: | `\fR` between `ifd` and pipe is still missing. -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 26 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 23 Oct 2018 14:55:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: dmi: Remove nonsense guard; Makefile handles it
by Stefan Reinauer (Code Review) 23 Oct '18

23 Oct '18

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/28715 ) Change subject: dmi: Remove nonsense guard; Makefile handles it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4216be1f9ed308e4580c36d0356480e637ffc82 Gerrit-Change-Number: 28715 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 23 Oct 2018 06:44:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Sanyo LE25FU206/A and LE25FU106B
by Angel Pons (Code Review) 22 Oct '18

22 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28813 ) Change subject: flashchips: Add Sanyo LE25FU206/A and LE25FU106B ...................................................................... Patch Set 3: (10 comments) > Patch Set 2: > > (9 comments) > > Needs many fixes and retesting I guess. Marked the chips as untested because of this. https://review.coreboot.org/#/c/28813/2/flashchips.h File flashchips.h: https://review.coreboot.org/#/c/28813/2/flashchips.h@609 PS2, Line 609: > The chip doesn't support the three byte RDID, 0x62 is just the […] Cut to 0x1D https://review.coreboot.org/#/c/28813/2/flashchips.h@610 PS2, Line 610: #define SANYO_LE25FW406 0x07 /* RES2 */ > same here, I guess Cut to 0x44 https://review.coreboot.org/#/c/28813/2/flashchips.h@611 PS2, Line 611: #define SANYO_LE25FW418A 0x10 /* RES2 and some weird 1 byte RDID variant */ > 0x0612 please Zero-extended https://review.coreboot.org/#/c/28813/2/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/28813/2/flashchips.c@11628 PS2, Line 11628: { > datasheet suggests res2 Done https://review.coreboot.org/#/c/28813/2/flashchips.c@11632 PS2, Line 11632: .manufacture_id = PMC_ID_NOPREFIX, > The datasheet I'm reading suggests 4KiB sectors... wrote a mail. Any news? https://review.coreboot.org/#/c/28813/2/flashchips.c@11649 PS2, Line 11649: .eraseblocks = { {64 * 1024, 1} }, > missing tab Done https://review.coreboot.org/#/c/28813/2/flashchips.c@11656 PS2, Line 11656: }, > datasheet suggests WRSR_WREN Done https://review.coreboot.org/#/c/28813/2/flashchips.c@11658 PS2, Line 11658: { > same here Done https://review.coreboot.org/#/c/28813/2/flashchips.c@11673 PS2, Line 11673: .eraseblocks = { {4 * 1024, 64} }, : .block_erase = erase_sector_jedec, > Datasheet suggests the same register layout as for 106B? Done https://review.coreboot.org/#/c/28813/2/flashchips.c@11685 PS2, Line 11685: .read = read_memmapped, > Judging from the similarity to the 25FU406C id (0x0612 / 0x0613), […] Done -- To view, visit https://review.coreboot.org/28813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c26aafdca232110986334e85297d73d513600dc Gerrit-Change-Number: 28813 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 22 Oct 2018 16:07:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add Sanyo LE25FU206/A and LE25FU106B
by Angel Pons (Code Review) 22 Oct '18

22 Oct '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28813 to look at the new patch set (#3). Change subject: flashchips: Add Sanyo LE25FU206/A and LE25FU106B ...................................................................... flashchips: Add Sanyo LE25FU206/A and LE25FU106B As per user `The_Raven Raven` on the mailing list. Since the added values had some inconsistencies, the chips are marked as untested. Change-Id: I6c26aafdca232110986334e85297d73d513600dc Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 101 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/28813/3 -- To view, visit https://review.coreboot.org/28813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6c26aafdca232110986334e85297d73d513600dc Gerrit-Change-Number: 28813 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: ati: add polaris22
by Luc Verhaegen (Code Review) 22 Oct '18

22 Oct '18

Luc Verhaegen has uploaded this change for review. ( https://review.coreboot.org/29222 Change subject: ati: add polaris22 ...................................................................... ati: add polaris22 I do wonder whether a semi-IGP on kaby-lake-G comes with a standalone spi chip. Time will tell. Change-Id: Ia4950bb098a2bb8dba7b10bb9b2b6012c79365ea Signed-off-by: Luc Verhaegen <libv(a)skynet.be> --- M ati_spi.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/29222/1 diff --git a/ati_spi.c b/ati_spi.c index aca6e4e..3c61a14 100644 --- a/ati_spi.c +++ b/ati_spi.c @@ -774,7 +774,7 @@ /* * Used by Iceland, Tonga, Fiji, Ellesmere/Polaris10, Baffin/Polaris11, - * Polaris12 + * Polaris12, Polaris22. */ static const struct ati_spi_pci_private iceland_spi_pci_private = { .io_bar = CI_MMIO_BAR, @@ -917,6 +917,8 @@ {0x1002, 0x692F, NT, &iceland_spi_pci_private}, {0x1002, 0x6938, NT, &iceland_spi_pci_private}, {0x1002, 0x6939, NT, &iceland_spi_pci_private}, + {0x1002, 0x694C, NT, &iceland_spi_pci_private}, + {0x1002, 0x694E, NT, &iceland_spi_pci_private}, {0x1002, 0x6980, NT, &iceland_spi_pci_private}, {0x1002, 0x6981, NT, &iceland_spi_pci_private}, {0x1002, 0x6985, NT, &iceland_spi_pci_private}, -- To view, visit https://review.coreboot.org/29222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia4950bb098a2bb8dba7b10bb9b2b6012c79365ea Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be>

1 0

Change in flashrom[master]: ati: add baffin/polaris11
by Luc Verhaegen (Code Review) 22 Oct '18

22 Oct '18

Luc Verhaegen has uploaded this change for review. ( https://review.coreboot.org/29220 Change subject: ati: add baffin/polaris11 ...................................................................... ati: add baffin/polaris11 Change-Id: I43716fd70a8162966d83e49eaf9f15a3691270b7 Signed-off-by: Luc Verhaegen <libv(a)skynet.be> --- M ati_spi.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/29220/1 diff --git a/ati_spi.c b/ati_spi.c index ab74e74..a562d00 100644 --- a/ati_spi.c +++ b/ati_spi.c @@ -773,7 +773,7 @@ }; /* - * Used by Iceland, Tonga, Fiji, Ellesmere/Polaris10 + * Used by Iceland, Tonga, Fiji, Ellesmere/Polaris10, Baffin/Polaris11 */ static const struct ati_spi_pci_private iceland_spi_pci_private = { .io_bar = CI_MMIO_BAR, @@ -853,6 +853,14 @@ {0x1002, 0x67CF, NT, &iceland_spi_pci_private}, {0x1002, 0x67D0, NT, &iceland_spi_pci_private}, {0x1002, 0x67DF, NT, &iceland_spi_pci_private}, + {0x1002, 0x67E0, NT, &iceland_spi_pci_private}, + {0x1002, 0x67E1, NT, &iceland_spi_pci_private}, + {0x1002, 0x67E3, NT, &iceland_spi_pci_private}, + {0x1002, 0x67E8, NT, &iceland_spi_pci_private}, + {0x1002, 0x67E9, NT, &iceland_spi_pci_private}, + {0x1002, 0x67EB, NT, &iceland_spi_pci_private}, + {0x1002, 0x67EF, NT, &iceland_spi_pci_private}, + {0x1002, 0x67FF, NT, &iceland_spi_pci_private}, {0x1002, 0x6840, NT, &southern_island_spi_pci_private}, {0x1002, 0x6841, NT, &southern_island_spi_pci_private}, {0x1002, 0x6842, NT, &southern_island_spi_pci_private}, -- To view, visit https://review.coreboot.org/29220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I43716fd70a8162966d83e49eaf9f15a3691270b7 Gerrit-Change-Number: 29220 Gerrit-PatchSet: 1 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be>

1 0

Change in flashrom[master]: ati: add polaris12
by Luc Verhaegen (Code Review) 22 Oct '18

22 Oct '18

Luc Verhaegen has uploaded this change for review. ( https://review.coreboot.org/29221 Change subject: ati: add polaris12 ...................................................................... ati: add polaris12 Change-Id: I7cc8542d3b00623e1e76323673e79c0b30832c53 Signed-off-by: Luc Verhaegen <libv(a)skynet.be> --- M ati_spi.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/29221/1 diff --git a/ati_spi.c b/ati_spi.c index a562d00..aca6e4e 100644 --- a/ati_spi.c +++ b/ati_spi.c @@ -773,7 +773,8 @@ }; /* - * Used by Iceland, Tonga, Fiji, Ellesmere/Polaris10, Baffin/Polaris11 + * Used by Iceland, Tonga, Fiji, Ellesmere/Polaris10, Baffin/Polaris11, + * Polaris12 */ static const struct ati_spi_pci_private iceland_spi_pci_private = { .io_bar = CI_MMIO_BAR, @@ -916,6 +917,13 @@ {0x1002, 0x692F, NT, &iceland_spi_pci_private}, {0x1002, 0x6938, NT, &iceland_spi_pci_private}, {0x1002, 0x6939, NT, &iceland_spi_pci_private}, + {0x1002, 0x6980, NT, &iceland_spi_pci_private}, + {0x1002, 0x6981, NT, &iceland_spi_pci_private}, + {0x1002, 0x6985, NT, &iceland_spi_pci_private}, + {0x1002, 0x6986, NT, &iceland_spi_pci_private}, + {0x1002, 0x6987, NT, &iceland_spi_pci_private}, + {0x1002, 0x6995, NT, &iceland_spi_pci_private}, + {0x1002, 0x699F, NT, &iceland_spi_pci_private}, {0x1002, 0x7300, NT, &iceland_spi_pci_private}, {0x1002, 0x9400, NT, &r600_spi_pci_private}, {0x1002, 0x9401, NT, &r600_spi_pci_private}, -- To view, visit https://review.coreboot.org/29221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7cc8542d3b00623e1e76323673e79c0b30832c53 Gerrit-Change-Number: 29221 Gerrit-PatchSet: 1 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be>

1 0

Change in flashrom[master]: ati: add ellesmere/polaris10
by Luc Verhaegen (Code Review) 22 Oct '18

22 Oct '18

Luc Verhaegen has uploaded this change for review. ( https://review.coreboot.org/29219 Change subject: ati: add ellesmere/polaris10 ...................................................................... ati: add ellesmere/polaris10 Change-Id: Iad0ba28ac7d08ea3cc519737633bcf635612cbfa Signed-off-by: Luc Verhaegen <libv(a)skynet.be> --- M ati_spi.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/29219/1 diff --git a/ati_spi.c b/ati_spi.c index 9988ce7..ab74e74 100644 --- a/ati_spi.c +++ b/ati_spi.c @@ -773,7 +773,7 @@ }; /* - * Used by Iceland, Tonga, Fiji + * Used by Iceland, Tonga, Fiji, Ellesmere/Polaris10 */ static const struct ati_spi_pci_private iceland_spi_pci_private = { .io_bar = CI_MMIO_BAR, @@ -844,6 +844,15 @@ {0x1002, 0x67B1, NT, &hawaii_spi_pci_private}, {0x1002, 0x67B9, NT, &hawaii_spi_pci_private}, {0x1002, 0x67BE, NT, &hawaii_spi_pci_private}, + {0x1002, 0x67C0, NT, &iceland_spi_pci_private}, + {0x1002, 0x67C2, NT, &iceland_spi_pci_private}, + {0x1002, 0x67C4, NT, &iceland_spi_pci_private}, + {0x1002, 0x67C7, NT, &iceland_spi_pci_private}, + {0x1002, 0x67CA, NT, &iceland_spi_pci_private}, + {0x1002, 0x67CC, NT, &iceland_spi_pci_private}, + {0x1002, 0x67CF, NT, &iceland_spi_pci_private}, + {0x1002, 0x67D0, NT, &iceland_spi_pci_private}, + {0x1002, 0x67DF, NT, &iceland_spi_pci_private}, {0x1002, 0x6840, NT, &southern_island_spi_pci_private}, {0x1002, 0x6841, NT, &southern_island_spi_pci_private}, {0x1002, 0x6842, NT, &southern_island_spi_pci_private}, -- To view, visit https://review.coreboot.org/29219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iad0ba28ac7d08ea3cc519737633bcf635612cbfa Gerrit-Change-Number: 29219 Gerrit-PatchSet: 1 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2018