October 2018 - flashrom-gerrit

Change in flashrom[master]: flashchips: Mark AMIC A25L40PU as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28818 ) Change subject: flashchips: Mark AMIC A25L40PU as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I574094bdb83611a3cda2fcc455bcf9aed3774011 Gerrit-Change-Number: 28818 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:50:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flaschips: Mark GigaDevice GD25B128B/GD25Q128B as tested
by Angel Pons (Code Review) 02 Oct '18

02 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28810 ) Change subject: flaschips: Mark GigaDevice GD25B128B/GD25Q128B as tested ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28810/1/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/28810/1/flashchips.c@6353 PS1, Line 6353: GD25B128B > The name should be changed to "GD25B128B/GD25Q128B". Done -- To view, visit https://review.coreboot.org/28810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I134d3816c0f02e20764ab132a01bcba9f4e93f0d Gerrit-Change-Number: 28810 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:43:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flaschips: Mark GigaDevice GD25B128B/GD25Q128B as tested
by Angel Pons (Code Review) 02 Oct '18

02 Oct '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28810 to look at the new patch set (#2). Change subject: flaschips: Mark GigaDevice GD25B128B/GD25Q128B as tested ...................................................................... flaschips: Mark GigaDevice GD25B128B/GD25Q128B as tested Alexander reported this chip as tested using a GD25B128CPIG (same device ID, apparently) on 2018-08-30 via the mailing list. The chip name is updated as well. Change-Id: I134d3816c0f02e20764ab132a01bcba9f4e93f0d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/28810/2 -- To view, visit https://review.coreboot.org/28810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I134d3816c0f02e20764ab132a01bcba9f4e93f0d Gerrit-Change-Number: 28810 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: chipset_enable.c: Mark Broadwell U Premium as DEP
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28817 ) Change subject: chipset_enable.c: Mark Broadwell U Premium as DEP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie195e8ec9ea1a2393e31bebdaede4fd3c3301a17 Gerrit-Change-Number: 28817 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:34:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark Winbond W25Q256.V as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28816 ) Change subject: flashchips: Mark Winbond W25Q256.V as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic562a65d1a7d394f9d2c3980833d10a87bd9358a Gerrit-Change-Number: 28816 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:33:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark Macronix MX66L51235 as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28815 ) Change subject: flashchips: Mark Macronix MX66L51235 as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44363e6755167adbc120444a481b09bb4e1063c5 Gerrit-Change-Number: 28815 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:32:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark Atmel AT25DF161 as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28814 ) Change subject: flashchips: Mark Atmel AT25DF161 as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75fb4b17cf330451489811ae9303cbb33ebcb183 Gerrit-Change-Number: 28814 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:29:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Sanyo LE25FU206/A and LE25FU106B
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28813 ) Change subject: flashchips: Add Sanyo LE25FU206/A and LE25FU106B ...................................................................... Patch Set 2: (9 comments) Needs many fixes and retesting I guess. https://review.coreboot.org/#/c/28813/2/flashchips.h File flashchips.h: https://review.coreboot.org/#/c/28813/2/flashchips.h@609 PS2, Line 609: 62 The chip doesn't support the three byte RDID, 0x62 is just the repetition of the vendor id. https://review.coreboot.org/#/c/28813/2/flashchips.h@610 PS2, Line 610: #define SANYO_LE25FU206 0x4462 same here, I guess https://review.coreboot.org/#/c/28813/2/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/28813/2/flashchips.c@11628 PS2, Line 11628: .probe = probe_spi_rdid, datasheet suggests res2 https://review.coreboot.org/#/c/28813/2/flashchips.c@11632 PS2, Line 11632: .eraseblocks = { {2 * 1024, 64} }, The datasheet I'm reading suggests 4KiB sectors... wrote a mail. https://review.coreboot.org/#/c/28813/2/flashchips.c@11649 PS2, Line 11649: { missing tab https://review.coreboot.org/#/c/28813/2/flashchips.c@11656 PS2, Line 11656: .page_size = 256, datasheet suggests WRSR_WREN https://review.coreboot.org/#/c/28813/2/flashchips.c@11658 PS2, Line 11658: .probe = probe_spi_rdid, same here https://review.coreboot.org/#/c/28813/2/flashchips.c@11673 PS2, Line 11673: .printlock = spi_prettyprint_status_register_bp2_srwd, : .unlock = spi_disable_blockprotect, /* #WP pin write-protects SRWP bit. */ Datasheet suggests the same register layout as for 106B? https://review.coreboot.org/#/c/28813/2/flashchips.c@11685 PS2, Line 11685: .model_id = SANYO_LE25FU206A, Judging from the similarity to the 25FU406C id (0x0612 / 0x0613), We might also want to test the additional erase opcodes known for the 406C. -- To view, visit https://review.coreboot.org/28813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c26aafdca232110986334e85297d73d513600dc Gerrit-Change-Number: 28813 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:22:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Add Sanyo LE25FU206/A and LE25FU106B
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28813 ) Change subject: flashchips: Add Sanyo LE25FU206/A and LE25FU106B ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28813/2/flashchips.h File flashchips.h: https://review.coreboot.org/#/c/28813/2/flashchips.h@611 PS2, Line 611: #define SANYO_LE25FU206A 0x612 0x0612 please -- To view, visit https://review.coreboot.org/28813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c26aafdca232110986334e85297d73d513600dc Gerrit-Change-Number: 28813 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 02 Oct 2018 14:50:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: flashchips: Mark Macronix MX25U12835F as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28812 ) Change subject: flashchips: Mark Macronix MX25U12835F as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28812 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I172453fe902ccface2a3a85817d775d45dd7cf80 Gerrit-Change-Number: 28812 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 14:46:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2018