October 2018 - flashrom-gerrit

Change in flashrom[master]: flashchips: Add ISSI IS25WP064 and IS25WP032
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/28884 Change subject: flashchips: Add ISSI IS25WP064 and IS25WP032 ...................................................................... flashchips: Add ISSI IS25WP064 and IS25WP032 The IS25WP064 was tested successfully by Simon Buhrow as reported on 2018-9-4. While we are at it, also add the 32Mbit version which shares the datasheet (as does the already supported 128Mbit version). Change-Id: Ie0887b4ae6e6465118a5dc2e20b784f783d161b8 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c M flashchips.h 2 files changed, 88 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/84/28884/1 diff --git a/flashchips.c b/flashchips.c index 57ff7b9..388deba 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7296,6 +7296,90 @@ { .vendor = "ISSI", + .name = "IS25WP032", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WP032, + .total_size = 4096, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + /* QPI enable 0x35, disable 0xF5 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 1024} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 128} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {4 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", + .name = "IS25WP064", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WP064, + .total_size = 8192, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + /* QPI enable 0x35, disable 0xF5 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", .name = "IS25WP128", .bustype = BUS_SPI, .manufacture_id = ISSI_ID_SPI, @@ -7303,7 +7387,8 @@ .total_size = 16384, .page_size = 256, /* OTP: 1024B total; read 0x48; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + /* QPI enable 0x35, disable 0xF5 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, diff --git a/flashchips.h b/flashchips.h index ecd8d7a..ee8c7d0 100644 --- a/flashchips.h +++ b/flashchips.h @@ -454,6 +454,8 @@ #define ISSI_ID 0xD5 /* ISSI Integrated Silicon Solutions, see also PMC. */ #define ISSI_ID_SPI 0x9D /* ISSI ID used for SPI flash, see also PMC_ID_NOPREFIX */ #define ISSI_IS25LP128 0x6018 +#define ISSI_IS25WP032 0x7016 +#define ISSI_IS25WP064 0x7017 #define ISSI_IS25WP128 0x7018 #define ISSI_PMC_IS29GL032B 0xF9 #define ISSI_PMC_IS29GL032T 0xF6 -- To view, visit https://review.coreboot.org/28884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0887b4ae6e6465118a5dc2e20b784f783d161b8 Gerrit-Change-Number: 28884 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: flashchips: Mark S25FL208K as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28883 to look at the new patch set (#2). Change subject: flashchips: Mark S25FL208K as tested ...................................................................... flashchips: Mark S25FL208K as tested As report by Frédéric Germain on 2017-12-17. Change-Id: I0a7fc10e75f4a675de41e9765525defe2d2640e4 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/28883/2 -- To view, visit https://review.coreboot.org/28883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a7fc10e75f4a675de41e9765525defe2d2640e4 Gerrit-Change-Number: 28883 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Mark S25FL208K as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/28883 Change subject: flashchips: Mark S25FL208K as tested ...................................................................... flashchips: Mark S25FL208K as tested As report by Frédéric Germain on 2017-12-17. Change-Id: I0a7fc10e75f4a675de41e9765525defe2d2640e4 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/28883/1 diff --git a/flashchips.c b/flashchips.c index 2001d8c..600e475 100644 --- a/flashchips.c +++ b/flashchips.c @@ -12050,7 +12050,7 @@ .total_size = 1024, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { -- To view, visit https://review.coreboot.org/28883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0a7fc10e75f4a675de41e9765525defe2d2640e4 Gerrit-Change-Number: 28883 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: flashchips: Mark Atmel AT45DB081D as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28825 ) Change subject: flashchips: Mark Atmel AT45DB081D as tested ...................................................................... Patch Set 2: Code-Review+2 264B blocks, heh, log looks weird ;) -- To view, visit https://review.coreboot.org/28825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I225984b9e2589713f25d0f9b49eb1c3abdcff3cd Gerrit-Change-Number: 28825 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 18:17:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark Winbond W25Q40BW as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28824 ) Change subject: flashchips: Mark Winbond W25Q40BW as tested ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28824 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I624adef2c5b4dd83f0ce93d6069e315fc407db19 Gerrit-Change-Number: 28824 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 02 Oct 2018 18:15:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark PMC Pm25LD040 as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28823 ) Change subject: flashchips: Mark PMC Pm25LD040 as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied8d07c54f8a222dbe05503f859f82bba27d8336 Gerrit-Change-Number: 28823 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 18:14:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark Sanyo LE25FU406C as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28822 ) Change subject: flashchips: Mark Sanyo LE25FU406C as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dba38d03c826a53bff3ddad0aa536032c5532a1 Gerrit-Change-Number: 28822 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 18:13:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Macronix MX25U8032E
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28821 ) Change subject: flashchips: Add Macronix MX25U8032E ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Looks good, could be merged with the (spurious?) QPI comments removed. https://review.coreboot.org/#/c/28821/1/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/28821/1/flashchips.c@8449 PS1, Line 8449: /* QPI enable 0x35, disable 0xF5 (0xFF et al. work too) */ I don't see that in the datasheet... https://review.coreboot.org/#/c/28821/1/flashchips.c@8450 PS1, Line 8450: FEATURE_QPI should probably be removed too -- To view, visit https://review.coreboot.org/28821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I422c3d51e5011e081ff6bccff294817c8c1765d0 Gerrit-Change-Number: 28821 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 18:12:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark PMC Pm25LD020 as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28820 ) Change subject: flashchips: Mark PMC Pm25LD020 as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16d5a207599b434fe52b42709e42f1f32a8e6698 Gerrit-Change-Number: 28820 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:53:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark GigaDevice GD25Q128C as tested
by Nico Huber (Code Review) 02 Oct '18

02 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28819 ) Change subject: flashchips: Mark GigaDevice GD25Q128C as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d7485c7221f92ec13995c58065a48e08f57cd8 Gerrit-Change-Number: 28819 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:51:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2018