October 2017 - flashrom-gerrit

Change in flashrom[staging]: spi25: Add native 4BA support
by Nico Huber (Code Review) 15 Oct '17

15 Oct '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22020 Change subject: spi25: Add native 4BA support ...................................................................... spi25: Add native 4BA support Allow 4-byte adresses, cache the upper most byte in flashctx if the chip uses an extended address register. Change-Id: I644600beaab9a571b97b67f7516abe571d3460c1 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flash.h M flashrom.c M spi25.c M spi4ba.h 4 files changed, 30 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/22020/1 diff --git a/flash.h b/flash.h index 52303f1..a3e7fd4 100644 --- a/flash.h +++ b/flash.h @@ -120,6 +120,7 @@ #define FEATURE_OTP (1 << 8) #define FEATURE_QPI (1 << 9) #define FEATURE_4BA_SUPPORT (1 << 10) +#define FEATURE_4BA_EXT_ADDR (1 << 11) enum test_state { OK = 0, @@ -236,6 +237,7 @@ bool verify_after_write; bool verify_whole_chip; } flags; + int address_high_byte; }; /* Timing used in probe routines. ZERO is -2 to differentiate between an unset diff --git a/flashrom.c b/flashrom.c index 4f17382..62991d5 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2232,6 +2232,8 @@ } } + flash->address_high_byte = -1; + return 0; } diff --git a/spi25.c b/spi25.c index f8ad692..052c6f3 100644 --- a/spi25.c +++ b/spi25.c @@ -355,14 +355,34 @@ return result ? result : status; } +static int spi_set_extended_address(struct flashctx *const flash, const uint8_t addr_high) +{ + if (flash->address_high_byte != addr_high && + spi_write_extended_address_register(flash, addr_high)) + return -1; + flash->address_high_byte = addr_high; + return 0; +} + static int spi_prepare_address(struct flashctx *const flash, uint8_t cmd_buf[], const unsigned int addr) { - /* TODO: extend for 4BA */ - cmd_buf[1] = (addr >> 16) & 0xff; - cmd_buf[2] = (addr >> 8) & 0xff; - cmd_buf[3] = (addr >> 0) & 0xff; - return 3; + if (flash->chip->feature_bits & FEATURE_4BA_SUPPORT && + !(flash->chip->feature_bits & FEATURE_4BA_EXT_ADDR)) { + cmd_buf[1] = (addr >> 24) & 0xff; + cmd_buf[2] = (addr >> 16) & 0xff; + cmd_buf[3] = (addr >> 8) & 0xff; + cmd_buf[4] = (addr >> 0) & 0xff; + return 4; + } else { + if (flash->chip->feature_bits & FEATURE_4BA_EXT_ADDR && + spi_set_extended_address(flash, addr >> 24)) + return -1; + cmd_buf[1] = (addr >> 16) & 0xff; + cmd_buf[2] = (addr >> 8) & 0xff; + cmd_buf[3] = (addr >> 0) & 0xff; + return 3; + } } static int spi_write_cmd(struct flashctx *const flash, diff --git a/spi4ba.h b/spi4ba.h index 8a01792..a0316bc 100644 --- a/spi4ba.h +++ b/spi4ba.h @@ -114,5 +114,6 @@ int spi_block_erase_5c_4ba_direct(struct flashctx *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_dc_4ba_direct(struct flashctx *flash, unsigned int addr, unsigned int blocklen); +int spi_write_extended_address_register(struct flashctx *flash, uint8_t regdata); #endif /* __SPI_4BA_H__ */ -- To view, visit https://review.coreboot.org/22020 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I644600beaab9a571b97b67f7516abe571d3460c1 Gerrit-Change-Number: 22020 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: spi25_statusreg: Return defined value on failed RDSR
by Nico Huber (Code Review) 15 Oct '17

15 Oct '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22017 Change subject: spi25_statusreg: Return defined value on failed RDSR ...................................................................... spi25_statusreg: Return defined value on failed RDSR The interface of spi_read_status_register() is broken and can't return errors. Let's not return random stack data at least. Change-Id: I714b20001a5443bba665c2e0061ca14069777581 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M spi25_statusreg.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/17/22017/1 diff --git a/spi25_statusreg.c b/spi25_statusreg.c index 01a6862..05c7acf 100644 --- a/spi25_statusreg.c +++ b/spi25_statusreg.c @@ -117,8 +117,11 @@ /* Read Status Register */ ret = spi_send_command(flash, sizeof(cmd), sizeof(readarr), cmd, readarr); - if (ret) + if (ret) { msg_cerr("RDSR failed!\n"); + /* FIXME: We should propagate the error. */ + return 0; + } return readarr[0]; } -- To view, visit https://review.coreboot.org/22017 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I714b20001a5443bba665c2e0061ca14069777581 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: 4BA: Print power-up addressing mode for N25Q SPI flash chips
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20512 ) Change subject: 4BA: Print power-up addressing mode for N25Q SPI flash chips ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/772/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/695/ : SUCCESS -- To view, visit https://review.coreboot.org/20512 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I95f1a8182dd15ca024bbee2b6f7b0dad0d8dd8b3 Gerrit-Change-Number: 20512 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 11:01:47 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Allow disabling 4-byte address mode for SPI flash
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20510 ) Change subject: 4BA: Allow disabling 4-byte address mode for SPI flash ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/770/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/693/ : SUCCESS -- To view, visit https://review.coreboot.org/20510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I0b25309d731426940fc50956b744b681ab599e87 Gerrit-Change-Number: 20510 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 11:01:44 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Add Micron N25Q/MT25QL 32MB and 64MB 3V SPI flash
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20511 ) Change subject: 4BA: Add Micron N25Q/MT25QL 32MB and 64MB 3V SPI flash ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/771/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/694/ : SUCCESS -- To view, visit https://review.coreboot.org/20511 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I3c130c5ecf4bcc7cf3b34257cb5fc3df523ce08b Gerrit-Change-Number: 20511 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 11:01:44 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Add spi_exit_4ba function to switch SPI flash to 3-byte addressing
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20509 ) Change subject: 4BA: Add spi_exit_4ba function to switch SPI flash to 3-byte addressing ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/769/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/692/ : SUCCESS -- To view, visit https://review.coreboot.org/20509 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I553e7fb5028f35e14a3a81b3fa8903c1b321a223 Gerrit-Change-Number: 20509 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 11:01:32 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Support for new direct-4BA instructions + W25Q256.V update
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20508 ) Change subject: 4BA: Support for new direct-4BA instructions + W25Q256.V update ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/768/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/691/ : SUCCESS -- To view, visit https://review.coreboot.org/20508 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib51bcc5de7826b30ad697fcbb9a5152bde2c2ac9 Gerrit-Change-Number: 20508 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 11:01:14 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Support for 4-bytes addressing via Extended Address Register
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20507 ) Change subject: 4BA: Support for 4-bytes addressing via Extended Address Register ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/767/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/690/ : SUCCESS -- To view, visit https://review.coreboot.org/20507 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I09a8aa11de2ca14901f142c67c83c4fa0def4e27 Gerrit-Change-Number: 20507 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 11:01:03 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Flashrom integration for the 4-bytes addressing extensions
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20505 ) Change subject: 4BA: Flashrom integration for the 4-bytes addressing extensions ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/766/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/689/ : SUCCESS -- To view, visit https://review.coreboot.org/20505 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib051cfc93bd4aa7580519e0e6206d025f3ca8049 Gerrit-Change-Number: 20505 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 11:00:53 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20506 ) Change subject: 4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/765/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/688/ : SUCCESS -- To view, visit https://review.coreboot.org/20506 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I90226f453f8147ae5ac7dbbef7549ee3bfacc3d6 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 11:00:48 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2017