October 2017 - flashrom-gerrit

Change in flashrom[staging]: 4BA: Support for 4-bytes addressing via Extended Address Register
by Nico Huber (Code Review) 14 Oct '17

14 Oct '17

Nico Huber has uploaded a new patch set (#4) to the change originally created by David Hendricks. ( https://review.coreboot.org/20507 ) Change subject: 4BA: Support for 4-bytes addressing via Extended Address Register ...................................................................... 4BA: Support for 4-bytes addressing via Extended Address Register On some flash chips data with addresses more than 24-bit field can address may be accessed by using Extended Address Register. The register has 1-byte size and stores high byte of 32-bit address. Then flash can be read from 3-bytes addressing mode with writing high byte of address to this Register. By using this way we have access to full memory of a chip. Some chips may support this method only. This patch provides code use Extended Address Register. Patched files ------------- chipdrivers.h + added functions declarations for spi4ba.c flash.h + feature definitions added flashrom.c + modified switch to 4-bytes addressing to support extended address register spi4ba.h + definitions for 4-bytes addressing JEDEC commands + functions declarations from spi4ba.c (same as in chipdrivers.h, just to see) spi4ba.c + functions for write Extended Address Register + functions for read/write/erase with Extended Address Register Change-Id: I09a8aa11de2ca14901f142c67c83c4fa0def4e27 Signed-off-by: Boris Baykov <dev(a)borisbaykov.com>, Russia, Jan 2014 [clg: ported from https://www.flashrom.org/pipermail/flashrom/2015-January/013200.html ] Signed-off-by: Cédric Le Goater <clg(a)kaod.org> --- M chipdrivers.h M flash.h M flashrom.c M spi4ba.c M spi4ba.h 5 files changed, 361 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/20507/4 -- To view, visit https://review.coreboot.org/20507 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I09a8aa11de2ca14901f142c67c83c4fa0def4e27 Gerrit-Change-Number: 20507 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: 4BA: Flashrom integration for the 4-bytes addressing extensions
by Nico Huber (Code Review) 14 Oct '17

14 Oct '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20505 ) Change subject: 4BA: Flashrom integration for the 4-bytes addressing extensions ...................................................................... Patch Set 3: Code-Review+2 When I last visited this, I was still under the impression that we could merge into a `stable` branch in the future. As that is in doubt, merging this as is seems reasonable to me (up to 20511). I can add the abstraction in the way I imagine it later. -- To view, visit https://review.coreboot.org/20505 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib051cfc93bd4aa7580519e0e6206d025f3ca8049 Gerrit-Change-Number: 20505 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 10:53:28 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! 4BA: Basic support for 4-bytes addressing mode extensions
by Nico Huber (Code Review) 14 Oct '17

14 Oct '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21947 ) Change subject: fixup! 4BA: Basic support for 4-bytes addressing mode extensions ...................................................................... fixup! 4BA: Basic support for 4-bytes addressing mode extensions Fix some whitespace, and braces. Remove sector size from comments that I could not verify. Change-Id: I4faaa036fea744135fa37f405686fb9fd0882806 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/21947 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M flash.h M spi4ba.c 2 files changed, 15 insertions(+), 23 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/flash.h b/flash.h index 611450f..56c0b4f 100644 --- a/flash.h +++ b/flash.h @@ -120,8 +120,8 @@ #define FEATURE_OTP (1 << 8) #define FEATURE_QPI (1 << 9) /* Feature bits used for 4-bytes addressing mode */ -#define FEATURE_4BA_SUPPORT (1 << 10) -#define FEATURE_4BA_ONLY (1 << 11) +#define FEATURE_4BA_SUPPORT (1 << 10) +#define FEATURE_4BA_ONLY (1 << 11) enum test_state { OK = 0, diff --git a/spi4ba.c b/spi4ba.c index 72df874..bf0cf97 100644 --- a/spi4ba.c +++ b/spi4ba.c @@ -43,7 +43,7 @@ msg_trace("-> %s\n", __func__); - /* Switch to 4-bytes addressing mode */ + /* Switch to 4-bytes addressing mode */ return spi_send_command(flash, sizeof(cmd), 0, cmd, NULL); } @@ -71,17 +71,15 @@ msg_trace("-> %s\n", __func__); - /* Switch to 4-bytes addressing mode */ + /* Switch to 4-bytes addressing mode */ result = spi_send_multicommand(flash, cmds); - if (result) { + if (result) msg_cerr("%s failed during command execution\n", __func__); - } return result; } /* Program one flash byte from 4-bytes addressing mode */ -int spi_byte_program_4ba(struct flashctx *flash, unsigned int addr, - uint8_t databyte) +int spi_byte_program_4ba(struct flashctx *flash, unsigned int addr, uint8_t databyte) { int result; struct spi_command cmds[] = { @@ -112,16 +110,13 @@ msg_trace("-> %s (0x%08X)\n", __func__, addr); result = spi_send_multicommand(flash, cmds); - if (result) { - msg_cerr("%s failed during command execution at address 0x%x\n", - __func__, addr); - } + if (result) + msg_cerr("%s failed during command execution at address 0x%x\n", __func__, addr); return result; } /* Program flash bytes from 4-bytes addressing mode */ -int spi_nbyte_program_4ba(struct flashctx *flash, unsigned int addr, - const uint8_t *bytes, unsigned int len) +int spi_nbyte_program_4ba(struct flashctx *flash, unsigned int addr, const uint8_t *bytes, unsigned int len) { int result; unsigned char cmd[(JEDEC_BYTE_PROGRAM_OUTSIZE + 1) - 1 + 256] = { @@ -171,8 +166,7 @@ } /* Read flash bytes from 4-bytes addressing mode */ -int spi_nbyte_read_4ba(struct flashctx *flash, unsigned int addr, - uint8_t *bytes, unsigned int len) +int spi_nbyte_read_4ba(struct flashctx *flash, unsigned int addr, uint8_t *bytes, unsigned int len) { const unsigned char cmd[JEDEC_READ_OUTSIZE + 1] = { JEDEC_READ, @@ -188,9 +182,8 @@ return spi_send_command(flash, sizeof(cmd), len, cmd, bytes); } -/* Erases 4 KB of flash from 4-bytes addressing mode */ -int spi_block_erase_20_4ba(struct flashctx *flash, unsigned int addr, - unsigned int blocklen) +/* Erase one sector of flash from 4-bytes addressing mode */ +int spi_block_erase_20_4ba(struct flashctx *flash, unsigned int addr, unsigned int blocklen) { int result; struct spi_command cmds[] = { @@ -234,9 +227,8 @@ return 0; } -/* Erases 32 KB of flash from 4-bytes addressing mode */ -int spi_block_erase_52_4ba(struct flashctx *flash, unsigned int addr, - unsigned int blocklen) +/* Erase one sector of flash from 4-bytes addressing mode */ +int spi_block_erase_52_4ba(struct flashctx *flash, unsigned int addr, unsigned int blocklen) { int result; struct spi_command cmds[] = { @@ -280,7 +272,7 @@ return 0; } -/* Erases 64 KB of flash from 4-bytes addressing mode */ +/* Erase one sector of flash from 4-bytes addressing mode */ int spi_block_erase_d8_4ba(struct flashctx *flash, unsigned int addr, unsigned int blocklen) { -- To view, visit https://review.coreboot.org/21947 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: merged Gerrit-Change-Id: I4faaa036fea744135fa37f405686fb9fd0882806 Gerrit-Change-Number: 21947 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[stable]: Add iMac5, 2 to board_enable
by David Hendricks (Code Review) 14 Oct '17

14 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21779 ) Change subject: Add iMac5,2 to board_enable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21779 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I618e27f8e726f40ab305b68af2bb31ffd7d96408 Gerrit-Change-Number: 21779 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 00:50:49 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: util: Add CH341a to z60_flashrom.rules
by David Hendricks (Code Review) 14 Oct '17

14 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21778 ) Change subject: util: Add CH341a to z60_flashrom.rules ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21778 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Id1ceebbf406f81a28bd6dae44acd6e569e0c834c Gerrit-Change-Number: 21778 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 00:50:43 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Remove djgpp-dos target
by David Hendricks (Code Review) 14 Oct '17

14 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21777 ) Change subject: Remove djgpp-dos target ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21777 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I81598358f85443d1d53c9fdf5c5ae705ef360c0d Gerrit-Change-Number: 21777 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 00:50:31 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: dediprog: Reimplement target chip option
by David Hendricks (Code Review) 14 Oct '17

14 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21780 ) Change subject: dediprog: Reimplement target chip option ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21780 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I94576967e2892e08295daa829caabace5a367fa0 Gerrit-Change-Number: 21780 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 00:49:56 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! 4BA: Basic support for 4-bytes addressing mode extensions
by David Hendricks (Code Review) 14 Oct '17

14 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21947 ) Change subject: fixup! 4BA: Basic support for 4-bytes addressing mode extensions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21947 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I4faaa036fea744135fa37f405686fb9fd0882806 Gerrit-Change-Number: 21947 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 00:48:59 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! 4BA: Basic support for 4-bytes addressing mode extensions
by build bot (Jenkins) (Code Review) 14 Oct '17

14 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21947 ) Change subject: fixup! 4BA: Basic support for 4-bytes addressing mode extensions ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/763/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/687/ : SUCCESS -- To view, visit https://review.coreboot.org/21947 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I4faaa036fea744135fa37f405686fb9fd0882806 Gerrit-Change-Number: 21947 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 14 Oct 2017 00:48:38 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! 4BA: Basic support for 4-bytes addressing mode extensions
by David Hendricks (Code Review) 14 Oct '17

14 Oct '17

David Hendricks has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/21947 ) Change subject: fixup! 4BA: Basic support for 4-bytes addressing mode extensions ...................................................................... fixup! 4BA: Basic support for 4-bytes addressing mode extensions Fix some whitespace, and braces. Remove sector size from comments that I could not verify. Change-Id: I4faaa036fea744135fa37f405686fb9fd0882806 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flash.h M spi4ba.c 2 files changed, 15 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/21947/2 -- To view, visit https://review.coreboot.org/21947 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4faaa036fea744135fa37f405686fb9fd0882806 Gerrit-Change-Number: 21947 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2017