Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23678 )

Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive
......................................................................

Patch Set 5:

(5 comments)

Hmmm, I'll sleep over it. Don't like the possibility to specify
a conflicting layout file by accident without noticing.

https://review.coreboot.org/#/c/23678/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23678/2//COMMIT_MSG@14
PS2, Line 14: the one in the layoutfile will take
            : precedence
don't like it...

https://review.coreboot.org/#/c/23678/2/cli_classic.c
File cli_classic.c:

https://review.coreboot.org/#/c/23678/2/cli_classic.c@541
PS2, Line 541: 	if (process_include_args(layout)) {
Unrelated: Can somebdoy initialize it to 1 please ;)

https://review.coreboot.org/#/c/23678/2/layout.c
File layout.c:

https://review.coreboot.org/#/c/23678/2/layout.c@100
PS2, Line 100: int flashrom_get_layout_from_ifd(struct flashctx *fill_flash)
Nit, flashrom_ prefix was introduced for the library interface,
not needed here.

https://review.coreboot.org/#/c/23678/2/layout.c@108
PS2, Line 108: 		if (layout.num_entries >= MAX_ROMLAYOUT) {
Still needs an overflow check.

https://review.coreboot.org/#/c/23678/5/layout.c
File layout.c:

https://review.coreboot.org/#/c/23678/5/layout.c@112
PS5, Line 112: 		}
Would probably look nicer before the loop.

if (...->num_entries + ...->num_entries > MAX_ROMLAYOUT)