Hmmm, I'll sleep over it. Don't like the possibility to specify
a conflicting layout file by accident without noticing.

View Change

5 comments:

• Commit Message:

  • Patch Set #2, Line 14:

    the one in the layoutfile will take
    precedence
    

    don't like it...

• File cli_classic.c:

  • Patch Set #2, Line 541: if (process_include_args(layout)) {

    Unrelated: Can somebdoy initialize it to 1 please ;)

• File layout.c:

  • Patch Set #2, Line 100: int flashrom_get_layout_from_ifd(struct flashctx *fill_flash)

    Nit, flashrom_ prefix was introduced for the library interface,
    not needed here.

  • Patch Set #2, Line 108: if (layout.num_entries >= MAX_ROMLAYOUT) {

    Still needs an overflow check.

• File layout.c:

  • Patch Set #5, Line 112: }

    Would probably look nicer before the loop.

        if (...->num_entries + ...->num_entries > MAX_ROMLAYOUT)

To view, visit change 23678. To unsubscribe, or for help writing mail filters, visit settings.