Attention is currently required from: Nico Huber, Namyoon Woo, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 )
Change subject: dummyflasher.c: Extract params processing into a separate function ......................................................................
Patch Set 2:
(4 comments)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54748/comment/edc69df6_255d1d72 PS2, Line 971: free(status); : if (errno != 0 || status == endptr) { For another patch: this has an use-after-free bug, just like the one CB:46551 fixed.
https://review.coreboot.org/c/flashrom/+/54748/comment/f2b3e60e_8c711f43 PS2, Line 975: return 1; This will result in `data->flashchip_contents` leaking. I'd move the initialisation out of init_data(), see comment below.
https://review.coreboot.org/c/flashrom/+/54748/comment/56c51421_15cfc44e PS2, Line 1014: I would initialise `data->flashchip_contents` here:
data->flashchip_contents = malloc(data->emu_chip_size); if (!data->flashchip_contents) { msg_perr("Out of memory!\n"); free(data); return 1; }
https://review.coreboot.org/c/flashrom/+/54748/comment/50bfd870_76ed5651 PS2, Line 1035: emu_persistent_image Meh, this is leaking: CB:54905