Attention is currently required from: Nico Huber, Namyoon Woo, Edward O'Callaghan, Anastasia Klimchuk.

View Change

4 comments:

• File dummyflasher.c:

  • Patch Set #2, Line 971:

    free(status);
    		if (errno != 0 || status == endptr) {
    

    For another patch: this has an use-after-free bug, just like the one CB:46551 fixed.

  • Patch Set #2, Line 975: return 1;

    This will result in `data->flashchip_contents` leaking. I'd move the initialisation out of init_data(), see comment below.

  • Patch Set #2, Line 1014:

    I would initialise `data->flashchip_contents` here:

     data->flashchip_contents = malloc(data->emu_chip_size);
     if (!data->flashchip_contents) {
     	msg_perr("Out of memory!\n");
     	free(data);
     	return 1;
     }

  • Patch Set #2, Line 1035: emu_persistent_image

    Meh, this is leaking: CB:54905

To view, visit change 54748. To unsubscribe, or for help writing mail filters, visit settings.