Attention is currently required from: Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52473 )
Change subject: s25f.c: Fix mismatched function definitions ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52473/comment/10d1cba2_27357512 PS1, Line 8: : This was missed because `uint32_t` is `unsigned int` in most cases. : However, it is not the case for DJGPP 6.1.0 for some reason.
Got no response after several days, marking as resolved.
You got no response for a couple of days because I have been recovering from surgery WTF.. That's why -2'ed to give a pause on this to give me a chance to discuss. I've not actually been at work but been trying to keep up to date so Anastasia and the community can keep moving.
I cannot see how 'unsigned int' would be preferred over uint32_t, the correct type is clearly uint32_t for the intended case.
-
Edward O'Callaghan (Code Review)