Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58475 )
Change subject: spi25_statusreg: make register read/write functions generic ......................................................................
Patch Set 20:
(3 comments)
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/58475/comment/2865d255_4035f2c4 PS15, Line 63: */
Well, it's one thing to avoid a kludge for new use cases but something […]
Done
https://review.coreboot.org/c/flashrom/+/58475/comment/c6ddbaa8_895cba2f PS15, Line 84: *
Doesn't look done. […]
Done - for real this time, sorry about that ;)
https://review.coreboot.org/c/flashrom/+/58475/comment/f80b2dae_5b7b500e PS15, Line 89: }
Are you saying one can't use an if inside switch/case? I've looked […]
Really it was just that a switch with nested ifs creates multiple places that errors have to be handled, but that does make it easier to have specific error messages so I can see the benefit.
-
Nikolai Artemiev (Code Review)