Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.
View Change
3 comments:
File spi25_statusreg.c:
Patch Set #15, Line 63: */
Well, it's one thing to avoid a kludge for new use cases but something […]
Done
Patch Set #15, Line 84: *
Doesn't look done. […]
Done - for real this time, sorry about that ;)
Patch Set #15, Line 89: }
Are you saying one can't use an if inside switch/case? I've looked […]
Really it was just that a switch with nested ifs creates multiple places that errors have to be handled, but that does make it easier to have specific error messages so I can see the benefit.
To view, visit change 58475. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0a3951bbf993f2d8d830143b29d3ce16cc6901d7
Gerrit-Change-Number: 58475
Gerrit-PatchSet: 20
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Mon, 17 Jan 2022 08:45:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>
Gerrit-MessageType: comment