Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58616 )
Change subject: Makefile: move c compiler check to the top ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58616/comment/4b5cf8fe_0e315d74 PS2, Line 7: Makefile: move c compiler check to the top It's doing much more, how about:
Makefile: Revise C compiler check
https://review.coreboot.org/c/flashrom/+/58616/comment/7da04216_e6996102 PS2, Line 10: It's also changing the output, e.g. prints version, and doesn't write into the build-details file. That's ok but should be mentioned.
File Makefile:
https://review.coreboot.org/c/flashrom/+/58616/comment/ae36b1ad_57b932e8 PS2, Line 896: echo $$( Redirection through `echo` seems unnecessary.
File Makefile.d/cc_test.c:
https://review.coreboot.org/c/flashrom/+/58616/comment/bbdcb324_416251fb PS2, Line 4: We could remove the spurious space after the casts while we are at it.
-
Nico Huber (Code Review)