Attention is currently required from: Thomas Heijligen, Angel Pons.

Patch set 2:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 7: Makefile: move c compiler check to the top

    It's doing much more, how about:

       Makefile: Revise C compiler check

  • Patch Set #2, Line 10:

    It's also changing the output, e.g. prints version, and doesn't write
    into the build-details file. That's ok but should be mentioned.

• File Makefile:

  • Patch Set #2, Line 896: echo $$(

    Redirection through `echo` seems unnecessary.

• File Makefile.d/cc_test.c:

  • Patch Set #2, Line 4:

    We could remove the spurious space after the casts while we are at it.

To view, visit change 58616. To unsubscribe, or for help writing mail filters, visit settings.