Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23021 )
Change subject: layout: Add -i <region>[:<file>] support. ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/23021/5/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/23021/5/flashrom.c@1387 PS5, Line 1387: }
For IFD layouts, it's taken care of. For layout files, idk.
being taken care of by normalize_romentries() later. so ok to drop here.
https://review.coreboot.org/#/c/23021/5/layout.c File layout.c:
https://review.coreboot.org/#/c/23021/5/layout.c@189 PS5, Line 189: if (idx < 0) {
What is sane? Regarding IFD region names, those are hardcoded, and always […]
read_romlayout bails out if there are spaces so there is no need for this. same holds for empty strings.
https://review.coreboot.org/#/c/23021/7/layout.c File layout.c:
https://review.coreboot.org/#/c/23021/7/layout.c@206 PS7, Line 206: file = strdup(file); otherwise layout_cleanup calls free(layout.entries[i].file) on an invalid pointer.
-
Arthur Heymans (Code Review)