View Change

3 comments:

• File flashrom.c:

  • Patch Set #5, Line 1387: }

    For IFD layouts, it's taken care of. For layout files, idk.

    being taken care of by normalize_romentries() later. so ok to drop here.

• File layout.c:

  • Patch Set #5, Line 189: if (idx < 0) {

    What is sane? Regarding IFD region names, those are hardcoded, and always […]

    read_romlayout bails out if there are spaces so there is no need for this. same holds for empty strings.

• File layout.c:

  • Patch Set #7, Line 206: file = strdup(file);

    otherwise layout_cleanup calls free(layout.entries[i].file) on an invalid pointer.

To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.