[XS] Change in flashrom[main]: ichspi: Probe opcode in POSSIBLE_OPCODES[] as well

[Nikolai Artemiev (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Bill XIE, Peter Marheine.

Nikolai Artemiev has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84253?usp=email )

Change subject: ichspi: Probe opcode in POSSIBLE_OPCODES[] as well
......................................................................

Patch Set 5: Code-Review+2

(1 comment)

File ichspi.c:

https://review.coreboot.org/c/flashrom/+/84253/comment/ca6d3f7b_b5164420?usp... :
PS1, Line 1843: 
              : static bool ich_spi_probe_opcode(const struct flashctx *flash, uint8_t opcode)
              : {
              : 	return find_opcode(curopcodes, opcode) >= 0;
> I managed to make up a solution to program an erase opcode being probed if it is in the POSSIBLE_OPC […]

Merging the masters seems fine to me. I have reviewed CB:84593 and I'll submit it if there are no objections soon. You can rebase this patch on top of that one.

Also, I assume you originally encountered this problem on an ICH9 device, is that correct? ICH7 shouldn't have had this problem since it didn't have probe_opcode, so flashrom would just assume that all opcodes (including SE) are allowed.