Attention is currently required from: Anastasia Klimchuk, Bill XIE, Peter Marheine.

Patch set 5:Code-Review +2

View Change

1 comment:

• File ichspi.c:

  • Patch Set #1, Line 1843:

    
    static bool ich_spi_probe_opcode(const struct flashctx *flash, uint8_t opcode)
    {
    	return find_opcode(curopcodes, opcode) >= 0;
    

    I managed to make up a solution to program an erase opcode being probed if it is in the POSSIBLE_OPC […]

    Merging the masters seems fine to me. I have reviewed CB:84593 and I'll submit it if there are no objections soon. You can rebase this patch on top of that one.

    Also, I assume you originally encountered this problem on an ICH9 device, is that correct? ICH7 shouldn't have had this problem since it didn't have probe_opcode, so flashrom would just assume that all opcodes (including SE) are allowed.

To view, visit change 84253. To unsubscribe, or for help writing mail filters, visit settings.