Attention is currently required from: Anastasia Klimchuk, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Peter Marheine, Sergii Dmytruk.
Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email )
Change subject: Move SPI declarations from flash.h to spi.h ......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/85539/comment/cf803667_ebd64052?usp... : PS2, Line 7: Extract SPI declarations to the correct header
Nit: "extract" usually means creating something new in the process of move (header in this case), so […]
Message was not very descriptive. I hope is better now!
https://review.coreboot.org/c/flashrom/+/85539/comment/8153cfe9_dcbf0b0e?usp... : PS2, Line 8:
My only comment here is that now that the patch goes across the whole tree, maybe you can add to a c […]
I also tried to improve the message! Done!
File edi.c:
https://review.coreboot.org/c/flashrom/+/85539/comment/9e0b9de5_c2a4c1ac?usp... : PS2, Line 18: #include <spi.h>
These are not system includes, so the newly-added lines should still be quoted (`"spi.h"`). […]
Thanks for the pointer! I will try to keep this consistent. Done :)
File include/spi.h:
https://review.coreboot.org/c/flashrom/+/85539/comment/632f4f1c_4c4a7c01?usp... : PS2, Line 19: #include <flash.h>
Same as for `spi.h`, quote this instead of using angle brackets.
Done
-
Antonio Vázquez Blanco (Code Review)