Attention is currently required from: Anastasia Klimchuk, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Peter Marheine, Sergii Dmytruk.

View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 7: Extract SPI declarations to the correct header

    Nit: "extract" usually means creating something new in the process of move (header in this case), so […]

    Message was not very descriptive. I hope is better now!

  • Patch Set #2, Line 8:

    My only comment here is that now that the patch goes across the whole tree, maybe you can add to a c […]

    I also tried to improve the message! Done!

• File edi.c:

  • Patch Set #2, Line 18: #include <spi.h>

    These are not system includes, so the newly-added lines should still be quoted (`"spi.h"`). […]

    Thanks for the pointer! I will try to keep this consistent. Done :)

• File include/spi.h:

  • Patch Set #2, Line 19: #include <flash.h>

    Same as for `spi.h`, quote this instead of using angle brackets.

    Done

To view, visit change 85539. To unsubscribe, or for help writing mail filters, visit settings.