[M] Change in flashrom[master]: libflashrom.c: Invert if conditions to improve the readability
Attention is currently required from: Edward O'Callaghan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68153 )
Change subject: libflashrom.c: Invert if conditions to improve the readability ......................................................................
Patch Set 6:
(2 comments)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/68153/comment/c8f0df98_93257f04 PS3, Line 103: (;
optional: while we are here could we just scope the indexer into the loop construct. […]
Done
https://review.coreboot.org/c/flashrom/+/68153/comment/aee63750_06fa30dc PS3, Line 107: (enum flashrom_test_state)
is this cast needed?
There are duplicate definitions for this. `test_state` in flash.h and `flashrom_test_state` in libflashrom.h. The latter is only used for the functions I'm cleaning up here.
-
Felix Singer (Code Review)