Attention is currently required from: Edward O'Callaghan.

View Change

2 comments:

• File libflashrom.c:

  • Patch Set #3, Line 103: (;

    optional: while we are here could we just scope the indexer into the loop construct. […]

    Done

  • Patch Set #3, Line 107: (enum flashrom_test_state)

    is this cast needed?

    There are duplicate definitions for this. `test_state` in flash.h and `flashrom_test_state` in libflashrom.h. The latter is only used for the functions I'm cleaning up here.

To view, visit change 68153. To unsubscribe, or for help writing mail filters, visit settings.